1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Group show page' do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
let(:path) { group_path(group) }
context 'when signed in' do
context 'with non-admin group concerns' do
before do
group.add_developer(user)
sign_in(user)
visit path
end
it_behaves_like "an autodiscoverable RSS feed with current_user's feed token"
context 'when group does not exist' do
let(:path) { group_path('not-exist') }
it { expect(status_code).to eq(404) }
end
end
context 'when user is an owner' do
before do
group.add_owner(user)
sign_in(user)
end
it 'shows the invite banner and persists dismissal', :js do
visit path
expect(page).to have_content('Collaborate with your team')
page.within(find('[data-testid="invite-members-banner"]')) do
find('[data-testid="close-icon"]').click
end
expect(page).not_to have_content('Collaborate with your team')
visit path
expect(page).not_to have_content('Collaborate with your team')
end
context 'when group has a project with emoji in description', :js do
let!(:project) { create(:project, description: ':smile:', namespace: group) }
it 'shows the project info', :aggregate_failures do
visit path
expect(page).to have_content(project.title)
expect(page).to have_emoji('smile')
end
end
context 'when group has projects' do
it 'allows users to sorts projects by most stars', :js do
project1 = create(:project, namespace: group, star_count: 2)
project2 = create(:project, namespace: group, star_count: 3)
project3 = create(:project, namespace: group, star_count: 0)
visit group_path(group, sort: :stars_desc)
expect(find('.group-row:nth-child(1) .namespace-title > a')).to have_content(project2.title)
expect(find('.group-row:nth-child(2) .namespace-title > a')).to have_content(project1.title)
expect(find('.group-row:nth-child(3) .namespace-title > a')).to have_content(project3.title)
end
end
end
context 'subgroups and projects empty state', :js do
context 'when user has permissions to create new subgroups or projects' do
before do
group.add_owner(user)
sign_in(user)
visit path
end
it 'shows `Create new subgroup` link' do
expect(page).to have_link(
s_('GroupsEmptyState|Create new subgroup'),
href: new_group_path(parent_id: group.id)
)
end
it 'shows `Create new project` link' do
expect(page).to have_link(
s_('GroupsEmptyState|Create new project'),
href: new_project_path(namespace_id: group.id)
)
end
end
end
context 'when a public project is shared with a private group' do
let_it_be(:private_group) { create(:group, :private) }
let_it_be(:public_project) { create(:project, :public) }
let_it_be(:project_group_link) { create(:project_group_link, group: private_group, project: public_project) }
before do
private_group.add_owner(user)
sign_in(user)
end
it 'shows warning popover', :js do
visit group_path(private_group)
click_link _('Shared projects')
wait_for_requests
page.within("[data-testid=\"group-overview-item-#{public_project.id}\"]") do
click_button _('Less restrictive visibility')
end
expect(page).to have_content _('Project visibility level is less restrictive than the group settings.')
end
end
context 'when user does not have permissions to create new subgroups or projects', :js do
before do
group.add_reporter(user)
sign_in(user)
visit path
end
it 'does not show `Create new subgroup` link' do
expect(page).not_to have_link(
s_('GroupsEmptyState|Create new subgroup'),
href: new_group_path(parent_id: group.id)
)
end
it 'does not show `Create new project` link' do
expect(page).not_to have_link(
s_('GroupsEmptyState|Create new project'),
href: new_project_path(namespace_id: group.id)
)
end
it 'shows empty state' do
expect(page).to have_content(s_('GroupsEmptyState|No subgroups or projects.'))
expect(page).to have_content(s_('GroupsEmptyState|You do not have necessary permissions to create a subgroup' \
' or project in this group. Please contact an owner of this group to create a new subgroup or project.'))
end
end
end
context 'when signed out' do
describe 'RSS' do
before do
visit path
end
it_behaves_like "an autodiscoverable RSS feed without a feed token"
end
context 'when group has a public project', :js do
let!(:project) { create(:project, :public, namespace: group) }
it 'renders public project', :aggregate_failures do
visit path
expect(page).to have_link group.name
expect(page).to have_link project.name
end
end
context 'when group has a private project', :js do
let!(:project) { create(:project, :private, namespace: group) }
it 'does not render private project', :aggregate_failures do
visit path
expect(page).to have_link group.name
expect(page).not_to have_link project.name
end
end
end
context 'subgroup support' do
let_it_be(:restricted_group) do
create(:group, subgroup_creation_level: ::Gitlab::Access::OWNER_SUBGROUP_ACCESS)
end
context 'for owners' do
before do
restricted_group.add_owner(user)
sign_in(user)
end
context 'when subgroups are supported' do
it 'allows creating subgroups' do
visit group_path(restricted_group)
expect(page).to have_link('New subgroup')
end
end
end
context 'for maintainers' do
before do
sign_in(user)
end
context 'when subgroups are supported' do
context 'when subgroup_creation_level is set to maintainers' do
let(:relaxed_group) do
create(:group, subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS)
end
before do
relaxed_group.add_maintainer(user)
end
it 'allows creating subgroups' do
visit group_path(relaxed_group)
expect(page).to have_link('New subgroup')
end
end
context 'when subgroup_creation_level is set to owners' do
before do
restricted_group.add_maintainer(user)
end
it 'does not allow creating subgroups' do
visit group_path(restricted_group)
expect(page).not_to have_link('New subgroup')
end
end
end
end
end
context 'notification button', :js do
before do
group.add_maintainer(user)
sign_in(user)
end
it 'is enabled by default' do
visit path
expect(page).to have_selector('[data-testid="notification-dropdown"] button:not(.disabled)')
end
it 'is disabled if emails are disabled' do
group.update!(emails_disabled: true)
visit path
expect(page).to have_selector('[data-testid="notification-dropdown"] .disabled')
end
end
context 'page og:description' do
before do
group.update!(description: '**Lorem** _ipsum_ dolor sit [amet](https://example.com)')
group.add_maintainer(user)
sign_in(user)
visit path
end
it_behaves_like 'page meta description', 'Lorem ipsum dolor sit amet'
end
context 'structured schema markup' do
let_it_be(:group) { create(:group, :public, :with_avatar, description: 'foo') }
let_it_be(:subgroup) { create(:group, :public, :with_avatar, parent: group, description: 'bar') }
let_it_be_with_reload(:project) { create(:project, :public, :with_avatar, namespace: group, description: 'foo') }
let_it_be(:subproject) { create(:project, :public, :with_avatar, namespace: subgroup, description: 'bar') }
it 'shows Organization structured markup', :js do
visit path
wait_for_all_requests
aggregate_failures do
expect(page).to have_selector('.content[itemscope][itemtype="https://schema.org/Organization"]')
page.within('.group-home-panel') do
expect(page).to have_selector('[itemprop="logo"]')
expect(page).to have_selector('[itemprop="name"]', text: group.name)
expect(page).to have_selector('[itemprop="description"]', text: group.description)
end
page.within('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]') do
expect(page).to have_selector('[itemprop="image"]')
expect(page).to have_selector('[itemprop="name"]', text: project.name)
expect(page).to have_selector('[itemprop="description"]', text: project.description)
end
# Finding the subgroup row and expanding it
el = find('[itemprop="subOrganization"][itemtype="https://schema.org/Organization"]')
el.click
wait_for_all_requests
page.within(el) do
expect(page).to have_selector('[itemprop="logo"]')
expect(page).to have_selector('[itemprop="name"]', text: subgroup.name)
expect(page).to have_selector('[itemprop="description"]', text: subgroup.description)
page.within('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]') do
expect(page).to have_selector('[itemprop="image"]')
expect(page).to have_selector('[itemprop="name"]', text: subproject.name)
expect(page).to have_selector('[itemprop="description"]', text: subproject.description)
end
end
end
end
it 'does not include structured markup in shared projects tab', :aggregate_failures, :js do
other_project = create(:project, :public)
other_project.project_group_links.create!(group: group)
visit group_shared_path(group)
wait_for_all_requests
expect(page).to have_selector('li.group-row')
expect(page).not_to have_selector('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]')
end
it 'does not include structured markup in archived projects tab', :aggregate_failures, :js do
project.update!(archived: true)
visit group_archived_path(group)
wait_for_all_requests
expect(page).to have_selector('li.group-row')
expect(page).not_to have_selector('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]')
end
end
end
|