summaryrefslogtreecommitdiff
path: root/spec/features/issues/issue_sidebar_spec.rb
blob: 38d11ee2560d03f52acf3dcdcf614901490ba5bd (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Issue Sidebar' do
  include MobileHelpers

  let(:group) { create(:group, :nested) }
  let(:project) { create(:project, :public, namespace: group) }
  let!(:user) { create(:user) }
  let!(:label) { create(:label, project: project, title: 'bug') }
  let(:issue) { create(:labeled_issue, project: project, labels: [label]) }
  let!(:xss_label) { create(:label, project: project, title: '<script>alert("xss");</script>') }

  before do
    sign_in(user)
  end

  context 'assignee', :js do
    let(:user2) { create(:user) }
    let(:issue2) { create(:issue, project: project, author: user2) }

    context 'when invite_members_version_a experiment is enabled' do
      before do
        stub_experiment_for_user(invite_members_version_a: true)
      end

      context 'when user can not see invite members' do
        before do
          project.add_developer(user)
          visit_issue(project, issue2)

          find('.block.assignee .edit-link').click

          wait_for_requests
        end

        it 'does not see link to invite members' do
          page.within '.dropdown-menu-user' do
            expect(page).not_to have_link('Invite Members')
          end
        end
      end

      context 'when user can see invite members' do
        before do
          project.add_maintainer(user)
          visit_issue(project, issue2)

          find('.block.assignee .edit-link').click

          wait_for_requests
        end

        it 'sees link to invite members' do
          page.within '.dropdown-menu-user' do
            expect(page).to have_link('Invite Members', href: project_project_members_path(project))
            expect(page).to have_selector('[data-track-event="click_invite_members"]')
            expect(page).to have_selector("[data-track-label='edit_assignee']")
          end
        end
      end
    end

    context 'when invite_members_version_a experiment is not enabled' do
      context 'when user is a developer' do
        before do
          project.add_developer(user)
          visit_issue(project, issue2)

          find('.block.assignee .edit-link').click

          wait_for_requests
        end

        it 'shows author in assignee dropdown' do
          page.within '.dropdown-menu-user' do
            expect(page).to have_content(user2.name)
          end
        end

        it 'shows author when filtering assignee dropdown' do
          page.within '.dropdown-menu-user' do
            find('.dropdown-input-field').native.send_keys user2.name
            sleep 1 # Required to wait for end of input delay

            wait_for_requests

            expect(page).to have_content(user2.name)
          end
        end

        it 'assigns yourself' do
          find('.block.assignee .dropdown-menu-toggle').click

          click_button 'assign yourself'

          wait_for_requests

          find('.block.assignee .edit-link').click

          page.within '.dropdown-menu-user' do
            expect(page.find('.dropdown-header')).to be_visible
            expect(page.find('.dropdown-menu-user-link.is-active')).to have_content(user.name)
          end
        end

        it 'keeps your filtered term after filtering and dismissing the dropdown' do
          find('.dropdown-input-field').native.send_keys user2.name

          wait_for_requests

          page.within '.dropdown-menu-user' do
            expect(page).not_to have_content 'Unassigned'
            click_link user2.name
          end

          find('.js-right-sidebar').click
          find('.block.assignee .edit-link').click

          expect(page.all('.dropdown-menu-user li').length).to eq(1)
          expect(find('.dropdown-input-field').value).to eq(user2.name)
        end
      end

      context 'when user is a maintainer' do
        before do
          project.add_maintainer(user)
          visit_issue(project, issue2)

          find('.block.assignee .edit-link').click

          wait_for_requests
        end

        it 'shows author in assignee dropdown and no invite link' do
          page.within '.dropdown-menu-user' do
            expect(page).not_to have_link('Invite Members')
          end
        end
      end
    end
  end

  context 'as a allowed user' do
    before do
      project.add_developer(user)
      visit_issue(project, issue)
    end

    context 'sidebar', :js do
      it 'changes size when the screen size is smaller' do
        sidebar_selector = 'aside.right-sidebar.right-sidebar-collapsed'
        # Resize the window
        resize_screen_sm
        # Make sure the sidebar is collapsed
        find(sidebar_selector)
        expect(page).to have_css(sidebar_selector)
        # Once is collapsed let's open the sidebard and reload
        open_issue_sidebar
        refresh
        find(sidebar_selector)
        expect(page).to have_css(sidebar_selector)
        # Restore the window size as it was including the sidebar
        restore_window_size
        open_issue_sidebar
      end

      it 'escapes XSS when viewing issue labels' do
        page.within('.block.labels') do
          click_on 'Edit'

          expect(page).to have_content '<script>alert("xss");</script>'
        end
      end
    end

    context 'editing issue labels', :js do
      before do
        issue.update(labels: [label])
        page.within('.block.labels') do
          click_on 'Edit'
        end
      end

      it 'shows the current set of labels' do
        page.within('.issuable-show-labels') do
          expect(page).to have_content label.title
        end
      end

      it 'shows option to create a project label' do
        page.within('.block.labels') do
          expect(page).to have_content 'Create project'
        end
      end

      context 'creating a project label', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27992' do
        before do
          page.within('.block.labels') do
            click_link 'Create project'
          end
        end

        it 'shows dropdown switches to "create label" section' do
          page.within('.block.labels') do
            expect(page).to have_content 'Create project label'
          end
        end

        it 'adds new label' do
          page.within('.block.labels') do
            fill_in 'new_label_name', with: 'wontfix'
            page.find('.suggest-colors a', match: :first).click
            page.find('button', text: 'Create').click

            page.within('.dropdown-page-one') do
              expect(page).to have_content 'wontfix'
            end
          end
        end

        it 'shows error message if label title is taken' do
          page.within('.block.labels') do
            fill_in 'new_label_name', with: label.title
            page.find('.suggest-colors a', match: :first).click
            page.find('button', text: 'Create').click

            page.within('.dropdown-page-two') do
              expect(page).to have_content 'Title has already been taken'
            end
          end
        end
      end
    end

    context 'interacting with collapsed sidebar', :js do
      collapsed_sidebar_selector = 'aside.right-sidebar.right-sidebar-collapsed'
      expanded_sidebar_selector = 'aside.right-sidebar.right-sidebar-expanded'
      confidentiality_sidebar_block = '.block.confidentiality'
      lock_sidebar_block = '.block.lock'
      collapsed_sidebar_block_icon = '.sidebar-collapsed-icon'

      before do
        resize_screen_sm
      end

      it 'confidentiality block expands then collapses sidebar' do
        expect(page).to have_css(collapsed_sidebar_selector)

        page.within(confidentiality_sidebar_block) do
          find(collapsed_sidebar_block_icon).click
        end

        expect(page).to have_css(expanded_sidebar_selector)

        page.within(confidentiality_sidebar_block) do
          page.find('button', text: 'Cancel').click
        end

        expect(page).to have_css(collapsed_sidebar_selector)
      end

      it 'lock block expands then collapses sidebar' do
        expect(page).to have_css(collapsed_sidebar_selector)

        page.within(lock_sidebar_block) do
          find(collapsed_sidebar_block_icon).click
        end

        expect(page).to have_css(expanded_sidebar_selector)

        page.within(lock_sidebar_block) do
          page.find('button', text: 'Cancel').click
        end

        expect(page).to have_css(collapsed_sidebar_selector)
      end
    end
  end

  context 'as a guest' do
    before do
      project.add_guest(user)
      visit_issue(project, issue)
    end

    it 'does not have a option to edit labels' do
      expect(page).not_to have_selector('.block.labels .js-sidebar-dropdown-toggle')
    end

    context 'interacting with collapsed sidebar', :js do
      collapsed_sidebar_selector = 'aside.right-sidebar.right-sidebar-collapsed'
      expanded_sidebar_selector = 'aside.right-sidebar.right-sidebar-expanded'
      lock_sidebar_block = '.block.lock'
      lock_button = '.block.lock .btn-close'
      collapsed_sidebar_block_icon = '.sidebar-collapsed-icon'

      before do
        resize_screen_sm
      end

      it 'expands then does not show the lock dialog form' do
        expect(page).to have_css(collapsed_sidebar_selector)

        page.within(lock_sidebar_block) do
          find(collapsed_sidebar_block_icon).click
        end

        expect(page).to have_css(expanded_sidebar_selector)
        expect(page).not_to have_selector(lock_button)
      end
    end
  end

  def visit_issue(project, issue)
    visit project_issue_path(project, issue)
  end

  def open_issue_sidebar
    find('aside.right-sidebar.right-sidebar-collapsed .js-sidebar-toggle').click
    find('aside.right-sidebar.right-sidebar-expanded')
  end
end