1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Observability rendering', :js do
let_it_be(:group) { create(:group, :public) }
let_it_be(:project) { create(:project, :repository, group: group) }
let_it_be(:user) { create(:user) }
let_it_be(:observable_url) { "https://observe.gitlab.com/" }
let_it_be(:expected) do
%(<iframe src="#{observable_url}?theme=light&kiosk" frameborder="0")
end
before do
project.add_maintainer(user)
sign_in(user)
end
context 'when embedding in an issue' do
let(:issue) do
create(:issue, project: project, description: observable_url)
end
before do
visit project_issue_path(project, issue)
wait_for_requests
end
it 'renders iframe in description' do
page.within('.description') do
expect(page.html).to include(expected)
end
end
it 'renders iframe in comment' do
expect(page).not_to have_css('.note-text')
page.within('.js-main-target-form') do
fill_in('note[note]', with: observable_url)
click_button('Comment')
end
wait_for_requests
page.within('.note-text') do
expect(page.html).to include(expected)
end
end
end
context 'when embedding in an MR' do
let(:merge_request) do
create(:merge_request, source_project: project, target_project: project, description: observable_url)
end
before do
visit merge_request_path(merge_request)
wait_for_requests
end
it 'renders iframe in description' do
page.within('.description') do
expect(page.html).to include(expected)
end
end
it 'renders iframe in comment' do
expect(page).not_to have_css('.note-text')
page.within('.js-main-target-form') do
fill_in('note[note]', with: observable_url)
click_button('Comment')
end
wait_for_requests
page.within('.note-text') do
expect(page.html).to include(expected)
end
end
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(observability_group_tab: false)
end
context 'when embedding in an issue' do
let(:issue) do
create(:issue, project: project, description: observable_url)
end
before do
visit project_issue_path(project, issue)
wait_for_requests
end
it 'does not render iframe in description' do
page.within('.description') do
expect(page.html).not_to include(expected)
expect(page.html).to include(observable_url)
end
end
it 'does not render iframe in comment' do
expect(page).not_to have_css('.note-text')
page.within('.js-main-target-form') do
fill_in('note[note]', with: observable_url)
click_button('Comment')
end
wait_for_requests
page.within('.note-text') do
expect(page.html).not_to include(expected)
expect(page.html).to include(observable_url)
end
end
end
context 'when embedding in an MR' do
let(:merge_request) do
create(:merge_request, source_project: project, target_project: project, description: observable_url)
end
before do
visit merge_request_path(merge_request)
wait_for_requests
end
it 'does not render iframe in description' do
page.within('.description') do
expect(page.html).not_to include(expected)
expect(page.html).to include(observable_url)
end
end
it 'does not render iframe in comment' do
expect(page).not_to have_css('.note-text')
page.within('.js-main-target-form') do
fill_in('note[note]', with: observable_url)
click_button('Comment')
end
wait_for_requests
page.within('.note-text') do
expect(page.html).not_to include(expected)
expect(page.html).to include(observable_url)
end
end
end
end
end
|
