summaryrefslogtreecommitdiff
path: root/spec/features/merge_request/user_sees_pipelines_spec.rb
blob: cab940ba704256eff8bc197f1652bc0744f7d649 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Merge request > User sees pipelines', :js, feature_category: :code_review_workflow do
  describe 'pipeline tab' do
    let(:merge_request) { create(:merge_request) }
    let(:project) { merge_request.target_project }
    let(:user) { project.creator }

    before do
      project.add_maintainer(user)
      sign_in(user)
    end

    context 'with pipelines' do
      let!(:pipeline) do
        create(:ci_empty_pipeline,
               project: merge_request.source_project,
               ref: merge_request.source_branch,
               sha: merge_request.diff_head_sha)
      end

      before do
        merge_request.update_attribute(:head_pipeline_id, pipeline.id)
      end

      it 'user visits merge request pipelines tab' do
        visit project_merge_request_path(project, merge_request)

        expect(page.find('.ci-widget')).to have_content('pending')

        page.within('.merge-request-tabs') do
          click_link('Pipelines')
        end
        wait_for_requests

        expect(page).to have_css('[data-testid="pipeline-mini-graph"]')
      end

      context 'with a detached merge request pipeline' do
        let(:merge_request) { create(:merge_request, :with_detached_merge_request_pipeline) }

        it 'displays the "Run pipeline" button' do
          visit project_merge_request_path(project, merge_request)

          page.within('.merge-request-tabs') do
            click_link('Pipelines')
          end

          wait_for_requests

          expect(page.find('[data-testid="run_pipeline_button"]')).to have_text('Run pipeline')
        end
      end

      context 'with a merged results pipeline' do
        let(:merge_request) { create(:merge_request, :with_merge_request_pipeline) }

        it 'displays the "Run pipeline" button' do
          visit project_merge_request_path(project, merge_request)

          page.within('.merge-request-tabs') do
            click_link('Pipelines')
          end

          wait_for_requests

          expect(page.find('[data-testid="run_pipeline_button"]')).to have_text('Run pipeline')
        end
      end
    end

    context 'without pipelines' do
      before do
        visit project_merge_request_path(project, merge_request)
      end

      it 'user visits merge request page' do
        page.within('.merge-request-tabs') do
          expect(page).to have_link('Pipelines')
        end
      end

      it 'shows empty state with run pipeline button' do
        page.within('.merge-request-tabs') do
          click_link('Pipelines')
        end

        expect(page).to have_content('There are currently no pipelines.')
        expect(page.find('[data-testid="run_pipeline_button"]')).to have_text('Run pipeline')
      end
    end
  end

  describe 'fork MRs in parent project', :sidekiq_inline do
    include ProjectForksHelper

    let_it_be(:parent_project) { create(:project, :public, :repository) }
    let_it_be(:forked_project) { fork_project(parent_project, developer_in_fork, repository: true, target_project: create(:project, :public, :repository)) }
    let_it_be(:developer_in_parent) { create(:user) }
    let_it_be(:developer_in_fork) { create(:user) }
    let_it_be(:reporter_in_parent_and_developer_in_fork) { create(:user) }

    let(:merge_request) do
      create(:merge_request, :with_detached_merge_request_pipeline,
                             source_project: forked_project, source_branch: 'feature',
                             target_project: parent_project, target_branch: 'master')
    end

    let(:config) do
      { test: { script: 'test', rules: [{ if: '$CI_MERGE_REQUEST_ID' }] } }
    end

    before_all do
      parent_project.add_developer(developer_in_parent)
      parent_project.add_reporter(reporter_in_parent_and_developer_in_fork)
      forked_project.add_developer(developer_in_fork)
      forked_project.add_developer(reporter_in_parent_and_developer_in_fork)
    end

    before do
      stub_ci_pipeline_yaml_file(YAML.dump(config))
      sign_in(actor)
    end

    after do
      parent_project.all_pipelines.delete_all
      forked_project.all_pipelines.delete_all
    end

    context 'when actor is a developer in parent project' do
      let(:actor) { developer_in_parent }

      it 'creates a pipeline in the parent project when user proceeds with the warning' do
        visit project_merge_request_path(parent_project, merge_request)

        create_merge_request_pipeline
        act_on_security_warning(action: 'Run pipeline')

        check_pipeline(expected_project: parent_project)
        check_head_pipeline(expected_project: parent_project)
      end

      it 'does not create a pipeline in the parent project when user cancels the action', :clean_gitlab_redis_cache, :clean_gitlab_redis_shared_state do
        visit project_merge_request_path(parent_project, merge_request)

        create_merge_request_pipeline
        act_on_security_warning(action: 'Cancel')

        check_no_pipelines
      end
    end

    context 'when actor is a developer in fork project' do
      let(:actor) { developer_in_fork }

      it 'creates a pipeline in the fork project' do
        visit project_merge_request_path(parent_project, merge_request)

        create_merge_request_pipeline

        check_pipeline(expected_project: forked_project)
        check_head_pipeline(expected_project: forked_project)
      end
    end

    context 'when actor is a reporter in parent project and a developer in fork project' do
      let(:actor) { reporter_in_parent_and_developer_in_fork }

      it 'creates a pipeline in the fork project' do
        visit project_merge_request_path(parent_project, merge_request)

        create_merge_request_pipeline

        check_pipeline(expected_project: forked_project)
        check_head_pipeline(expected_project: forked_project)
      end
    end

    def create_merge_request_pipeline
      page.within('.merge-request-tabs') { click_link('Pipelines') }
      click_button('Run pipeline')
    end

    def check_pipeline(expected_project:)
      page.within('.ci-table') do
        expect(page).to have_selector('.commit', count: 2)

        page.within(first('.commit')) do
          page.within('.pipeline-tags') do
            expect(page.find('[data-testid="pipeline-url-link"]')[:href]).to include(expected_project.full_path)
            expect(page).to have_content('merge request')
          end
          page.within('.pipeline-triggerer') do
            expect(page).to have_link(href: user_path(actor))
          end
        end
      end
    end

    def check_head_pipeline(expected_project:)
      page.within('.merge-request-tabs') { click_link('Overview') }

      page.within('.ci-widget-content') do
        expect(page.find('.pipeline-id')[:href]).to include(expected_project.full_path)
      end
    end

    def act_on_security_warning(action:)
      page.within('#create-pipeline-for-fork-merge-request-modal') do
        expect(page).to have_content('Are you sure you want to run this pipeline?')
        click_button(action)
      end
    end

    def check_no_pipelines
      page.within('.ci-table') do
        expect(page).to have_selector('.commit', count: 1)
      end
    end
  end

  describe 'race condition' do
    let(:project) { create(:project, :repository) }
    let(:user) { create(:user) }
    let(:build_push_data) { { ref: 'feature', checkout_sha: TestEnv::BRANCH_SHA['feature'] } }

    let(:merge_request_params) do
      { "source_branch" => "feature", "source_project_id" => project.id,
        "target_branch" => "master", "target_project_id" => project.id, "title" => "A" }
    end

    before do
      project.add_maintainer(user)
      sign_in user
    end

    context 'when pipeline and merge request were created simultaneously', :delete do
      before do
        stub_ci_pipeline_to_return_yaml_file

        threads = []

        threads << Thread.new do
          Sidekiq::Worker.skipping_transaction_check do
            @merge_request = MergeRequests::CreateService.new(project: project, current_user: user, params: merge_request_params).execute
          end
        end

        threads << Thread.new do
          Sidekiq::Worker.skipping_transaction_check do
            @pipeline = Ci::CreatePipelineService.new(project, user, build_push_data).execute(:push).payload
          end
        end

        threads.each { |thr| thr.join }
      end

      it 'user sees pipeline in merge request widget', :sidekiq_might_not_need_inline do
        visit project_merge_request_path(project, @merge_request)

        expect(page.find(".ci-widget")).to have_content(TestEnv::BRANCH_SHA['feature'])
        expect(page.find(".ci-widget")).to have_content("##{@pipeline.id}")
      end
    end
  end
end