1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'viewing issues with design references' do
include DesignManagementTestHelpers
let_it_be(:public_project) { create(:project_empty_repo, :public) }
let_it_be(:private_project) { create(:project_empty_repo) }
let(:user) { create(:user) }
let(:design_issue) { create(:issue, project: project) }
let(:design_a) { create(:design, :with_file, issue: design_issue) }
let(:design_b) { create(:design, :with_file, issue: design_issue) }
let(:issue_ref) { design_issue.to_reference(public_project) }
let(:design_ref_a) { design_a.to_reference(public_project) }
let(:design_ref_b) { design_b.to_reference(public_project) }
let(:design_tab_ref) { "#{issue_ref} (designs)" }
let(:description) do
<<~MD
The designs I mentioned:
* #{url_for_designs(design_issue)}
* #{url_for_design(design_a)}
* #{url_for_design(design_b)}
MD
end
def visit_page_with_design_references
public_issue = create(:issue, project: public_project, description: description)
visit project_issue_path(public_issue.project, public_issue)
end
shared_examples 'successful use of design link references' do
before do
enable_design_management
end
it 'shows the issue description and design references', :aggregate_failures do
visit_page_with_design_references
expect(page).to have_text('The designs I mentioned')
expect(page).to have_link(design_tab_ref)
expect(page).to have_link(design_ref_a)
expect(page).to have_link(design_ref_b)
end
end
context 'the user has access to a public project' do
let(:project) { public_project }
it_behaves_like 'successful use of design link references'
end
context 'the user does not have access to a private project' do
let(:project) { private_project }
it 'redacts inaccessible design references', :aggregate_failures do
visit_page_with_design_references
expect(page).to have_text('The designs I mentioned')
expect(page).not_to have_link(issue_ref)
expect(page).not_to have_link(design_tab_ref)
expect(page).not_to have_link(design_ref_a)
expect(page).not_to have_link(design_ref_b)
end
end
context 'the user has access to a private project' do
let(:project) { private_project }
before do
project.add_developer(user)
sign_in(user)
end
it_behaves_like 'successful use of design link references'
context 'design management is entirely disabled' do
it 'processes design links as issue references', :aggregate_failures do
enable_design_management(false)
visit_page_with_design_references
expect(page).to have_text('The designs I mentioned')
expect(page).to have_link(issue_ref)
expect(page).not_to have_link(design_tab_ref)
expect(page).not_to have_link(design_ref_a)
expect(page).not_to have_link(design_ref_b)
end
end
end
end
|
