summaryrefslogtreecommitdiff
path: root/spec/features/todos/todos_spec.rb
blob: 850020109d417b4f587085a9e1f185558f71cb53 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
require 'spec_helper'

describe 'Dashboard Todos', feature: true do
  include WaitForAjax

  let(:user)    { create(:user) }
  let(:author)  { create(:user) }
  let(:project) { create(:project, visibility_level: Gitlab::VisibilityLevel::PUBLIC) }
  let(:issue)   { create(:issue, due_date: Date.today) }

  describe 'GET /dashboard/todos' do
    context 'User does not have todos' do
      before do
        login_as(user)
        visit dashboard_todos_path
      end
      it 'shows "All done" message' do
        expect(page).to have_content "Todos let you see what you should do next."
      end
    end

    context 'User has a todo', js: true do
      before do
        create(:todo, :mentioned, user: user, project: project, target: issue, author: author)
        login_as(user)
        visit dashboard_todos_path
      end

      it 'has todo present' do
        expect(page).to have_selector('.todos-list .todo', count: 1)
      end

      it 'shows due date as today' do
        within first('.todo') do
          expect(page).to have_content 'Due today'
        end
      end

      shared_examples 'deleting the todo' do
        before do
          within first('.todo') do
            click_link 'Done'
          end
        end

        it 'is marked as done-reversible in the list' do
          expect(page).to have_selector('.todos-list .todo.todo-pending.done-reversible')
        end

        it 'shows Undo button' do
          expect(page).to have_selector('.js-undo-todo', visible: true)
          expect(page).to have_selector('.js-done-todo', visible: false)
        end

        it 'updates todo count' do
          expect(page).to have_content 'To do 0'
          expect(page).to have_content 'Done 1'
        end

        it 'has not "All done" message' do
          expect(page).not_to have_selector('.todos-all-done')
        end
      end

      shared_examples 'deleting and restoring the todo' do
        before do
          within first('.todo') do
            click_link 'Done'
            wait_for_ajax
            click_link 'Undo'
          end
        end

        it 'is marked back as pending in the list' do
          expect(page).not_to have_selector('.todos-list .todo.todo-pending.done-reversible')
          expect(page).to have_selector('.todos-list .todo.todo-pending')
        end

        it 'shows Done button' do
          expect(page).to have_selector('.js-undo-todo', visible: false)
          expect(page).to have_selector('.js-done-todo', visible: true)
        end

        it 'updates todo count' do
          expect(page).to have_content 'To do 1'
          expect(page).to have_content 'Done 0'
        end
      end

      it_behaves_like 'deleting the todo'
      it_behaves_like 'deleting and restoring the todo'

      context 'todo is stale on the page' do
        before do
          todos = TodosFinder.new(user, state: :pending).execute
          TodoService.new.mark_todos_as_done(todos, user)
        end

        it_behaves_like 'deleting the todo'
        it_behaves_like 'deleting and restoring the todo'
      end
    end

    context 'User has done todos', js: true do
      before do
        create(:todo, :mentioned, :done, user: user, project: project, target: issue, author: author)
        login_as(user)
        visit dashboard_todos_path(state: :done)
      end

      it 'has the done todo present' do
        expect(page).to have_selector('.todos-list .todo.todo-done', count: 1)
      end

      describe 'restoring the todo' do
        before do
          within first('.todo') do
            click_link 'Add todo'
          end
        end

        it 'is removed from the list' do
          expect(page).not_to have_selector('.todos-list .todo.todo-done')
        end

        it 'updates todo count' do
          expect(page).to have_content 'To do 1'
          expect(page).to have_content 'Done 0'
        end
      end
    end

    context 'User has Todos with labels spanning multiple projects' do
      before do
        label1 = create(:label, project: project)
        note1 = create(:note_on_issue, note: "Hello #{label1.to_reference(format: :name)}", noteable_id: issue.id, noteable_type: 'Issue', project: issue.project)
        create(:todo, :mentioned, project: project, target: issue, user: user, note_id: note1.id)

        project2 = create(:project, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
        label2 = create(:label, project: project2)
        issue2 = create(:issue, project: project2)
        note2 = create(:note_on_issue, note: "Test #{label2.to_reference(format: :name)}", noteable_id: issue2.id, noteable_type: 'Issue', project: project2)
        create(:todo, :mentioned, project: project2, target: issue2, user: user, note_id: note2.id)

        login_as(user)
        visit dashboard_todos_path
      end

      it 'shows page with two Todos' do
        expect(page).to have_selector('.todos-list .todo', count: 2)
      end
    end

    context 'User has multiple pages of Todos' do
      before do
        allow(Todo).to receive(:default_per_page).and_return(1)

        # Create just enough records to cause us to paginate
        create_list(:todo, 2, :mentioned, user: user, project: project, target: issue, author: author)

        login_as(user)
      end

      it 'is paginated' do
        visit dashboard_todos_path

        expect(page).to have_selector('.gl-pagination')
      end

      it 'is has the right number of pages' do
        visit dashboard_todos_path

        expect(page).to have_selector('.gl-pagination .page', count: 2)
      end

      describe 'mark all as done', js: true do
        before do
          visit dashboard_todos_path
          click_link 'Mark all as done'
        end

        it 'shows "All done" message!' do
          expect(page).to have_content 'To do 0'
          expect(page).to have_content "You're all done!"
          expect(page).not_to have_selector('.gl-pagination')
        end

        it 'shows "Undo mark all as done" button' do
          expect(page).to have_selector('.js-todos-mark-all', visible: false)
          expect(page).to have_selector('.js-todos-undo-all', visible: true)
        end
      end

      describe 'undo mark all as done', js: true do
        before do
          visit dashboard_todos_path
        end

        it 'shows the restored todo list' do
          mark_all_and_undo

          expect(page).to have_selector('.todos-list .todo', count: 1)
          expect(page).to have_selector('.gl-pagination')
          expect(page).not_to have_content "You're all done!"
        end

        it 'updates todo count' do
          mark_all_and_undo

          expect(page).to have_content 'To do 2'
          expect(page).to have_content 'Done 0'
        end

        it 'shows "Mark all as done" button' do
          mark_all_and_undo

          expect(page).to have_selector('.js-todos-mark-all', visible: true)
          expect(page).to have_selector('.js-todos-undo-all', visible: false)
        end

        context 'User has deleted a todo' do
          before do
            within first('.todo') do
              click_link 'Done'
            end
          end

          it 'shows the restored todo list with the deleted todo' do
            mark_all_and_undo

            expect(page).to have_selector('.todos-list .todo.todo-pending', count: 1)
          end
        end

        def mark_all_and_undo
          click_link 'Mark all as done'
          wait_for_ajax
          click_link 'Undo mark all as done'
          wait_for_ajax
        end
      end
    end

    context 'User has a Todo in a project pending deletion' do
      before do
        deleted_project = create(:project, visibility_level: Gitlab::VisibilityLevel::PUBLIC, pending_delete: true)
        create(:todo, :mentioned, user: user, project: deleted_project, target: issue, author: author)
        create(:todo, :mentioned, user: user, project: deleted_project, target: issue, author: author, state: :done)
        login_as(user)
        visit dashboard_todos_path
      end

      it 'shows "All done" message' do
        within('.todos-pending-count') { expect(page).to have_content '0' }
        expect(page).to have_content 'To do 0'
        expect(page).to have_content 'Done 0'
        expect(page).to have_selector('.todos-all-done', count: 1)
      end
    end

    context 'User have large number of todos' do
      before do
        create_list(:todo, 101, :mentioned, user: user, project: project, target: issue, author: author)

        login_as(user)
        visit dashboard_todos_path
      end

      it 'shows 99+ for count >= 100 in notification' do
        expect(page).to have_selector('.todos-pending-count', text: '99+')
      end

      it 'shows exact number in To do tab' do
        expect(page).to have_selector('.todos-pending .badge', text: '101')
      end

      it 'shows exact number for count < 100' do
        3.times { first('.js-done-todo').click }

        expect(page).to have_selector('.todos-pending-count', text: '98')
      end
    end

    context 'User has a Build Failed todo' do
      let!(:todo) { create(:todo, :build_failed, user: user, project: project, author: author) }

      before do
        login_as user
        visit dashboard_todos_path
      end

      it 'shows the todo' do
        expect(page).to have_content 'The build failed for merge request'
      end

      it 'links to the pipelines for the merge request' do
        href = pipelines_namespace_project_merge_request_path(project.namespace, project, todo.target)

        expect(page).to have_link "merge request #{todo.target.to_reference(full: true)}", href
      end
    end
  end
end