summaryrefslogtreecommitdiff
path: root/spec/features/triggers_spec.rb
blob: 783f330221cac5fad3c35f96a018c89f295dc936 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
require 'spec_helper'

feature 'Triggers', feature: true, js: true do
  let(:trigger_title) { 'trigger desc' }
  let(:user) { create(:user) }
  let(:user2) { create(:user) }
  let(:guest_user) { create(:user) }
  before { login_as(user) }

  before do
    @project = create(:empty_project)
    @project.team << [user, :master]
    @project.team << [user2, :master]
    @project.team << [guest_user, :guest]
    visit namespace_project_settings_ci_cd_path(@project.namespace, @project)
  end

  describe 'create trigger workflow' do
    scenario 'prevents adding new trigger with no description' do
      fill_in 'trigger_description', with: ''
      click_button 'Add trigger'

      # See if input has error due to empty value
      expect(page.find('form.gl-show-field-errors .gl-field-error')['style']).to eq 'display: block;'
    end

    scenario 'adds new trigger with description' do
      fill_in 'trigger_description', with: 'trigger desc'
      click_button 'Add trigger'

      # See if "trigger creation successful" message displayed and description and owner are correct
      expect(page.find('.flash-notice')).to have_content 'Trigger was created successfully.'
      expect(page.find('.triggers-list')).to have_content 'trigger desc'
      expect(page.find('.triggers-list .trigger-owner')).to have_content @user.name
    end
  end

  describe 'edit trigger workflow' do
    let(:new_trigger_title) { 'new trigger' }

    scenario 'click on edit trigger opens edit trigger page' do
      create(:ci_trigger, owner: user, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if edit page has correct descrption
      find('a[title="Edit"]').click
      expect(page.find('#trigger_description').value).to have_content 'trigger desc'
    end

    scenario 'edit trigger and save' do
      create(:ci_trigger, owner: user, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if edit page opens, then fill in new description and save
      find('a[title="Edit"]').click
      fill_in 'trigger_description', with: new_trigger_title
      click_button 'Save trigger'

      # See if "trigger updated successfully" message displayed and description and owner are correct
      expect(page.find('.flash-notice')).to have_content 'Trigger was successfully updated.'
      expect(page.find('.triggers-list')).to have_content new_trigger_title
      expect(page.find('.triggers-list .trigger-owner')).to have_content @user.name
    end

    scenario 'edit "legacy" trigger and save' do
      # Create new trigger without owner association, i.e. Legacy trigger
      create(:ci_trigger, owner: nil, project: @project)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if the trigger can be edited and description is blank
      find('a[title="Edit"]').click
      expect(page.find('#trigger_description').value).to have_content ''

      # See if trigger can be updated with description and saved successfully
      fill_in 'trigger_description', with: new_trigger_title
      click_button 'Save trigger'
      expect(page.find('.flash-notice')).to have_content 'Trigger was successfully updated.'
      expect(page.find('.triggers-list')).to have_content new_trigger_title
    end

    context 'scheduled triggers' do
      let!(:trigger) do
        create(:ci_trigger, owner: user, project: @project, description: trigger_title)
      end

      context 'enabling schedule' do
        before do
          visit edit_namespace_project_trigger_path(@project.namespace, @project, trigger)
        end

        scenario 'do fill form with valid data and save' do
          find('#trigger_trigger_schedule_attributes_active').click
          fill_in 'trigger_trigger_schedule_attributes_cron', with: '1 * * * *'
          fill_in 'trigger_trigger_schedule_attributes_cron_timezone', with: 'UTC'
          fill_in 'trigger_trigger_schedule_attributes_ref', with: 'master'
          click_button 'Save trigger'

          expect(page.find('.flash-notice')).to have_content 'Trigger was successfully updated.'
        end

        scenario 'do not fill form with valid data and save' do
          find('#trigger_trigger_schedule_attributes_active').click
          click_button 'Save trigger'

          expect(page).to have_content 'The form contains the following errors'
        end

        context 'when GitLab time_zone is ActiveSupport::TimeZone format' do
          before do
            allow(Time).to receive(:zone)
              .and_return(ActiveSupport::TimeZone['Eastern Time (US & Canada)'])
          end

          scenario 'do fill form with valid data and save' do
            find('#trigger_trigger_schedule_attributes_active').click
            fill_in 'trigger_trigger_schedule_attributes_cron', with: '1 * * * *'
            fill_in 'trigger_trigger_schedule_attributes_cron_timezone', with: 'UTC'
            fill_in 'trigger_trigger_schedule_attributes_ref', with: 'master'
            click_button 'Save trigger'

            expect(page.find('.flash-notice'))
              .to have_content 'Trigger was successfully updated.'
          end
        end
      end

      context 'disabling schedule' do
        before do
          trigger.create_trigger_schedule(
            project: trigger.project,
            active: true,
            ref: 'master',
            cron: '1 * * * *',
            cron_timezone: 'UTC')

          visit edit_namespace_project_trigger_path(@project.namespace, @project, trigger)
        end

        scenario 'disable and save form' do
          find('#trigger_trigger_schedule_attributes_active').click
          click_button 'Save trigger'
          expect(page.find('.flash-notice')).to have_content 'Trigger was successfully updated.'

          visit edit_namespace_project_trigger_path(@project.namespace, @project, trigger)
          checkbox = find_field('trigger_trigger_schedule_attributes_active')

          expect(checkbox).not_to be_checked
        end
      end
    end
  end

  describe 'trigger "Take ownership" workflow' do
    before(:each) do
      create(:ci_trigger, owner: user2, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)
    end

    scenario 'button "Take ownership" has correct alert' do
      expected_alert = 'By taking ownership you will bind this trigger to your user account. With this the trigger will have access to all your projects as if it was you. Are you sure?'
      expect(page.find('a.btn-trigger-take-ownership')['data-confirm']).to eq expected_alert
    end

    scenario 'take trigger ownership' do
      # See if "Take ownership" on trigger works post trigger creation
      find('a.btn-trigger-take-ownership').click
      page.accept_confirm do
        expect(page.find('.flash-notice')).to have_content 'Trigger was re-assigned.'
        expect(page.find('.triggers-list')).to have_content trigger_title
        expect(page.find('.triggers-list .trigger-owner')).to have_content @user.name
      end
    end
  end

  describe 'trigger "Revoke" workflow' do
    before(:each) do
      create(:ci_trigger, owner: user2, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)
    end

    scenario 'button "Revoke" has correct alert' do
      expected_alert = 'By revoking a trigger you will break any processes making use of it. Are you sure?'
      expect(page.find('a.btn-trigger-revoke')['data-confirm']).to eq expected_alert
    end

    scenario 'revoke trigger' do
      # See if "Revoke" on trigger works post trigger creation
      find('a.btn-trigger-revoke').click
      page.accept_confirm do
        expect(page.find('.flash-notice')).to have_content 'Trigger removed'
        expect(page).to have_selector('p.settings-message.text-center.append-bottom-default')
      end
    end
  end

  describe 'show triggers workflow' do
    scenario 'contains trigger description placeholder' do
      expect(page.find('#trigger_description')['placeholder']).to eq 'Trigger description'
    end

    scenario 'show "legacy" badge for legacy trigger' do
      create(:ci_trigger, owner: nil, project: @project)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if trigger without owner (i.e. legacy) shows "legacy" badge and is editable
      expect(page.find('.triggers-list')).to have_content 'legacy'
      expect(page.find('.triggers-list')).to have_selector('a[title="Edit"]')
    end

    scenario 'show "invalid" badge for trigger with owner having insufficient permissions' do
      create(:ci_trigger, owner: guest_user, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if trigger without owner (i.e. legacy) shows "legacy" badge and is non-editable
      expect(page.find('.triggers-list')).to have_content 'invalid'
      expect(page.find('.triggers-list')).not_to have_selector('a[title="Edit"]')
    end

    scenario 'do not show "Edit" or full token for not owned trigger' do
      # Create trigger with user different from current_user
      create(:ci_trigger, owner: user2, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if trigger not owned by current_user shows only first few token chars and doesn't have copy-to-clipboard button
      expect(page.find('.triggers-list')).to have_content(@project.triggers.first.token[0..3])
      expect(page.find('.triggers-list')).not_to have_selector('button.btn-clipboard')

      # See if trigger owner name doesn't match with current_user and trigger is non-editable
      expect(page.find('.triggers-list .trigger-owner')).not_to have_content @user.name
      expect(page.find('.triggers-list')).not_to have_selector('a[title="Edit"]')
    end

    scenario 'show "Edit" and full token for owned trigger' do
      create(:ci_trigger, owner: user, project: @project, description: trigger_title)
      visit namespace_project_settings_ci_cd_path(@project.namespace, @project)

      # See if trigger shows full token and has copy-to-clipboard button
      expect(page.find('.triggers-list')).to have_content @project.triggers.first.token
      expect(page.find('.triggers-list')).to have_selector('button.btn-clipboard')

      # See if trigger owner name matches with current_user and is editable
      expect(page.find('.triggers-list .trigger-owner')).to have_content @user.name
      expect(page.find('.triggers-list')).to have_selector('a[title="Edit"]')
    end
  end
end