summaryrefslogtreecommitdiff
path: root/spec/features/users/signup_spec.rb
blob: 66a2649333922073ab1a378d4f9baaf656442c9b (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
# frozen_string_literal: true

require 'spec_helper'

RSpec.shared_examples 'Signup' do
  include TermsHelper

  let(:new_user) { build_stubbed(:user) }

  describe 'username validation', :js do
    before do
      visit new_user_registration_path
    end

    it 'does not show an error border if the username is available' do
      fill_in 'new_user_username', with: 'new-user'
      wait_for_requests

      expect(find('.username')).not_to have_css '.gl-field-error-outline'
    end

    it 'does not show an error border if the username contains dots (.)' do
      simulate_input('#new_user_username', 'new.user.username')
      wait_for_requests

      expect(find('.username')).not_to have_css '.gl-field-error-outline'
    end

    it 'does not show an error border if the username length is not longer than 255 characters' do
      fill_in 'new_user_username', with: 'u' * 255
      wait_for_requests

      expect(find('.username')).not_to have_css '.gl-field-error-outline'
    end

    it 'shows an error border if the username already exists' do
      existing_user = create(:user)

      fill_in 'new_user_username', with: existing_user.username
      wait_for_requests

      expect(find('.username')).to have_css '.gl-field-error-outline'
    end

    it 'shows a success border if the username is available' do
      fill_in 'new_user_username', with: 'new-user'
      wait_for_requests

      expect(find('.username')).to have_css '.gl-field-success-outline'
    end

    it 'shows an error border if the username contains special characters' do
      fill_in 'new_user_username', with: 'new$user!username'
      wait_for_requests

      expect(find('.username')).to have_css '.gl-field-error-outline'
    end

    it 'shows an error border if the username is longer than 255 characters' do
      fill_in 'new_user_username', with: 'u' * 256
      wait_for_requests

      expect(find('.username')).to have_css '.gl-field-error-outline'
    end

    it 'shows an error message if the username is longer than 255 characters' do
      fill_in 'new_user_username', with: 'u' * 256
      wait_for_requests

      expect(page).to have_content("Username is too long (maximum is 255 characters).")
    end

    it 'shows an error message on submit if the username contains special characters' do
      fill_in 'new_user_username', with: 'new$user!username'
      wait_for_requests

      click_button "Register"

      expect(page).to have_content("Please create a username with only alphanumeric characters.")
    end

    it 'shows an error border if the username contains emojis' do
      simulate_input('#new_user_username', 'ehsan😀')

      expect(find('.username')).to have_css '.gl-field-error-outline'
    end

    it 'shows an error message if the username contains emojis' do
      simulate_input('#new_user_username', 'ehsan😀')

      expect(page).to have_content("Invalid input, please avoid emojis")
    end

    it 'shows a pending message if the username availability is being fetched', :quarantine do
      fill_in 'new_user_username', with: 'new-user'

      expect(find('.username > .validation-pending')).not_to have_css '.hide'
    end

    it 'shows a success message if the username is available' do
      fill_in 'new_user_username', with: 'new-user'
      wait_for_requests

      expect(find('.username > .validation-success')).not_to have_css '.hide'
    end

    it 'shows an error message if the username is unavailable' do
      existing_user = create(:user)

      fill_in 'new_user_username', with: existing_user.username
      wait_for_requests

      expect(find('.username > .validation-error')).not_to have_css '.hide'
    end

    it 'shows a success message if the username is corrected and then available' do
      fill_in 'new_user_username', with: 'new-user$'
      wait_for_requests
      fill_in 'new_user_username', with: 'new-user'
      wait_for_requests

      expect(page).to have_content("Username is available.")
    end
  end

  context 'with no errors' do
    context 'when sending confirmation email' do
      before do
        stub_application_setting(send_user_confirmation_email: true)
      end

      context 'when soft email confirmation is not enabled' do
        before do
          stub_feature_flags(soft_email_confirmation: false)
        end

        it 'creates the user account and sends a confirmation email' do
          visit new_user_registration_path

          fill_in 'new_user_username', with: new_user.username
          fill_in 'new_user_email', with: new_user.email

          if Gitlab::Experimentation.enabled?(:signup_flow)
            fill_in 'new_user_first_name', with: new_user.first_name
            fill_in 'new_user_last_name', with: new_user.last_name
          else
            fill_in 'new_user_name', with: new_user.name
            fill_in 'new_user_email_confirmation', with: new_user.email
          end

          fill_in 'new_user_password', with: new_user.password

          expect { click_button 'Register' }.to change { User.count }.by(1)

          expect(current_path).to eq users_almost_there_path
          expect(page).to have_content('Please check your email to confirm your account')
        end
      end

      context 'when soft email confirmation is enabled' do
        before do
          stub_feature_flags(soft_email_confirmation: true)
        end

        it 'creates the user account and sends a confirmation email' do
          visit new_user_registration_path

          fill_in 'new_user_username', with: new_user.username
          fill_in 'new_user_email', with: new_user.email

          if Gitlab::Experimentation.enabled?(:signup_flow)
            fill_in 'new_user_first_name', with: new_user.first_name
            fill_in 'new_user_last_name', with: new_user.last_name
          else
            fill_in 'new_user_name', with: new_user.name
            fill_in 'new_user_email_confirmation', with: new_user.email
          end

          fill_in 'new_user_password', with: new_user.password

          expect { click_button 'Register' }.to change { User.count }.by(1)

          if Gitlab::Experimentation.enabled?(:signup_flow)
            expect(current_path).to eq users_sign_up_welcome_path
          else
            expect(current_path).to eq dashboard_projects_path
            expect(page).to have_content("Please check your email (#{new_user.email}) to verify that you own this address and unlock the power of CI/CD.")
          end
        end
      end
    end

    context "when sigining up with different cased emails" do
      it "creates the user successfully" do
        visit new_user_registration_path

        fill_in 'new_user_username', with: new_user.username
        fill_in 'new_user_email', with: new_user.email

        if Gitlab::Experimentation.enabled?(:signup_flow)
          fill_in 'new_user_first_name', with: new_user.first_name
          fill_in 'new_user_last_name', with: new_user.last_name
        else
          fill_in 'new_user_name', with: new_user.name
          fill_in 'new_user_email_confirmation', with: new_user.email.capitalize
        end

        fill_in 'new_user_password', with: new_user.password
        click_button "Register"

        if Gitlab::Experimentation.enabled?(:signup_flow)
          expect(current_path).to eq users_sign_up_welcome_path
        else
          expect(current_path).to eq dashboard_projects_path
          expect(page).to have_content("Welcome! You have signed up successfully.")
        end
      end
    end

    context "when not sending confirmation email" do
      before do
        stub_application_setting(send_user_confirmation_email: false)
      end

      it 'creates the user account and goes to dashboard' do
        visit new_user_registration_path

        fill_in 'new_user_username', with: new_user.username
        fill_in 'new_user_email', with: new_user.email

        if Gitlab::Experimentation.enabled?(:signup_flow)
          fill_in 'new_user_first_name', with: new_user.first_name
          fill_in 'new_user_last_name', with: new_user.last_name
        else
          fill_in 'new_user_name', with: new_user.name
          fill_in 'new_user_email_confirmation', with: new_user.email
        end

        fill_in 'new_user_password', with: new_user.password
        click_button "Register"

        if Gitlab::Experimentation.enabled?(:signup_flow)
          expect(current_path).to eq users_sign_up_welcome_path
        else
          expect(current_path).to eq dashboard_projects_path
          expect(page).to have_content("Welcome! You have signed up successfully.")
        end
      end
    end
  end

  context 'with errors' do
    it "displays the errors" do
      existing_user = create(:user)

      visit new_user_registration_path

      if Gitlab::Experimentation.enabled?(:signup_flow)
        fill_in 'new_user_first_name', with: new_user.first_name
        fill_in 'new_user_last_name', with: new_user.last_name
      else
        fill_in 'new_user_name', with: new_user.name
      end

      fill_in 'new_user_username', with: new_user.username
      fill_in 'new_user_email', with: existing_user.email
      fill_in 'new_user_password', with: new_user.password
      click_button "Register"

      expect(current_path).to eq user_registration_path

      if Gitlab::Experimentation.enabled?(:signup_flow)
        expect(page).to have_content("error prohibited this user from being saved")
      else
        expect(page).to have_content("errors prohibited this user from being saved")
        expect(page).to have_content("Email confirmation doesn't match")
      end

      expect(page).to have_content("Email has already been taken")
    end

    it 'does not redisplay the password' do
      existing_user = create(:user)

      visit new_user_registration_path

      if Gitlab::Experimentation.enabled?(:signup_flow)
        fill_in 'new_user_first_name', with: new_user.first_name
        fill_in 'new_user_last_name', with: new_user.last_name
      else
        fill_in 'new_user_name', with: new_user.name
      end

      fill_in 'new_user_username', with: new_user.username
      fill_in 'new_user_email', with: existing_user.email
      fill_in 'new_user_password', with: new_user.password
      click_button "Register"

      expect(current_path).to eq user_registration_path
      expect(page.body).not_to match(/#{new_user.password}/)
    end
  end

  context 'when terms are enforced' do
    before do
      enforce_terms
    end

    it 'requires the user to check the checkbox' do
      visit new_user_registration_path

      fill_in 'new_user_username', with: new_user.username
      fill_in 'new_user_email', with: new_user.email

      if Gitlab::Experimentation.enabled?(:signup_flow)
        fill_in 'new_user_first_name', with: new_user.first_name
        fill_in 'new_user_last_name', with: new_user.last_name
      else
        fill_in 'new_user_name', with: new_user.name
        fill_in 'new_user_email_confirmation', with: new_user.email
      end

      fill_in 'new_user_password', with: new_user.password

      click_button 'Register'

      expect(current_path).to eq new_user_session_path
      expect(page).to have_content(/you must accept our terms of service/i)
    end

    it 'asks the user to accept terms before going to the dashboard' do
      visit new_user_registration_path

      fill_in 'new_user_username', with: new_user.username
      fill_in 'new_user_email', with: new_user.email

      if Gitlab::Experimentation.enabled?(:signup_flow)
        fill_in 'new_user_first_name', with: new_user.first_name
        fill_in 'new_user_last_name', with: new_user.last_name
      else
        fill_in 'new_user_name', with: new_user.name
        fill_in 'new_user_email_confirmation', with: new_user.email
      end

      fill_in 'new_user_password', with: new_user.password
      check :terms_opt_in

      click_button "Register"

      if Gitlab::Experimentation.enabled?(:signup_flow)
        expect(current_path).to eq users_sign_up_welcome_path
      else
        expect(current_path).to eq dashboard_projects_path
      end
    end
  end

  context 'when reCAPTCHA and invisible captcha are enabled' do
    before do
      InvisibleCaptcha.timestamp_enabled = true
      stub_application_setting(recaptcha_enabled: true)
      allow_next_instance_of(RegistrationsController) do |instance|
        allow(instance).to receive(:verify_recaptcha).and_return(true)
      end
    end

    after do
      InvisibleCaptcha.timestamp_enabled = false
    end

    context 'when reCAPTCHA detects malicious behaviour' do
      before do
        allow_next_instance_of(RegistrationsController) do |instance|
          allow(instance).to receive(:verify_recaptcha).and_return(false)
        end
      end

      it 'prevents from signing up' do
        visit new_user_registration_path

        fill_in 'new_user_username', with: new_user.username
        fill_in 'new_user_email', with: new_user.email

        if Gitlab::Experimentation.enabled?(:signup_flow)
          fill_in 'new_user_first_name', with: new_user.first_name
          fill_in 'new_user_last_name', with: new_user.last_name
        else
          fill_in 'new_user_name', with: new_user.name
          fill_in 'new_user_email_confirmation', with: new_user.email
        end

        fill_in 'new_user_password', with: new_user.password

        expect { click_button 'Register' }.not_to change { User.count }
        expect(page).to have_content('There was an error with the reCAPTCHA. Please solve the reCAPTCHA again.')
      end
    end

    context 'when invisible captcha detects malicious behaviour' do
      it 'prevents from signing up' do
        visit new_user_registration_path

        fill_in 'new_user_username', with: new_user.username
        fill_in 'new_user_email', with: new_user.email

        if Gitlab::Experimentation.enabled?(:signup_flow)
          fill_in 'new_user_first_name', with: new_user.first_name
          fill_in 'new_user_last_name', with: new_user.last_name
        else
          fill_in 'new_user_name', with: new_user.name
          fill_in 'new_user_email_confirmation', with: new_user.email
        end

        fill_in 'new_user_password', with: new_user.password

        expect { click_button 'Register' }.not_to change { User.count }
        expect(page).to have_content('That was a bit too quick! Please resubmit.')
      end
    end
  end
end

RSpec.shared_examples 'Signup name validation' do |field, max_length|
  before do
    visit new_user_registration_path
  end

  describe "#{field} validation", :js do
    it "does not show an error border if the user's fullname length is not longer than #{max_length} characters" do
      fill_in field, with: 'u' * max_length

      expect(find('.name')).not_to have_css '.gl-field-error-outline'
    end

    it 'shows an error border if the user\'s fullname contains an emoji' do
      simulate_input("##{field}", 'Ehsan 🦋')

      expect(find('.name')).to have_css '.gl-field-error-outline'
    end

    it "shows an error border if the user\'s fullname is longer than #{max_length} characters" do
      fill_in field, with: 'n' * (max_length + 1)

      expect(find('.name')).to have_css '.gl-field-error-outline'
    end

    it "shows an error message if the user\'s fullname is longer than #{max_length} characters" do
      fill_in field, with: 'n' * (max_length + 1)

      expect(page).to have_content("Name is too long (maximum is #{max_length} characters).")
    end

    it 'shows an error message if the username contains emojis' do
      simulate_input("##{field}", 'Ehsan 🦋')

      expect(page).to have_content("Invalid input, please avoid emojis")
    end
  end
end

RSpec.describe 'With original flow' do
  before do
    stub_experiment(signup_flow: false)
    stub_experiment_for_user(signup_flow: false)
  end

  it_behaves_like 'Signup'
  it_behaves_like 'Signup name validation', 'new_user_name', 255
end

RSpec.describe 'With experimental flow' do
  before do
    stub_experiment(signup_flow: true)
    stub_experiment_for_user(signup_flow: true)
  end

  it_behaves_like 'Signup'
  it_behaves_like 'Signup name validation', 'new_user_first_name', 127
  it_behaves_like 'Signup name validation', 'new_user_last_name', 127

  describe 'when role is required' do
    it 'after registering, it redirects to step 2 of the signup process, sets the name and role and then redirects to the original requested url' do
      new_user = build_stubbed(:user)
      visit new_user_registration_path
      fill_in 'new_user_first_name', with: new_user.first_name
      fill_in 'new_user_last_name', with: new_user.last_name
      fill_in 'new_user_username', with: new_user.username
      fill_in 'new_user_email', with: new_user.email
      fill_in 'new_user_password', with: new_user.password
      click_button 'Register'
      visit new_project_path

      expect(page).to have_current_path(users_sign_up_welcome_path)

      select 'Software Developer', from: 'user_role'
      choose 'user_setup_for_company_true'
      click_button 'Get started!'
      new_user = User.find_by_username(new_user.username)

      expect(new_user.software_developer_role?).to be_truthy
      expect(new_user.setup_for_company).to be_truthy
      expect(page).to have_current_path(new_project_path)
    end
  end
end