summaryrefslogtreecommitdiff
path: root/spec/frontend/releases/stores/modules/detail/actions_spec.js
blob: 345be2acc71f9ab4c757dbb55639447e0b066312 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
import axios from 'axios';
import MockAdapter from 'axios-mock-adapter';
import testAction from 'helpers/vuex_action_helper';
import { cloneDeep, merge } from 'lodash';
import * as actions from '~/releases/stores/modules/detail/actions';
import * as types from '~/releases/stores/modules/detail/mutation_types';
import { release as originalRelease } from '../../../mock_data';
import createState from '~/releases/stores/modules/detail/state';
import createFlash from '~/flash';
import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils';
import { redirectTo } from '~/lib/utils/url_utility';
import api from '~/api';
import { ASSET_LINK_TYPE } from '~/releases/constants';

jest.mock('~/flash', () => jest.fn());

jest.mock('~/lib/utils/url_utility', () => ({
  redirectTo: jest.fn(),
  joinPaths: jest.requireActual('~/lib/utils/url_utility').joinPaths,
}));

describe('Release detail actions', () => {
  let state;
  let release;
  let mock;
  let error;

  beforeEach(() => {
    state = createState({
      projectId: '18',
      tagName: 'v1.3',
      releasesPagePath: 'path/to/releases/page',
      markdownDocsPath: 'path/to/markdown/docs',
      markdownPreviewPath: 'path/to/markdown/preview',
      updateReleaseApiDocsPath: 'path/to/api/docs',
    });
    release = cloneDeep(originalRelease);
    mock = new MockAdapter(axios);
    gon.api_version = 'v4';
    error = { message: 'An error occurred' };
    createFlash.mockClear();
  });

  afterEach(() => {
    mock.restore();
  });

  describe('requestRelease', () => {
    it(`commits ${types.REQUEST_RELEASE}`, () =>
      testAction(actions.requestRelease, undefined, state, [{ type: types.REQUEST_RELEASE }]));
  });

  describe('receiveReleaseSuccess', () => {
    it(`commits ${types.RECEIVE_RELEASE_SUCCESS}`, () =>
      testAction(actions.receiveReleaseSuccess, release, state, [
        { type: types.RECEIVE_RELEASE_SUCCESS, payload: release },
      ]));
  });

  describe('receiveReleaseError', () => {
    it(`commits ${types.RECEIVE_RELEASE_ERROR}`, () =>
      testAction(actions.receiveReleaseError, error, state, [
        { type: types.RECEIVE_RELEASE_ERROR, payload: error },
      ]));

    it('shows a flash with an error message', () => {
      actions.receiveReleaseError({ commit: jest.fn() }, error);

      expect(createFlash).toHaveBeenCalledTimes(1);
      expect(createFlash).toHaveBeenCalledWith(
        'Something went wrong while getting the release details',
      );
    });
  });

  describe('fetchRelease', () => {
    let getReleaseUrl;

    beforeEach(() => {
      state.projectId = '18';
      state.tagName = 'v1.3';
      getReleaseUrl = `/api/v4/projects/${state.projectId}/releases/${state.tagName}`;
    });

    it(`dispatches requestRelease and receiveReleaseSuccess with the camel-case'd release object`, () => {
      mock.onGet(getReleaseUrl).replyOnce(200, release);

      return testAction(
        actions.fetchRelease,
        undefined,
        state,
        [],
        [
          { type: 'requestRelease' },
          {
            type: 'receiveReleaseSuccess',
            payload: convertObjectPropsToCamelCase(release, { deep: true }),
          },
        ],
      );
    });

    it(`dispatches requestRelease and receiveReleaseError with an error object`, () => {
      mock.onGet(getReleaseUrl).replyOnce(500);

      return testAction(
        actions.fetchRelease,
        undefined,
        state,
        [],
        [{ type: 'requestRelease' }, { type: 'receiveReleaseError', payload: expect.anything() }],
      );
    });
  });

  describe('updateReleaseTitle', () => {
    it(`commits ${types.UPDATE_RELEASE_TITLE} with the updated release title`, () => {
      const newTitle = 'The new release title';
      return testAction(actions.updateReleaseTitle, newTitle, state, [
        { type: types.UPDATE_RELEASE_TITLE, payload: newTitle },
      ]);
    });
  });

  describe('updateReleaseNotes', () => {
    it(`commits ${types.UPDATE_RELEASE_NOTES} with the updated release notes`, () => {
      const newReleaseNotes = 'The new release notes';
      return testAction(actions.updateReleaseNotes, newReleaseNotes, state, [
        { type: types.UPDATE_RELEASE_NOTES, payload: newReleaseNotes },
      ]);
    });
  });

  describe('updateAssetLinkUrl', () => {
    it(`commits ${types.UPDATE_ASSET_LINK_URL} with the updated link URL`, () => {
      const params = {
        linkIdToUpdate: 2,
        newUrl: 'https://example.com/updated',
      };

      return testAction(actions.updateAssetLinkUrl, params, state, [
        { type: types.UPDATE_ASSET_LINK_URL, payload: params },
      ]);
    });
  });

  describe('updateAssetLinkName', () => {
    it(`commits ${types.UPDATE_ASSET_LINK_NAME} with the updated link name`, () => {
      const params = {
        linkIdToUpdate: 2,
        newName: 'Updated link name',
      };

      return testAction(actions.updateAssetLinkName, params, state, [
        { type: types.UPDATE_ASSET_LINK_NAME, payload: params },
      ]);
    });
  });

  describe('updateAssetLinkType', () => {
    it(`commits ${types.UPDATE_ASSET_LINK_TYPE} with the updated link type`, () => {
      const params = {
        linkIdToUpdate: 2,
        newType: ASSET_LINK_TYPE.RUNBOOK,
      };

      return testAction(actions.updateAssetLinkType, params, state, [
        { type: types.UPDATE_ASSET_LINK_TYPE, payload: params },
      ]);
    });
  });

  describe('removeAssetLink', () => {
    it(`commits ${types.REMOVE_ASSET_LINK} with the ID of the asset link to remove`, () => {
      const idToRemove = 2;
      return testAction(actions.removeAssetLink, idToRemove, state, [
        { type: types.REMOVE_ASSET_LINK, payload: idToRemove },
      ]);
    });
  });

  describe('updateReleaseMilestones', () => {
    it(`commits ${types.UPDATE_RELEASE_MILESTONES} with the updated release milestones`, () => {
      const newReleaseMilestones = ['v0.0', 'v0.1'];
      return testAction(actions.updateReleaseMilestones, newReleaseMilestones, state, [
        { type: types.UPDATE_RELEASE_MILESTONES, payload: newReleaseMilestones },
      ]);
    });
  });

  describe('requestUpdateRelease', () => {
    it(`commits ${types.REQUEST_UPDATE_RELEASE}`, () =>
      testAction(actions.requestUpdateRelease, undefined, state, [
        { type: types.REQUEST_UPDATE_RELEASE },
      ]));
  });

  describe('receiveUpdateReleaseSuccess', () => {
    it(`commits ${types.RECEIVE_UPDATE_RELEASE_SUCCESS}`, () =>
      testAction(actions.receiveUpdateReleaseSuccess, undefined, { ...state, featureFlags: {} }, [
        { type: types.RECEIVE_UPDATE_RELEASE_SUCCESS },
      ]));

    it('redirects to the releases page if releaseShowPage feature flag is enabled', () => {
      const rootState = { featureFlags: { releaseShowPage: true } };
      const updatedState = merge({}, state, {
        releasesPagePath: 'path/to/releases/page',
        release: {
          _links: {
            self: 'path/to/self',
          },
        },
      });

      actions.receiveUpdateReleaseSuccess({ commit: jest.fn(), state: updatedState, rootState });

      expect(redirectTo).toHaveBeenCalledTimes(1);
      expect(redirectTo).toHaveBeenCalledWith(updatedState.release._links.self);
    });

    describe('when the releaseShowPage feature flag is disabled', () => {});
  });

  describe('receiveUpdateReleaseError', () => {
    it(`commits ${types.RECEIVE_UPDATE_RELEASE_ERROR}`, () =>
      testAction(actions.receiveUpdateReleaseError, error, state, [
        { type: types.RECEIVE_UPDATE_RELEASE_ERROR, payload: error },
      ]));

    it('shows a flash with an error message', () => {
      actions.receiveUpdateReleaseError({ commit: jest.fn() }, error);

      expect(createFlash).toHaveBeenCalledTimes(1);
      expect(createFlash).toHaveBeenCalledWith(
        'Something went wrong while saving the release details',
      );
    });
  });

  describe('updateRelease', () => {
    let getters;
    let dispatch;
    let callOrder;

    beforeEach(() => {
      state.release = convertObjectPropsToCamelCase(release);
      state.projectId = '18';
      state.tagName = state.release.tagName;

      getters = {
        releaseLinksToDelete: [{ id: '1' }, { id: '2' }],
        releaseLinksToCreate: [{ id: 'new-link-1' }, { id: 'new-link-2' }],
      };

      dispatch = jest.fn();

      callOrder = [];
      jest.spyOn(api, 'updateRelease').mockImplementation(() => {
        callOrder.push('updateRelease');
        return Promise.resolve();
      });
      jest.spyOn(api, 'deleteReleaseLink').mockImplementation(() => {
        callOrder.push('deleteReleaseLink');
        return Promise.resolve();
      });
      jest.spyOn(api, 'createReleaseLink').mockImplementation(() => {
        callOrder.push('createReleaseLink');
        return Promise.resolve();
      });
    });

    it('dispatches requestUpdateRelease and receiveUpdateReleaseSuccess', () => {
      return actions.updateRelease({ dispatch, state, getters }).then(() => {
        expect(dispatch.mock.calls).toEqual([
          ['requestUpdateRelease'],
          ['receiveUpdateReleaseSuccess'],
        ]);
      });
    });

    it('dispatches requestUpdateRelease and receiveUpdateReleaseError with an error object', () => {
      jest.spyOn(api, 'updateRelease').mockRejectedValue(error);

      return actions.updateRelease({ dispatch, state, getters }).then(() => {
        expect(dispatch.mock.calls).toEqual([
          ['requestUpdateRelease'],
          ['receiveUpdateReleaseError', error],
        ]);
      });
    });

    it('updates the Release, then deletes all existing links, and then recreates new links', () => {
      return actions.updateRelease({ dispatch, state, getters }).then(() => {
        expect(callOrder).toEqual([
          'updateRelease',
          'deleteReleaseLink',
          'deleteReleaseLink',
          'createReleaseLink',
          'createReleaseLink',
        ]);

        expect(api.updateRelease.mock.calls).toEqual([
          [
            state.projectId,
            state.tagName,
            {
              name: state.release.name,
              description: state.release.description,
              milestones: state.release.milestones.map(milestone => milestone.title),
            },
          ],
        ]);

        expect(api.deleteReleaseLink).toHaveBeenCalledTimes(getters.releaseLinksToDelete.length);
        getters.releaseLinksToDelete.forEach(link => {
          expect(api.deleteReleaseLink).toHaveBeenCalledWith(
            state.projectId,
            state.tagName,
            link.id,
          );
        });

        expect(api.createReleaseLink).toHaveBeenCalledTimes(getters.releaseLinksToCreate.length);
        getters.releaseLinksToCreate.forEach(link => {
          expect(api.createReleaseLink).toHaveBeenCalledWith(state.projectId, state.tagName, link);
        });
      });
    });
  });
});