1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe GitlabSchema.types['Issue'] do
let_it_be_with_reload(:project) { create(:project, :public) }
let_it_be(:user) { create(:user) }
specify { expect(described_class).to expose_permissions_using(Types::PermissionTypes::Issue) }
specify { expect(described_class.graphql_name).to eq('Issue') }
specify { expect(described_class).to require_graphql_authorizations(:read_issue) }
specify { expect(described_class.interfaces).to include(Types::Notes::NoteableInterface) }
specify { expect(described_class.interfaces).to include(Types::CurrentUserTodos) }
it 'has specific fields' do
fields = %i[id iid title description state reference author assignees updated_by participants labels milestone due_date
confidential hidden discussion_locked upvotes downvotes merge_requests_count user_notes_count user_discussions_count web_path web_url relative_position
emails_disabled subscribed time_estimate total_time_spent human_time_estimate human_total_time_spent closed_at created_at updated_at task_completion_status
design_collection alert_management_alert alert_management_alerts severity current_user_todos moved moved_to
closed_as_duplicate_of create_note_email timelogs project_id customer_relations_contacts escalation_status]
fields.each do |field_name|
expect(described_class).to have_graphql_field(field_name)
end
end
describe 'pagination and count' do
let_it_be(:now) { Time.now.change(usec: 0) }
let_it_be(:issues) { create_list(:issue, 10, project: project, created_at: now) }
let(:count_path) { %w(data project issues count) }
let(:page_size) { 3 }
let(:query) do
<<~GRAPHQL
query project($fullPath: ID!, $first: Int, $after: String) {
project(fullPath: $fullPath) {
issues(first: $first, after: $after) {
count
edges {
node {
iid
}
}
pageInfo {
endCursor
hasNextPage
}
}
}
}
GRAPHQL
end
subject do
GitlabSchema.execute(
query,
context: { current_user: user },
variables: {
fullPath: project.full_path,
first: page_size
}
).to_h
end
context 'when user does not have the permission' do
before do
allow(Ability).to receive(:allowed?).with(user, :read_project, project).and_return(false)
end
it 'does not return an error' do
expect(subject['errors']).to be_nil
end
it 'returns no data' do
expect(subject['data']['project']).to be_nil
end
end
context 'count' do
let(:end_cursor) { %w(data project issues pageInfo endCursor) }
let(:issues_edges) { %w(data project issues edges) }
it 'returns total count' do
expect(subject.dig(*count_path)).to eq(issues.count)
end
it 'total count does not change between pages' do
old_count = subject.dig(*count_path)
new_cursor = subject.dig(*end_cursor)
new_page = GitlabSchema.execute(
query,
context: { current_user: user },
variables: {
fullPath: project.full_path,
first: page_size,
after: new_cursor
}
).to_h
new_count = new_page.dig(*count_path)
expect(old_count).to eq(new_count)
end
context 'pagination' do
let(:page_size) { 9 }
it 'returns new ids during pagination' do
old_edges = subject.dig(*issues_edges)
new_cursor = subject.dig(*end_cursor)
new_edges = GitlabSchema.execute(
query,
context: { current_user: user },
variables: {
fullPath: project.full_path,
first: page_size,
after: new_cursor
}
).to_h.dig(*issues_edges)
expect(old_edges.count).to eq(9)
expect(new_edges.count).to eq(1)
end
end
end
end
describe "issue notes" do
let(:issue) { create(:issue, project: project) }
let(:confidential_issue) { create(:issue, :confidential, project: project) }
let(:private_note_body) { "mentioned in issue #{confidential_issue.to_reference(project)}" }
let!(:note1) { create(:note, system: true, noteable: issue, author: user, project: project, note: private_note_body) }
let!(:note2) { create(:note, system: true, noteable: issue, author: user, project: project, note: 'public note') }
let(:query) do
%(
query {
project(fullPath: "#{project.full_path}") {
issue(iid: "#{issue.iid}") {
descriptionHtml
notes {
edges {
node {
bodyHtml
author {
username
}
body
}
}
}
}
}
}
)
end
context 'query issue notes' do
subject { GitlabSchema.execute(query, context: { current_user: current_user }).as_json }
shared_examples_for 'does not include private notes' do
it "does not return private notes" do
notes = subject.dig("data", "project", "issue", "notes", 'edges')
notes_body = notes.map { |n| n.dig('node', 'body') }
expect(notes.size).to eq 1
expect(notes_body).not_to include(private_note_body)
expect(notes_body).to include('public note')
end
end
shared_examples_for 'includes private notes' do
it "returns all notes" do
notes = subject.dig("data", "project", "issue", "notes", 'edges')
notes_body = notes.map { |n| n.dig('node', 'body') }
expect(notes.size).to eq 2
expect(notes_body).to include(private_note_body)
expect(notes_body).to include('public note')
end
end
context 'when user signed in' do
let(:current_user) { user }
it_behaves_like 'does not include private notes'
context 'when user member of the project' do
before do
project.add_developer(user)
end
it_behaves_like 'includes private notes'
end
end
context 'when user is anonymous' do
let(:current_user) { nil }
it_behaves_like 'does not include private notes'
end
end
end
describe 'hidden', :enable_admin_mode do
let_it_be(:admin) { create(:user, :admin) }
let_it_be(:banned_user) { create(:user, :banned) }
let_it_be(:hidden_issue) { create(:issue, project: project, author: banned_user) }
let_it_be(:visible_issue) { create(:issue, project: project, author: user) }
let(:issue) { hidden_issue }
let(:query) do
%(
query {
project(fullPath: "#{project.full_path}") {
issue(iid: "#{issue.iid}") {
hidden
}
}
}
)
end
subject { GitlabSchema.execute(query, context: { current_user: admin }).as_json }
context 'when issue is hidden' do
it 'returns `true`' do
expect(subject.dig('data', 'project', 'issue', 'hidden')).to eq(true)
end
end
context 'when issue is visible' do
let(:issue) { visible_issue }
it 'returns `false`' do
expect(subject.dig('data', 'project', 'issue', 'hidden')).to eq(false)
end
end
end
describe 'escalation_status' do
let_it_be(:issue, reload: true) { create(:issue, project: project) }
let(:execute) { GitlabSchema.execute(query, context: { current_user: user }).as_json }
let(:query) do
%(
query {
project(fullPath: "#{project.full_path}") {
issue(iid: "#{issue.iid}") {
escalationStatus
}
}
}
)
end
subject(:status) { execute.dig('data', 'project', 'issue', 'escalationStatus') }
it { is_expected.to be_nil }
context 'for an incident' do
before do
issue.update!(issue_type: Issue.issue_types[:incident])
end
it { is_expected.to be_nil }
context 'with an escalation status record' do
let!(:escalation_status) { create(:incident_management_issuable_escalation_status, issue: issue) }
it { is_expected.to eq(escalation_status.status_name.to_s.upcase) }
end
end
end
describe 'type' do
let_it_be(:issue) { create(:issue, project: project) }
let(:query) do
%(
query {
issue(id: "#{issue.to_gid}") {
type
}
}
)
end
subject(:execute) { GitlabSchema.execute(query, context: { current_user: user }).as_json }
context 'when the issue_type_uses_work_item_types_table feature flag is enabled' do
it 'gets the type field from the work_item_types table' do
expect_next_instance_of(::IssuePresenter) do |presented_issue|
expect(presented_issue).to receive_message_chain(:work_item_type, :base_type)
end
execute
end
end
context 'when the issue_type_uses_work_item_types_table feature flag is disabled' do
before do
stub_feature_flags(issue_type_uses_work_item_types_table: false)
end
it 'does not get the type field from the work_item_types table' do
expect_next_instance_of(::IssuePresenter) do |presented_issue|
expect(presented_issue).not_to receive(:work_item_type)
end
execute
end
end
end
end
|