1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe FormHelper do
include Devise::Test::ControllerHelpers
describe '#dropdown_max_select' do
context "with the :limit_reviewer_and_assignee_size feature flag on" do
it 'correctly returns the max amount of reviewers or assignees to allow' do
max = MergeRequest::MAX_NUMBER_OF_ASSIGNEES_OR_REVIEWERS
expect(helper.dropdown_max_select({}))
.to eq(max)
expect(helper.dropdown_max_select({ 'max-select'.to_sym => 5 }))
.to eq(5)
expect(helper.dropdown_max_select({ 'max-select'.to_sym => max + 5 }))
.to eq(max)
end
end
context "with the :limit_reviewer_and_assignee_size feature flag off" do
before do
stub_feature_flags(limit_reviewer_and_assignee_size: false)
end
it 'correctly returns the max amount of reviewers or assignees to allow' do
expect(helper.dropdown_max_select({}))
.to eq(nil)
expect(helper.dropdown_max_select({ 'max-select'.to_sym => 5 }))
.to eq(5)
expect(helper.dropdown_max_select({ 'max-select'.to_sym => 120 }))
.to eq(120)
end
end
end
describe '#reviewers_dropdown_options' do
let(:merge_request) { build(:merge_request) }
context "with the :limit_reviewer_and_assignee_size feature flag on" do
context "with multiple reviewers" do
it 'correctly returns the max amount of reviewers or assignees to allow' do
allow(helper).to receive(:merge_request_supports_multiple_reviewers?).and_return(true)
expect(helper.reviewers_dropdown_options(merge_request)[:data][:'max-select'])
.to eq(MergeRequest::MAX_NUMBER_OF_ASSIGNEES_OR_REVIEWERS)
end
end
context "with only 1 reviewer" do
it 'correctly returns the max amount of reviewers or assignees to allow' do
expect(helper.reviewers_dropdown_options(merge_request)[:data][:'max-select'])
.to eq(1)
end
end
end
context "with the :limit_reviewer_and_assignee_size feature flag off" do
before do
stub_feature_flags(limit_reviewer_and_assignee_size: false)
end
context "with multiple reviewers" do
it 'correctly returns the max amount of reviewers or assignees to allow' do
allow(helper).to receive(:merge_request_supports_multiple_reviewers?).and_return(true)
expect(helper.reviewers_dropdown_options(merge_request)[:data][:'max-select'])
.to eq(nil)
end
end
context "with only 1 reviewer" do
it 'correctly returns the max amount of reviewers or assignees to allow' do
expect(helper.reviewers_dropdown_options(merge_request)[:data][:'max-select'])
.to eq(1)
end
end
end
end
describe 'form_errors' do
it 'returns nil when model has no errors' do
model = double(errors: [])
expect(helper.form_errors(model)).to be_nil
end
it 'renders an appropriately styled alert div' do
model = double(errors: errors_stub('Error 1'))
expect(helper.form_errors(model))
.to include(
'<div class="gl-alert gl-mb-5 gl-alert-danger gl-alert-not-dismissible" id="error_explanation" role="alert">'
)
end
it 'contains a summary message' do
single_error = double(errors: errors_stub('A'))
multi_errors = double(errors: errors_stub('A', 'B', 'C'))
expect(helper.form_errors(single_error))
.to include('The form contains the following error:')
expect(helper.form_errors(multi_errors))
.to include('The form contains the following errors:')
end
it 'renders each message' do
model = double(errors: errors_stub('Error 1', 'Error 2', 'Error 3'))
errors = helper.form_errors(model)
aggregate_failures do
expect(errors).to include('<li>Error 1</li>')
expect(errors).to include('<li>Error 2</li>')
expect(errors).to include('<li>Error 3</li>')
end
end
it 'renders messages truncated if requested' do
model = double(errors: errors_stub('Error 1', 'Error 2'))
model.errors.add(:title, 'is truncated')
model.errors.add(:base, 'Error 3')
expect(model.class).to receive(:human_attribute_name) do |attribute|
attribute.to_s.capitalize
end
errors = helper.form_errors(model, truncate: :title)
aggregate_failures do
expect(errors).to include('<li>Error 1</li>')
expect(errors).to include('<li>Error 2</li>')
expect(errors).to include('<li><span class="str-truncated-100">Title is truncated</span></li>')
expect(errors).to include('<li>Error 3</li>')
end
end
it 'renders help page links' do
stubbed_errors = ActiveModel::Errors.new(double).tap do |errors|
errors.add(:base, 'No text.', help_page_url: 'http://localhost/doc/user/index.html')
errors.add(
:base,
'With text.',
help_link_text: 'Documentation page title.',
help_page_url: 'http://localhost/doc/administration/index.html'
)
errors.add(
:base,
'With HTML text.',
help_link_text: '<foo>',
help_page_url: 'http://localhost/doc/security/index.html'
)
end
model = double(errors: stubbed_errors)
errors = helper.form_errors(model)
aggregate_failures do
expect(errors).to include(
'<li>No text. <a target="_blank" rel="noopener noreferrer" ' \
'href="http://localhost/doc/user/index.html">Learn more.</a></li>'
)
expect(errors).to include(
'<li>With text. <a target="_blank" rel="noopener noreferrer" ' \
'href="http://localhost/doc/administration/index.html">Documentation page title.</a></li>'
)
expect(errors).to include(
'<li>With HTML text. <a target="_blank" rel="noopener noreferrer" ' \
'href="http://localhost/doc/security/index.html"><foo></a></li>'
)
end
end
def errors_stub(*messages)
ActiveModel::Errors.new(double).tap do |errors|
messages.each { |msg| errors.add(:base, msg) }
end
end
end
end
|
