1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
# frozen_string_literal: true
require "spec_helper"
RSpec.describe Groups::GroupMembersHelper do
include MembersPresentation
let_it_be(:group) { create(:group) }
describe '#group_members_app_data' do
include_context 'group_group_link'
let_it_be(:current_user) { create(:user) }
let(:members) { create_list(:group_member, 2, group: shared_group, created_by: current_user) }
let(:invited) { create_list(:group_member, 2, :invited, group: shared_group, created_by: current_user) }
let!(:access_requests) { create_list(:group_member, 2, :access_request, group: shared_group, created_by: current_user) }
let(:members_collection) { members }
before do
allow(helper).to receive(:can?).with(current_user, :export_group_memberships, group).and_return(false)
allow(helper).to receive(:can?).with(current_user, :owner_access, group).and_return(true)
allow(helper).to receive(:current_user).and_return(current_user)
allow(helper).to receive(:can?).with(current_user, :export_group_memberships, shared_group).and_return(true)
allow(helper).to receive(:group_group_member_path).with(shared_group, ':id').and_return('/groups/foo-bar/-/group_members/:id')
allow(helper).to receive(:group_group_link_path).with(shared_group, ':id').and_return('/groups/foo-bar/-/group_links/:id')
allow(helper).to receive(:can?).with(current_user, :admin_group_member, shared_group).and_return(true)
allow(helper).to receive(:can?).with(current_user, :admin_member_access_request, shared_group).and_return(true)
end
subject do
helper.group_members_app_data(
shared_group,
members: present_members(members_collection),
invited: present_members(invited),
access_requests: present_members(access_requests),
banned: [],
include_relations: [:inherited, :direct],
search: nil
)
end
shared_examples 'members.json' do |member_type|
it 'returns `members` property that matches json schema' do
expect(subject[member_type.to_sym][:members].to_json).to match_schema('members')
end
it 'sets `member_path` property' do
expect(subject[member_type.to_sym][:member_path]).to eq('/groups/foo-bar/-/group_members/:id')
end
end
it 'returns expected json' do
expected = {
source_id: shared_group.id,
can_manage_members: true,
can_manage_access_requests: true,
group_name: shared_group.name,
group_path: shared_group.full_path
}
expect(subject).to include(expected)
end
context 'group members' do
it_behaves_like 'members.json', 'user'
context 'with user status set' do
let(:user) { create(:user) }
let!(:status) { create(:user_status, user: user) }
let(:members) { [create(:group_member, group: shared_group, user: user, created_by: current_user)] }
it_behaves_like 'members.json', 'user'
end
end
context 'invited group members' do
it_behaves_like 'members.json', 'invite'
end
context 'access requests' do
it_behaves_like 'members.json', 'access_request'
end
context 'group links' do
it 'sets `group.members` property that matches json schema' do
expect(subject[:group][:members].to_json).to match_schema('group_link/group_group_links')
end
it 'sets `member_path` property' do
expect(subject[:group][:member_path]).to eq('/groups/foo-bar/-/group_links/:id')
end
context 'inherited' do
let_it_be(:sub_shared_group) { create(:group, parent: shared_group) }
let_it_be(:sub_shared_with_group) { create(:group) }
let_it_be(:sub_group_group_link) { create(:group_group_link, shared_group: sub_shared_group, shared_with_group: sub_shared_with_group) }
let_it_be(:subject_group) { sub_shared_group }
before do
allow(helper).to receive(:group_group_member_path).with(sub_shared_group, ':id').and_return('/groups/foo-bar/-/group_members/:id')
allow(helper).to receive(:group_group_link_path).with(sub_shared_group, ':id').and_return('/groups/foo-bar/-/group_links/:id')
allow(helper).to receive(:can?).with(current_user, :admin_group_member, sub_shared_group).and_return(true)
allow(helper).to receive(:can?).with(current_user, :admin_member_access_request, sub_shared_group).and_return(true)
allow(helper).to receive(:can?).with(current_user, :export_group_memberships, sub_shared_group).and_return(true)
end
subject do
helper.group_members_app_data(
sub_shared_group,
members: present_members(members_collection),
invited: present_members(invited),
access_requests: present_members(access_requests),
banned: [],
include_relations: include_relations,
search: nil
)
end
using RSpec::Parameterized::TableSyntax
where(:include_relations, :result) do
[:inherited, :direct] | lazy { [group_group_link, sub_group_group_link].map(&:id) }
[:inherited] | lazy { [group_group_link].map(&:id) }
[:direct] | lazy { [sub_group_group_link].map(&:id) }
end
with_them do
it 'returns correct group links' do
expect(subject[:group][:members].map { |link| link[:id] }).to match_array(result)
end
end
end
end
context 'when pagination is not available' do
it 'sets `pagination` attribute to expected json' do
expected = {
current_page: nil,
per_page: nil,
total_items: 2,
param_name: nil,
params: {}
}.as_json
expect(subject[:access_request][:pagination].as_json).to include(expected)
end
end
context 'when pagination is available' do
let(:members_collection) { Kaminari.paginate_array(members).page(1).per(1) }
it 'sets `pagination` attribute to expected json' do
expected = {
current_page: 1,
per_page: 1,
total_items: 2,
param_name: :page,
params: { invited_members_page: nil, search_invited: nil }
}.as_json
expect(subject[:user][:pagination].as_json).to include(expected)
end
end
end
describe '#group_member_header_subtext' do
it 'contains expected text with group name' do
expect(helper.group_member_header_subtext(group)).to match("You're viewing members of .*#{group.name}")
end
end
end
|
