summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/auth/two_factor_auth_verifier_spec.rb
blob: f906870195a0447c553cebdfc324509c51279651 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Gitlab::Auth::TwoFactorAuthVerifier do
  let(:user) { create(:user) }

  subject { described_class.new(user) }

  describe '#two_factor_authentication_required?' do
    describe 'when it is required on application level' do
      it 'returns true' do
        stub_application_setting require_two_factor_authentication: true

        expect(subject.two_factor_authentication_required?).to be_truthy
      end
    end

    describe 'when it is required on group level' do
      it 'returns true' do
        allow(user).to receive(:require_two_factor_authentication_from_group?).and_return(true)

        expect(subject.two_factor_authentication_required?).to be_truthy
      end
    end

    describe 'when it is not required' do
      it 'returns false when not required on group level' do
        allow(user).to receive(:require_two_factor_authentication_from_group?).and_return(false)

        expect(subject.two_factor_authentication_required?).to be_falsey
      end
    end
  end

  describe '#current_user_needs_to_setup_two_factor?' do
    it 'returns false when current_user is nil' do
      expect(described_class.new(nil).current_user_needs_to_setup_two_factor?).to be_falsey
    end

    it 'returns false when current_user does not have temp email' do
      allow(user).to receive(:two_factor_enabled?).and_return(false)
      allow(user).to receive(:temp_oauth_email?).and_return(true)

      expect(subject.current_user_needs_to_setup_two_factor?).to be_falsey
    end

    it 'returns false when current_user has 2fa disabled' do
      allow(user).to receive(:temp_oauth_email?).and_return(false)
      allow(user).to receive(:two_factor_enabled?).and_return(true)

      expect(subject.current_user_needs_to_setup_two_factor?).to be_falsey
    end

    it 'returns true when user requires 2fa authentication' do
      allow(user).to receive(:two_factor_enabled?).and_return(false)
      allow(user).to receive(:temp_oauth_email?).and_return(false)

      expect(subject.current_user_needs_to_setup_two_factor?).to be_truthy
    end
  end

  describe '#two_factor_grace_period' do
    it 'returns grace period from settings if there is no period from groups' do
      stub_application_setting two_factor_grace_period: 2
      allow(user).to receive(:require_two_factor_authentication_from_group?).and_return(false)

      expect(subject.two_factor_grace_period).to eq(2)
    end

    it 'returns grace period from groups if there is no period from settings' do
      allow(user).to receive(:require_two_factor_authentication_from_group?).and_return(true)
      allow(user).to receive(:two_factor_grace_period).and_return(3)

      expect(subject.two_factor_grace_period).to eq(3)
    end

    it 'returns minimal grace period if there is grace period from settings and from group' do
      allow(user).to receive(:require_two_factor_authentication_from_group?).and_return(true)
      allow(user).to receive(:two_factor_grace_period).and_return(3)
      stub_application_setting two_factor_grace_period: 2

      expect(subject.two_factor_grace_period).to eq(2)
    end
  end

  describe '#two_factor_grace_period_expired?' do
    before do
      allow(user).to receive(:otp_grace_period_started_at).and_return(4.hours.ago)
    end

    it 'returns true if the grace period has expired' do
      allow(subject).to receive(:two_factor_grace_period).and_return(2)

      expect(subject.two_factor_grace_period_expired?).to be_truthy
    end

    it 'returns false if the grace period has not expired' do
      allow(subject).to receive(:two_factor_grace_period).and_return(6)

      expect(subject.two_factor_grace_period_expired?).to be_falsey
    end

    context 'when otp_grace_period_started_at is nil' do
      it 'returns false' do
        allow(user).to receive(:otp_grace_period_started_at).and_return(nil)

        expect(subject.two_factor_grace_period_expired?).to be_falsey
      end
    end
  end
end