1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::BackgroundMigration::CopyColumnUsingBackgroundMigrationJob do
it { expect(described_class).to be < Gitlab::BackgroundMigration::BatchedMigrationJob }
describe '#perform' do
let(:table_name) { :_test_copy_primary_key_test }
let(:test_table) { table(table_name) }
let(:sub_batch_size) { 1000 }
let(:pause_ms) { 0 }
let(:connection) { ApplicationRecord.connection }
let(:helpers) do
ActiveRecord::Migration.new.extend(Gitlab::Database::MigrationHelpers)
end
let(:job_arguments) { %w(name name_convert_to_text) }
let(:copy_job) do
described_class.new(start_id: 12,
end_id: 20,
batch_table: table_name,
batch_column: 'id',
sub_batch_size: sub_batch_size,
pause_ms: pause_ms,
job_arguments: job_arguments,
connection: connection)
end
before do
connection.execute(<<~SQL)
CREATE TABLE #{table_name}
(
id integer NOT NULL,
name character varying,
fk integer NOT NULL,
#{helpers.convert_to_bigint_column(:id)} bigint DEFAULT 0 NOT NULL,
#{helpers.convert_to_bigint_column(:fk)} bigint DEFAULT 0 NOT NULL,
name_convert_to_text text DEFAULT 'no name'
);
SQL
# Insert some data, it doesn't make a difference
test_table.create!(id: 11, name: 'test1', fk: 1)
test_table.create!(id: 12, name: 'test2', fk: 2)
test_table.create!(id: 15, name: nil, fk: 3)
test_table.create!(id: 19, name: 'test4', fk: 4)
end
after do
# Make sure that the temp table we created is dropped (it is not removed by the database_cleaner)
connection.execute(<<~SQL)
DROP TABLE IF EXISTS #{table_name};
SQL
end
context 'primary keys' do
let(:temporary_column) { helpers.convert_to_bigint_column(:id) }
let(:job_arguments) { ['id', temporary_column] }
it 'copies all in range' do
copy_job.perform
expect(test_table.count).to eq(4)
expect(test_table.where("id = #{temporary_column}").pluck(:id)).to contain_exactly(12, 15, 19)
expect(test_table.where(temporary_column => 0).pluck(:id)).to contain_exactly(11)
end
end
context 'foreign keys' do
let(:temporary_column) { helpers.convert_to_bigint_column(:fk) }
let(:job_arguments) { ['fk', temporary_column] }
it 'copies all in range' do
copy_job.perform
expect(test_table.count).to eq(4)
expect(test_table.where("fk = #{temporary_column}").pluck(:id)).to contain_exactly(12, 15, 19)
expect(test_table.where(temporary_column => 0).pluck(:id)).to contain_exactly(11)
end
end
context 'columns with NULLs' do
let(:job_arguments) { %w(name name_convert_to_text) }
it 'copies all in range' do
expect { copy_job.perform }
.to change { test_table.where("name_convert_to_text = 'no name'").count }.from(4).to(1)
expect(test_table.where('name = name_convert_to_text').pluck(:id)).to contain_exactly(12, 19)
expect(test_table.where('name is NULL and name_convert_to_text is NULL').pluck(:id)).to contain_exactly(15)
end
end
context 'when multiple columns are given' do
let(:id_tmp_column) { helpers.convert_to_bigint_column('id') }
let(:fk_tmp_column) { helpers.convert_to_bigint_column('fk') }
let(:columns_to_copy_from) { %w[id fk] }
let(:columns_to_copy_to) { [id_tmp_column, fk_tmp_column] }
let(:job_arguments) { [columns_to_copy_from, columns_to_copy_to] }
it 'copies all values in the range' do
copy_job.perform
expect(test_table.count).to eq(4)
expect(test_table.where("id = #{id_tmp_column} AND fk = #{fk_tmp_column}").pluck(:id)).to contain_exactly(12, 15, 19)
expect(test_table.where(id_tmp_column => 0).where(fk_tmp_column => 0).pluck(:id)).to contain_exactly(11)
end
context 'when the number of source and target columns does not match' do
let(:columns_to_copy_to) { [id_tmp_column] }
it 'raises an error' do
expect do
copy_job.perform
end.to raise_error(ArgumentError, 'number of source and destination columns must match')
end
end
end
it 'tracks timings of queries' do
expect(copy_job.batch_metrics.timings).to be_empty
copy_job.perform
expect(copy_job.batch_metrics.timings[:update_all]).not_to be_empty
end
context 'pause interval between sub-batches' do
let(:pause_ms) { 5 }
it 'sleeps for the specified time between sub-batches' do
expect(copy_job).to receive(:sleep).with(0.005)
copy_job.perform
end
context 'when pause_ms value is negative' do
let(:pause_ms) { -5 }
it 'treats it as a 0' do
expect(copy_job).to receive(:sleep).with(0)
copy_job.perform
end
end
end
end
end
|
