blob: c25344ec1a447c470dacd0a441c8c9a03a9236af (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
require 'fast_spec_helper'
require 'chronic_duration'
require 'support/helpers/stub_feature_flags'
require_dependency 'active_model'
describe Gitlab::Ci::Config::Entry::Rules::Rule do
let(:entry) { described_class.new(config) }
describe '.new' do
subject { entry }
context 'with a when: value but no clauses' do
let(:config) { { when: 'manual' } }
it { is_expected.to be_valid }
end
context 'when specifying an if: clause' do
let(:config) { { if: '$THIS || $THAT', when: 'manual' } }
it { is_expected.to be_valid }
describe '#when' do
subject { entry.when }
it { is_expected.to eq('manual') }
end
end
context 'using a list of multiple expressions' do
let(:config) { { if: ['$MY_VAR == "this"', '$YOUR_VAR == "that"'] } }
it { is_expected.not_to be_valid }
it 'reports an error about invalid format' do
expect(subject.errors).to include(/invalid expression syntax/)
end
end
context 'when specifying an invalid if: clause expression' do
let(:config) { { if: ['$MY_VAR =='] } }
it { is_expected.not_to be_valid }
it 'reports an error about invalid statement' do
expect(subject.errors).to include(/invalid expression syntax/)
end
end
context 'when specifying an if: clause expression with an invalid token' do
let(:config) { { if: ['$MY_VAR == 123'] } }
it { is_expected.not_to be_valid }
it 'reports an error about invalid statement' do
expect(subject.errors).to include(/invalid expression syntax/)
end
end
context 'when using invalid regex in an if: clause' do
let(:config) { { if: ['$MY_VAR =~ /some ( thing/'] } }
it 'reports an error about invalid expression' do
expect(subject.errors).to include(/invalid expression syntax/)
end
end
context 'when using an if: clause with lookahead regex character "?"' do
let(:config) { { if: '$CI_COMMIT_REF =~ /^(?!master).+/' } }
context 'when allow_unsafe_ruby_regexp is disabled' do
it { is_expected.not_to be_valid }
it 'reports an error about invalid expression syntax' do
expect(subject.errors).to include(/invalid expression syntax/)
end
end
end
context 'when using a changes: clause' do
let(:config) { { changes: %w[app/ lib/ spec/ other/* paths/**/*.rb] } }
it { is_expected.to be_valid }
end
context 'when using a string as an invalid changes: clause' do
let(:config) { { changes: 'a regular string' } }
it { is_expected.not_to be_valid }
it 'reports an error about invalid policy' do
expect(subject.errors).to include(/should be an array of strings/)
end
end
context 'when using a list as an invalid changes: clause' do
let(:config) { { changes: [1, 2] } }
it { is_expected.not_to be_valid }
it 'returns errors' do
expect(subject.errors).to include(/changes should be an array of strings/)
end
end
context 'specifying a delayed job' do
let(:config) { { if: '$THIS || $THAT', when: 'delayed', start_in: '15 minutes' } }
it { is_expected.to be_valid }
it 'sets attributes for the job delay' do
expect(entry.when).to eq('delayed')
expect(entry.start_in).to eq('15 minutes')
end
context 'without a when: key' do
let(:config) { { if: '$THIS || $THAT', start_in: '15 minutes' } }
it { is_expected.not_to be_valid }
it 'returns an error about the disallowed key' do
expect(entry.errors).to include(/disallowed keys: start_in/)
end
end
context 'without a start_in: key' do
let(:config) { { if: '$THIS || $THAT', when: 'delayed' } }
it { is_expected.not_to be_valid }
it 'returns an error about tstart_in being blank' do
expect(entry.errors).to include(/start in can't be blank/)
end
end
end
context 'when specifying unknown policy' do
let(:config) { { invalid: :something } }
it { is_expected.not_to be_valid }
it 'returns error about invalid key' do
expect(entry.errors).to include(/unknown keys: invalid/)
end
end
context 'when clause is empty' do
let(:config) { {} }
it { is_expected.not_to be_valid }
it 'is not a valid configuration' do
expect(entry.errors).to include(/can't be blank/)
end
end
context 'when policy strategy does not match' do
let(:config) { 'string strategy' }
it { is_expected.not_to be_valid }
it 'returns information about errors' do
expect(entry.errors)
.to include(/should be a hash/)
end
end
end
describe '#value' do
subject { entry.value }
context 'when specifying an if: clause' do
let(:config) { { if: '$THIS || $THAT', when: 'manual' } }
it 'stores the expression as "if"' do
expect(subject).to eq(if: '$THIS || $THAT', when: 'manual')
end
end
context 'when using a changes: clause' do
let(:config) { { changes: %w[app/ lib/ spec/ other/* paths/**/*.rb] } }
it { is_expected.to eq(config) }
end
context 'when default value has been provided' do
let(:config) { { changes: %w[app/**/*.rb] } }
before do
entry.default = { changes: %w[**/*] }
end
it 'does not set a default value' do
expect(entry.default).to eq(nil)
end
it 'does not add to provided configuration' do
expect(entry.value).to eq(config)
end
end
end
describe '.default' do
it 'does not have default value' do
expect(described_class.default).to be_nil
end
end
end
|
