1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Ci::Config::External::Mapper::Verifier, feature_category: :pipeline_authoring do
include RepoHelpers
include StubRequests
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { project.owner }
let(:context) do
Gitlab::Ci::Config::External::Context.new(project: project, user: user, sha: project.commit.id)
end
let(:remote_url) { 'https://gitlab.com/gitlab-org/gitlab-foss/blob/1234/.gitlab-ci-1.yml' }
let(:project_files) do
{
'myfolder/file1.yml' => <<~YAML,
my_build:
script: echo Hello World
YAML
'myfolder/file2.yml' => <<~YAML,
my_test:
script: echo Hello World
YAML
'myfolder/file3.yml' => <<~YAML,
my_deploy:
script: echo Hello World
YAML
'nested_configs.yml' => <<~YAML
include:
- local: myfolder/file1.yml
- local: myfolder/file2.yml
- remote: #{remote_url}
YAML
}
end
around(:all) do |example|
create_and_delete_files(project, project_files) do
example.run
end
end
before do
stub_full_request(remote_url).to_return(
body: <<~YAML
remote_test:
script: echo Hello World
YAML
)
end
subject(:verifier) { described_class.new(context) }
describe '#process' do
subject(:process) { verifier.process(files) }
context 'when files are local' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file1.yml' }, context),
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file2.yml' }, context),
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file3.yml' }, context)
]
end
it 'returns an array of file objects' do
expect(process.map(&:location)).to contain_exactly(
'myfolder/file1.yml', 'myfolder/file2.yml', 'myfolder/file3.yml'
)
end
it 'adds files to the expandset' do
expect { process }.to change { context.expandset.count }.by(3)
end
it 'calls Gitaly only once for all files', :request_store do
# 1 for project.commit.id, 1 for the files
expect { process }.to change { Gitlab::GitalyClient.get_request_count }.by(2)
end
end
context 'when files are project files' do
let_it_be(:included_project) { create(:project, :repository, namespace: project.namespace, creator: user) }
let(:files) do
[
Gitlab::Ci::Config::External::File::Project.new(
{ file: 'myfolder/file1.yml', project: included_project.full_path }, context
),
Gitlab::Ci::Config::External::File::Project.new(
{ file: 'myfolder/file2.yml', project: included_project.full_path }, context
),
Gitlab::Ci::Config::External::File::Project.new(
{ file: 'myfolder/file3.yml', project: included_project.full_path }, context
)
]
end
around(:all) do |example|
create_and_delete_files(included_project, project_files) do
example.run
end
end
it 'returns an array of file objects' do
expect(process.map(&:location)).to contain_exactly(
'myfolder/file1.yml', 'myfolder/file2.yml', 'myfolder/file3.yml'
)
end
it 'adds files to the expandset' do
expect { process }.to change { context.expandset.count }.by(3)
end
it 'calls Gitaly only once for all files', :request_store do
# 1 for project.commit.id, 3 for the sha check, 1 for the files
expect { process }.to change { Gitlab::GitalyClient.get_request_count }.by(5)
end
end
context 'when a file includes other files' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'nested_configs.yml' }, context)
]
end
it 'returns an array of file objects with combined hash' do
expect(process.map(&:to_hash)).to contain_exactly(
{ my_build: { script: 'echo Hello World' },
my_test: { script: 'echo Hello World' },
remote_test: { script: 'echo Hello World' } }
)
end
end
context 'when there is an invalid file' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/invalid.yml' }, context)
]
end
it 'adds an error to the file' do
expect(process.first.errors).to include("Local file `myfolder/invalid.yml` does not exist!")
end
end
context 'when total file count exceeds max_includes' do
context 'when files are nested' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'nested_configs.yml' }, context)
]
end
it 'raises Processor::IncludeError' do
allow(context).to receive(:max_includes).and_return(1)
expect { process }.to raise_error(Gitlab::Ci::Config::External::Processor::IncludeError)
end
end
context 'when files are not nested' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file1.yml' }, context),
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file2.yml' }, context)
]
end
it 'raises Mapper::TooManyIncludesError' do
allow(context).to receive(:max_includes).and_return(1)
expect { process }.to raise_error(Gitlab::Ci::Config::External::Mapper::TooManyIncludesError)
end
end
context 'when files are duplicates' do
let(:files) do
[
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file1.yml' }, context),
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file1.yml' }, context),
Gitlab::Ci::Config::External::File::Local.new({ local: 'myfolder/file1.yml' }, context)
]
end
it 'raises error' do
allow(context).to receive(:max_includes).and_return(2)
expect { process }.to raise_error(Gitlab::Ci::Config::External::Mapper::TooManyIncludesError)
end
context 'when FF ci_includes_count_duplicates is disabled' do
before do
stub_feature_flags(ci_includes_count_duplicates: false)
end
it 'does not raise error' do
allow(context).to receive(:max_includes).and_return(2)
expect { process }.not_to raise_error
end
end
end
end
end
end
|
