1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Cleanup::OrphanLfsFileReferences do
include ProjectForksHelper
let(:null_logger) { Logger.new('/dev/null') }
let(:project) { create(:project, :repository, lfs_enabled: true) }
let(:lfs_object) { create(:lfs_object) }
let!(:invalid_reference) { create(:lfs_objects_project, project: project, lfs_object: lfs_object) }
subject(:service) { described_class.new(project, logger: null_logger, dry_run: dry_run) }
before do
allow(null_logger).to receive(:info)
allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
# Create a valid reference
oid = project.repository.gitaly_blob_client.get_all_lfs_pointers.first.lfs_oid
lfs_object2 = create(:lfs_object, oid: oid)
create(:lfs_objects_project, project: project, lfs_object: lfs_object2)
end
context 'dry run' do
let(:dry_run) { true }
it 'prints messages and does not delete references' do
expect(null_logger).to receive(:info).with("[DRY RUN] Looking for orphan LFS files for project #{project.name_with_namespace}")
expect(null_logger).to receive(:info).with("[DRY RUN] Found invalid references: 1")
expect { service.run! }.not_to change { project.lfs_objects.count }
end
end
context 'regular run' do
let(:dry_run) { false }
it 'prints messages and deletes invalid reference' do
expect(null_logger).to receive(:info).with("Looking for orphan LFS files for project #{project.name_with_namespace}")
expect(null_logger).to receive(:info).with("Removed invalid references: 1")
expect(ProjectCacheWorker).to receive(:perform_async).with(project.id, [], [:lfs_objects_size])
expect { service.run! }.to change { project.lfs_objects.count }.from(2).to(1)
expect(LfsObjectsProject.exists?(invalid_reference.id)).to be_falsey
end
context 'LFS object is in design repository' do
before do
expect(project.design_repository).to receive(:exists?).and_return(true)
stub_lfs_pointers(project.design_repository, lfs_object.oid)
end
it 'is not removed' do
expect { service.run! }.not_to change { project.lfs_objects.count }
end
end
context 'LFS object is in wiki repository' do
before do
expect(project.wiki.repository).to receive(:exists?).and_return(true)
stub_lfs_pointers(project.wiki.repository, lfs_object.oid)
end
it 'is not removed' do
expect { service.run! }.not_to change { project.lfs_objects.count }
end
end
end
context 'LFS for project snippets' do
let(:snippet) { create(:project_snippet) }
it 'is disabled' do
# Support project snippets here before enabling LFS for them
expect(snippet.repository.lfs_enabled?).to be_falsy
end
end
def stub_lfs_pointers(repo, *oids)
expect(repo.gitaly_blob_client)
.to receive(:get_all_lfs_pointers)
.and_return(oids.map { |oid| OpenStruct.new(lfs_oid: oid) })
end
end
|
