summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/lfs_token_spec.rb
blob: 1ec1ba19e39f1f39f61ee2ef2bb1bc048935fb9f (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
# frozen_string_literal: true

require 'spec_helper'

describe Gitlab::LfsToken, :clean_gitlab_redis_shared_state do
  describe '#token' do
    shared_examples 'an LFS token generator' do
      it 'returns a computed token' do
        expect(Settings).to receive(:attr_encrypted_db_key_base).and_return('fbnbv6hdjweo53qka7kza8v8swxc413c05pb51qgtfte0bygh1p2e508468hfsn5ntmjcyiz7h1d92ashpet5pkdyejg7g8or3yryhuso4h8o5c73h429d9c3r6bjnet').twice

        token = lfs_token.token

        expect(token).not_to be_nil
        expect(token).to be_a String
        expect(described_class.new(actor).token_valid?(token)).to be_truthy
      end
    end

    context 'when the actor is a user' do
      let(:actor) { create(:user, username: 'test_user_lfs_1') }
      let(:lfs_token) { described_class.new(actor) }

      before do
        allow(actor).to receive(:encrypted_password).and_return('$2a$04$ETfzVS5spE9Hexn9wh6NUenCHG1LyZ2YdciOYxieV1WLSa8DHqOFO')
      end

      it_behaves_like 'an LFS token generator'

      it 'returns the correct username' do
        expect(lfs_token.actor_name).to eq(actor.username)
      end

      it 'returns the correct token type' do
        expect(lfs_token.type).to eq(:lfs_token)
      end
    end

    context 'when the actor is a key' do
      let(:user) { create(:user, username: 'test_user_lfs_2') }
      let(:actor) { create(:key, user: user) }
      let(:lfs_token) { described_class.new(actor) }

      before do
        allow(user).to receive(:encrypted_password).and_return('$2a$04$C1GAMKsOKouEbhKy2JQoe./3LwOfQAZc.hC8zW2u/wt8xgukvnlV.')
      end

      it_behaves_like 'an LFS token generator'

      it 'returns the correct username' do
        expect(lfs_token.actor_name).to eq(user.username)
      end

      it 'returns the correct token type' do
        expect(lfs_token.type).to eq(:lfs_token)
      end
    end

    context 'when the actor is a deploy key' do
      let(:actor_id) { 1 }
      let(:actor) { create(:deploy_key) }
      let(:project) { create(:project) }
      let(:lfs_token) { described_class.new(actor) }

      before do
        allow(actor).to receive(:id).and_return(actor_id)
      end

      it_behaves_like 'an LFS token generator'

      it 'returns the correct username' do
        expect(lfs_token.actor_name).to eq("lfs+deploy-key-#{actor_id}")
      end

      it 'returns the correct token type' do
        expect(lfs_token.type).to eq(:lfs_deploy_token)
      end
    end

    context 'when the actor is invalid' do
      it 'raises an exception' do
        expect { described_class.new('invalid') }.to raise_error('Bad Actor')
      end
    end
  end

  describe '#token_valid?' do
    let(:actor) { create(:user, username: 'test_user_lfs_1') }
    let(:lfs_token) { described_class.new(actor) }

    before do
      allow(actor).to receive(:encrypted_password).and_return('$2a$04$ETfzVS5spE9Hexn9wh6NUenCHG1LyZ2YdciOYxieV1WLSa8DHqOFO')
    end

    context 'for an HMAC token' do
      before do
        # We're not interested in testing LegacyRedisDeviseToken here
        allow(Gitlab::LfsToken::LegacyRedisDeviseToken).to receive_message_chain(:new, :token_valid?).and_return(false)
      end

      context 'where the token is invalid' do
        context "because it's junk" do
          it 'returns false' do
            expect(lfs_token.token_valid?('junk')).to be_falsey
          end
        end

        context "because it's been fiddled with" do
          it 'returns false' do
            fiddled_token = lfs_token.token.tap { |token| token[0] = 'E' }
            expect(lfs_token.token_valid?(fiddled_token)).to be_falsey
          end
        end

        context "because it was generated with a different secret" do
          it 'returns false' do
            different_actor = create(:user, username: 'test_user_lfs_2')
            different_secret_token = described_class.new(different_actor).token
            expect(lfs_token.token_valid?(different_secret_token)).to be_falsey
          end
        end

        context "because it's expired" do
          it 'returns false' do
            expired_token = lfs_token.token
            # Needs to be at least 1860 seconds, because the default expiry is
            # 1800 seconds with an additional 60 second leeway.
            Timecop.freeze(Time.now + 1865) do
              expect(lfs_token.token_valid?(expired_token)).to be_falsey
            end
          end
        end
      end

      context 'where the token is valid' do
        it 'returns true' do
          expect(lfs_token.token_valid?(lfs_token.token)).to be_truthy
        end
      end
    end

    context 'for a LegacyRedisDevise token' do
      before do
        # We're not interested in testing HMACToken here
        allow_any_instance_of(Gitlab::LfsToken::HMACToken).to receive(:token_valid?).and_return(false)
      end

      context 'where the token is invalid' do
        context "because it's junk" do
          it 'returns false' do
            expect(lfs_token.token_valid?('junk')).to be_falsey
          end
        end

        context "because it's been fiddled with" do
          it 'returns false' do
            generated_token = Gitlab::LfsToken::LegacyRedisDeviseToken.new(actor).store_new_token
            fiddled_token = generated_token.tap { |token| token[0] = 'E' }
            expect(lfs_token.token_valid?(fiddled_token)).to be_falsey
          end
        end

        context "because it was generated with a different secret" do
          it 'returns false' do
            different_actor = create(:user, username: 'test_user_lfs_2')
            different_secret_token = described_class.new(different_actor).token
            expect(lfs_token.token_valid?(different_secret_token)).to be_falsey
          end
        end

        context "because it's expired" do
          it 'returns false' do
            generated_token = Gitlab::LfsToken::LegacyRedisDeviseToken.new(actor).store_new_token(1)
            # We need a real sleep here because we need to wait for redis to expire the key.
            sleep(0.01)
            expect(lfs_token.token_valid?(generated_token)).to be_falsey
          end
        end
      end

      context 'where the token is valid' do
        it 'returns true' do
          generated_token = Gitlab::LfsToken::LegacyRedisDeviseToken.new(actor).store_new_token
          expect(lfs_token.token_valid?(generated_token)).to be_truthy
        end
      end
    end
  end

  describe '#deploy_key_pushable?' do
    let(:lfs_token) { described_class.new(actor) }

    context 'when actor is not a DeployKey' do
      let(:actor) { create(:user) }
      let(:project) { create(:project) }

      it 'returns false' do
        expect(lfs_token.deploy_key_pushable?(project)).to be_falsey
      end
    end

    context 'when actor is a DeployKey' do
      let(:deploy_keys_project) { create(:deploy_keys_project, can_push: can_push) }
      let(:project) { deploy_keys_project.project }
      let(:actor) { deploy_keys_project.deploy_key }

      context 'but the DeployKey cannot push to the project' do
        let(:can_push) { false }

        it 'returns false' do
          expect(lfs_token.deploy_key_pushable?(project)).to be_falsey
        end
      end

      context 'and the DeployKey can push to the project' do
        let(:can_push) { true }

        it 'returns true' do
          expect(lfs_token.deploy_key_pushable?(project)).to be_truthy
        end
      end
    end
  end

  describe '#type' do
    let(:lfs_token) { described_class.new(actor) }

    context 'when actor is not a User' do
      let(:actor) { create(:deploy_key) }

      it 'returns false' do
        expect(lfs_token.type).to eq(:lfs_deploy_token)
      end
    end

    context 'when actor is a User' do
      let(:actor) { create(:user) }

      it 'returns false' do
        expect(lfs_token.type).to eq(:lfs_token)
      end
    end
  end
end