spec/lib/gitlab/octokit/middleware_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68

require 'spec_helper'

describe Gitlab::Octokit::Middleware do
  let(:app) { double(:app) }
  let(:middleware) { described_class.new(app) }

  shared_examples 'Public URL' do
    it 'does not raise an error' do
      expect(app).to receive(:call).with(env)

      expect { middleware.call(env) }.not_to raise_error
    end
  end

  shared_examples 'Local URL' do
    it 'raises an error' do
      expect { middleware.call(env) }.to raise_error(Gitlab::UrlBlocker::BlockedUrlError)
    end
  end

  describe '#call' do
    context 'when the URL is a public URL' do
      let(:env) { { url: 'https://public-url.com' } }

      it_behaves_like 'Public URL'
    end

    context 'when the URL is a localhost adresss' do
      let(:env) { { url: 'http://127.0.0.1' } }

      context 'when localhost requests are not allowed' do
        before do
          stub_application_setting(allow_local_requests_from_hooks_and_services: false)
        end

        it_behaves_like 'Local URL'
      end

      context 'when localhost requests are allowed' do
        before do
          stub_application_setting(allow_local_requests_from_hooks_and_services: true)
        end

        it_behaves_like 'Public URL'
      end
    end

    context 'when the URL is a local network address' do
      let(:env) { { url: 'http://172.16.0.0' } }

      context 'when local network requests are not allowed' do
        before do
          stub_application_setting(allow_local_requests_from_hooks_and_services: false)
        end

        it_behaves_like 'Local URL'
      end

      context 'when local network requests are allowed' do
        before do
          stub_application_setting(allow_local_requests_from_hooks_and_services: true)
        end

        it_behaves_like 'Public URL'
      end
    end
  end
end