spec/migrations/add_foreign_keys_to_todos_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

require 'spec_helper'
require Rails.root.join('db', 'migrate', '20180201110056_add_foreign_keys_to_todos.rb')

describe AddForeignKeysToTodos, :migration do
  let(:todos) { table(:todos) }

  let(:project) { create(:project) }
  let(:user) { create(:user) }

  context 'add foreign key on user_id' do
    let!(:todo_with_user) { create_todo(user_id: user.id) }
    let!(:todo_without_user) { create_todo(user_id: 4711) }

    it 'removes orphaned todos without corresponding user' do
      expect { migrate! }.to change { Todo.count }.from(2).to(1)
    end

    it 'does not remove entries with valid user_id' do
      expect { migrate! }.not_to change { todo_with_user.reload }
    end
  end

  context 'add foreign key on author_id' do
    let!(:todo_with_author) { create_todo(author_id: user.id) }
    let!(:todo_with_invalid_author) { create_todo(author_id: 4711) }

    it 'removes orphaned todos by author_id' do
      expect { migrate! }.to change { Todo.count }.from(2).to(1)
    end

    it 'does not touch author_id for valid entries' do
      expect { migrate! }.not_to change { todo_with_author.reload }
    end
  end

  context 'add foreign key on note_id' do
    let(:note) { create(:note) }
    let!(:todo_with_note) { create_todo(note_id: note.id) }
    let!(:todo_with_invalid_note) { create_todo(note_id: 4711) }
    let!(:todo_without_note) { create_todo(note_id: nil) }

    it 'deletes todo if note_id is set but does not exist in notes table' do
      expect { migrate! }.to change { Todo.count }.from(3).to(2)
    end

    it 'does not touch entry if note_id is nil' do
      expect { migrate! }.not_to change { todo_without_note.reload }
    end

    it 'does not touch note_id for valid entries' do
      expect { migrate! }.not_to change { todo_with_note.reload }
    end
  end

  def create_todo(**opts)
    todos.create!(
      project_id: project.id,
      user_id: user.id,
      author_id: user.id,
      target_type: '',
      action: 0,
      state: '', **opts
    )
  end
end