1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ml::Candidate, factory_default: :keep do
let_it_be(:candidate) { create(:ml_candidates, :with_metrics_and_params) }
let_it_be(:candidate2) { create(:ml_candidates, experiment: candidate.experiment) }
let_it_be(:candidate_artifact) do
FactoryBot.create(:generic_package,
name: candidate.package_name,
version: candidate.package_version,
project: candidate.project)
end
let(:project) { candidate.experiment.project }
describe 'associations' do
it { is_expected.to belong_to(:experiment) }
it { is_expected.to belong_to(:user) }
it { is_expected.to have_many(:params) }
it { is_expected.to have_many(:metrics) }
it { is_expected.to have_many(:metadata) }
end
describe 'default values' do
it { expect(described_class.new.iid).to be_present }
end
describe '.artifact_root' do
subject { candidate.artifact_root }
it { is_expected.to eq("/ml_candidate_#{candidate.id}/-/") }
end
describe '.package_name' do
subject { candidate.package_name }
it { is_expected.to eq("ml_candidate_#{candidate.id}") }
end
describe '.package_version' do
subject { candidate.package_version }
it { is_expected.to eq('-') }
end
describe '.artifact' do
let(:tested_candidate) { candidate }
subject { tested_candidate.artifact }
before do
candidate_artifact
end
context 'when has logged artifacts' do
it 'returns the package' do
expect(subject.name).to eq(tested_candidate.package_name)
end
end
context 'when does not have logged artifacts' do
let(:tested_candidate) { candidate2 }
it { is_expected.to be_nil }
end
end
describe '.artifact_lazy' do
context 'when candidates have same the same iid' do
before do
BatchLoader::Executor.clear_current
end
it 'loads the correct artifacts', :aggregate_failures do
candidate.artifact_lazy
candidate2.artifact_lazy
expect(Packages::Package).to receive(:joins).once.and_call_original # Only one database call
expect(candidate.artifact.name).to eq(candidate.package_name)
expect(candidate2.artifact).to be_nil
end
end
end
describe '#by_project_id_and_iid' do
let(:project_id) { candidate.experiment.project_id }
let(:iid) { candidate.iid }
subject { described_class.with_project_id_and_iid(project_id, iid) }
context 'when iid exists', 'and belongs to project' do
it { is_expected.to eq(candidate) }
end
context 'when iid exists', 'and does not belong to project' do
let(:project_id) { non_existing_record_id }
it { is_expected.to be_nil }
end
context 'when iid does not exist' do
let(:iid) { 'a' }
it { is_expected.to be_nil }
end
end
describe "#latest_metrics" do
let_it_be(:candidate2) { create(:ml_candidates, experiment: candidate.experiment) }
let!(:metric1) { create(:ml_candidate_metrics, candidate: candidate2) }
let!(:metric2) { create(:ml_candidate_metrics, candidate: candidate2 ) }
let!(:metric3) { create(:ml_candidate_metrics, name: metric1.name, candidate: candidate2) }
subject { candidate2.latest_metrics }
it 'fetches only the last metric for the name' do
expect(subject).to match_array([metric2, metric3] )
end
end
describe "#including_relationships" do
subject { described_class.including_relationships.find_by(id: candidate.id) }
it 'loads latest metrics and params', :aggregate_failures do
expect(subject.association_cached?(:latest_metrics)).to be(true)
expect(subject.association_cached?(:params)).to be(true)
expect(subject.association_cached?(:user)).to be(true)
end
end
end
|