1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::BuildArtifactsSizeRefresh, type: :model do
describe 'associations' do
it { is_expected.to belong_to(:project) }
end
it_behaves_like 'having unique enum values'
describe 'validations' do
it { is_expected.to validate_presence_of(:project) }
end
describe 'scopes' do
let_it_be(:refresh_1) { create(:project_build_artifacts_size_refresh, :running, updated_at: (described_class::STALE_WINDOW + 1.second).ago) }
let_it_be(:refresh_2) { create(:project_build_artifacts_size_refresh, :running, updated_at: 1.hour.ago) }
let_it_be(:refresh_3) { create(:project_build_artifacts_size_refresh, :pending) }
let_it_be(:refresh_4) { create(:project_build_artifacts_size_refresh, :created) }
describe 'stale' do
it 'returns records in running state and has not been updated for more than 2 hours' do
expect(described_class.stale).to eq([refresh_1])
end
end
describe 'remaining' do
it 'returns stale, created, and pending records' do
expect(described_class.remaining).to match_array([refresh_1, refresh_3, refresh_4])
end
end
describe 'processing_queue' do
it 'prioritizes pending -> stale -> created' do
expect(described_class.processing_queue).to eq([refresh_3, refresh_1, refresh_4])
end
end
end
describe 'state machine', :clean_gitlab_redis_shared_state do
around do |example|
freeze_time { example.run }
end
let(:now) { Time.zone.now }
describe 'initial state' do
let(:refresh) { create(:project_build_artifacts_size_refresh) }
it 'defaults to created' do
expect(refresh).to be_created
end
end
describe '#process!' do
context 'when refresh state is created' do
let_it_be_with_reload(:refresh) do
create(
:project_build_artifacts_size_refresh,
:created,
updated_at: 2.days.ago,
refresh_started_at: nil,
last_job_artifact_id: nil
)
end
let!(:last_job_artifact_id_on_refresh_start) { create(:ci_job_artifact, project: refresh.project) }
before do
stats = create(:project_statistics, project: refresh.project, build_artifacts_size: 120)
stats.increment_counter(:build_artifacts_size, 30)
end
it 'transitions the state to running' do
expect { refresh.process! }.to change { refresh.state }.to(described_class::STATES[:running])
end
it 'sets the refresh_started_at' do
expect { refresh.process! }.to change { refresh.refresh_started_at.to_i }.to(now.to_i)
end
it 'sets last_job_artifact_id_on_refresh_start' do
expect { refresh.process! }.to change { refresh.last_job_artifact_id_on_refresh_start.to_i }.to(last_job_artifact_id_on_refresh_start.id)
end
it 'bumps the updated_at' do
expect { refresh.process! }.to change { refresh.updated_at.to_i }.to(now.to_i)
end
it 'resets the build artifacts size stats' do
expect { refresh.process! }.to change { refresh.project.statistics.build_artifacts_size }.to(0)
end
it 'resets the counter attribute to zero' do
expect { refresh.process! }.to change { refresh.project.statistics.get_counter_value(:build_artifacts_size) }.to(0)
end
end
context 'when refresh state is pending' do
let!(:refresh) do
create(
:project_build_artifacts_size_refresh,
:pending,
updated_at: 2.days.ago
)
end
before do
create(:project_statistics, project: refresh.project)
end
it 'transitions the state to running' do
expect { refresh.process! }.to change { refresh.reload.state }.to(described_class::STATES[:running])
end
it 'bumps the updated_at' do
expect { refresh.process! }.to change { refresh.reload.updated_at.to_i }.to(now.to_i)
end
end
context 'when refresh state is running' do
let!(:refresh) do
create(
:project_build_artifacts_size_refresh,
:running,
updated_at: 2.days.ago
)
end
before do
create(:project_statistics, project: refresh.project)
end
it 'keeps the state at running' do
expect { refresh.process! }.not_to change { refresh.reload.state }
end
it 'bumps the updated_at' do
# If this was a stale job, we want to bump the updated at now so that
# it won't be picked up by another worker while we're recalculating
expect { refresh.process! }.to change { refresh.reload.updated_at.to_i }.to(now.to_i)
end
end
end
describe '#requeue!' do
let!(:refresh) do
create(
:project_build_artifacts_size_refresh,
:running,
updated_at: 2.days.ago,
last_job_artifact_id: 111
)
end
let(:last_job_artifact_id) { 123 }
it 'transitions refresh state from running to pending' do
expect { refresh.requeue!(last_job_artifact_id) }.to change { refresh.reload.state }.to(described_class::STATES[:pending])
end
it 'bumps updated_at' do
expect { refresh.requeue!(last_job_artifact_id) }.to change { refresh.reload.updated_at.to_i }.to(now.to_i)
end
it 'updates last_job_artifact_id' do
expect { refresh.requeue!(last_job_artifact_id) }.to change { refresh.reload.last_job_artifact_id.to_i }.to(last_job_artifact_id)
end
end
end
describe '.process_next_refresh!' do
let!(:refresh_created) { create(:project_build_artifacts_size_refresh, :created) }
let!(:refresh_pending) { create(:project_build_artifacts_size_refresh, :pending) }
subject(:processed_refresh) { described_class.process_next_refresh! }
it 'picks the first record from the remaining work' do
expect(processed_refresh).to eq(refresh_pending)
expect(processed_refresh.reload).to be_running
end
end
describe '.enqueue_refresh' do
let_it_be(:project_1) { create(:project) }
let_it_be(:project_2) { create(:project) }
let(:projects) { [project_1, project_1, project_2] }
it 'creates refresh records for each given project, skipping duplicates' do
expect { described_class.enqueue_refresh(projects) }
.to change { described_class.count }.from(0).to(2)
expect(described_class.first).to have_attributes(
project_id: project_1.id,
last_job_artifact_id: nil,
refresh_started_at: nil,
state: described_class::STATES[:created]
)
expect(described_class.last).to have_attributes(
project_id: project_2.id,
last_job_artifact_id: nil,
refresh_started_at: nil,
state: described_class::STATES[:created]
)
end
end
describe '#next_batch' do
let!(:project) { create(:project) }
let!(:artifact_1) { create(:ci_job_artifact, project: project, created_at: 14.days.ago) }
let!(:artifact_2) { create(:ci_job_artifact, project: project, created_at: 13.days.ago) }
let!(:artifact_3) { create(:ci_job_artifact, project: project, created_at: 12.days.ago) }
# This should not be included in the recalculation as it is created later than the refresh start time
let!(:future_artifact) { create(:ci_job_artifact, project: project, size: 8, created_at: refresh.refresh_started_at + 1.second) }
let!(:refresh) do
create(
:project_build_artifacts_size_refresh,
:pending,
project: project,
updated_at: 2.days.ago,
refresh_started_at: 10.days.ago,
last_job_artifact_id: artifact_1.id,
last_job_artifact_id_on_refresh_start: artifact_3.id
)
end
subject(:batch) { refresh.next_batch(limit: 3) }
it 'returns the job artifact records that were created not later than the refresh_started_at and IDs greater than the last_job_artifact_id' do
expect(batch).to eq([artifact_2, artifact_3])
end
context 'when created_at is set before artifact id is persisted' do
it 'returns ordered job artifacts' do
artifact_3.update!(created_at: artifact_2.created_at)
expect(batch).to eq([artifact_2, artifact_3])
end
end
end
describe '#started?' do
using RSpec::Parameterized::TableSyntax
let_it_be(:project) { create(:project) }
subject { refresh.started? }
where(:refresh_state, :result) do
:created | false
:pending | true
:running | true
end
with_them do
let(:refresh) do
create(:project_build_artifacts_size_refresh, refresh_state, project: project)
end
it { is_expected.to eq(result) }
end
end
describe 'callbacks' do
context 'when destroyed' do
it 'enqueues a Namespaces::ScheduleAggregationWorker' do
refresh = create(:project_build_artifacts_size_refresh)
expect(Namespaces::ScheduleAggregationWorker).to receive(:perform_async).with(refresh.project.namespace_id)
refresh.destroy!
end
end
end
end
|