1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MergeRequestPolicy do
include ExternalAuthorizationServiceHelpers
let_it_be(:guest) { create(:user) }
let_it_be(:author) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:developer) { create(:user) }
let_it_be(:non_team_member) { create(:user) }
let_it_be(:bot) { create(:user, :project_bot) }
def permissions(user, merge_request)
described_class.new(user, merge_request)
end
mr_perms = %i[create_merge_request_in
create_merge_request_from
read_merge_request
update_merge_request
create_todo
approve_merge_request
create_note
update_subscription].freeze
shared_examples_for 'a denied user' do
let(:perms) { permissions(subject, merge_request) }
mr_perms.each do |thing|
it "cannot #{thing}" do
expect(perms).to be_disallowed(thing)
end
end
end
shared_examples_for 'a user with reporter access' do
using RSpec::Parameterized::TableSyntax
where(:policy, :is_allowed) do
:create_merge_request_in | true
:read_merge_request | true
:create_todo | true
:create_note | true
:update_subscription | true
:create_merge_request_from | false
:approve_merge_request | false
:update_merge_request | false
end
with_them do
specify do
is_allowed ? (is_expected.to be_allowed(policy)) : (is_expected.to be_disallowed(policy))
end
end
end
shared_examples_for 'a user with full access' do
let(:perms) { permissions(subject, merge_request) }
mr_perms.each do |thing|
it "can #{thing}" do
expect(perms).to be_allowed(thing)
end
end
end
context 'when user is a direct project member' do
let(:project) { create(:project, :public) }
before do
project.add_guest(guest)
project.add_guest(author)
project.add_developer(developer)
project.add_developer(bot)
end
context 'when merge request is public' do
let(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: user) }
let(:user) { author }
context 'and user is author' do
subject { permissions(user, merge_request) }
context 'and the user is a guest' do
let(:user) { guest }
it do
is_expected.to be_allowed(:update_merge_request)
end
it do
is_expected.to be_allowed(:reopen_merge_request)
end
it do
is_expected.to be_allowed(:approve_merge_request)
end
it do
is_expected.to be_disallowed(:reset_merge_request_approvals)
end
end
context 'and the user is a bot' do
let(:user) { bot }
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
end
end
context 'when merge requests have been disabled' do
let!(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: author) }
before do
project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED)
end
describe 'the author' do
subject { author }
it_behaves_like 'a denied user'
end
describe 'a guest' do
subject { guest }
it_behaves_like 'a denied user'
end
describe 'a developer' do
subject { developer }
it_behaves_like 'a denied user'
end
describe 'a bot' do
let(:subject) { permissions(bot, merge_request) }
it do
is_expected.to be_disallowed(:reset_merge_request_approvals)
end
end
end
context 'when merge requests are private' do
let!(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: author) }
before do
project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
project.project_feature.update!(merge_requests_access_level: ProjectFeature::PRIVATE)
end
describe 'the author' do
subject { author }
it_behaves_like 'a denied user'
end
describe 'a developer' do
subject { developer }
it_behaves_like 'a user with full access'
end
describe 'a bot' do
let(:subject) { permissions(bot, merge_request) }
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
end
context 'when merge request is unlocked' do
let(:merge_request) { create(:merge_request, :closed, source_project: project, target_project: project, author: author) }
it 'allows author to reopen merge request' do
expect(permissions(author, merge_request)).to be_allowed(:reopen_merge_request)
end
it 'allows developer to reopen merge request' do
expect(permissions(developer, merge_request)).to be_allowed(:reopen_merge_request)
end
it 'prevents guest from reopening merge request' do
expect(permissions(guest, merge_request)).to be_disallowed(:reopen_merge_request)
end
end
context 'when merge request is locked' do
let(:merge_request_locked) { create(:merge_request, :closed, discussion_locked: true, source_project: project, target_project: project, author: author) }
it 'prevents author from reopening merge request' do
expect(permissions(author, merge_request_locked)).to be_disallowed(:reopen_merge_request)
end
it 'prevents developer from reopening merge request' do
expect(permissions(developer, merge_request_locked)).to be_disallowed(:reopen_merge_request)
end
it 'prevents guests from reopening merge request' do
expect(permissions(guest, merge_request_locked)).to be_disallowed(:reopen_merge_request)
end
context 'when the user is project member, with at least guest access' do
let(:user) { guest }
it 'can create a note' do
expect(permissions(user, merge_request_locked)).to be_allowed(:create_note)
end
end
end
context 'with external authorization enabled' do
let(:user) { create(:user) }
let(:project) { create(:project, :public) }
let(:merge_request) { create(:merge_request, source_project: project) }
let(:policies) { described_class.new(user, merge_request) }
before do
enable_external_authorization_service_check
end
it 'can read the issue iid without accessing the external service' do
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
expect(policies).to be_allowed(:read_merge_request_iid)
end
end
end
context 'when user is an inherited member from the parent group' do
let_it_be(:group) { create(:group, :public) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: author) }
before_all do
group.add_guest(guest)
group.add_guest(author)
group.add_reporter(reporter)
group.add_developer(developer)
group.add_developer(bot)
end
context 'when project is public' do
let(:project) { create(:project, :public, group: group) }
describe 'the merge request author' do
subject { permissions(author, merge_request) }
it do
is_expected.to be_allowed(:approve_merge_request)
end
it do
is_expected.to be_disallowed(:reset_merge_request_approvals)
end
end
describe 'a bot' do
subject { permissions(bot, merge_request) }
it do
is_expected.to be_allowed(:approve_merge_request)
end
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
context 'and merge requests are private' do
before do
project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
project.project_feature.update!(merge_requests_access_level: ProjectFeature::PRIVATE)
end
describe 'a guest' do
subject { guest }
it_behaves_like 'a denied user'
end
describe 'a reporter' do
subject { permissions(reporter, merge_request) }
it_behaves_like 'a user with reporter access'
end
describe 'a developer' do
subject { developer }
it_behaves_like 'a user with full access'
end
describe 'a bot' do
let(:subject) { permissions(bot, merge_request) }
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
end
end
context 'when project is private' do
let(:project) { create(:project, :private, group: group) }
describe 'a guest' do
subject { guest }
it_behaves_like 'a denied user'
end
describe 'a reporter' do
subject { permissions(reporter, merge_request) }
it_behaves_like 'a user with reporter access'
end
describe 'a developer' do
subject { developer }
it_behaves_like 'a user with full access'
end
describe 'a bot' do
let(:subject) { permissions(bot, merge_request) }
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
end
end
context 'when user is an inherited member from a shared group' do
let(:project) { create(:project, :public) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: user) }
let(:user) { author }
before do
project.add_guest(author)
end
context 'and group is given developer access' do
let(:user) { non_team_member }
subject { permissions(user, merge_request) }
before do
group = create(:group)
project.project_group_links.create!(
group: group,
group_access: Gitlab::Access::DEVELOPER)
group.add_guest(non_team_member)
group.add_guest(bot)
end
it do
is_expected.to be_allowed(:approve_merge_request)
end
it do
is_expected.to be_disallowed(:reset_merge_request_approvals)
end
context 'and the user is a bot' do
let(:user) { bot }
it do
is_expected.to be_allowed(:approve_merge_request)
end
it do
is_expected.to be_allowed(:reset_merge_request_approvals)
end
end
end
end
context 'when user is not a project member' do
let(:project) { create(:project, :public) }
context 'when merge request is public' do
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
subject { permissions(non_team_member, merge_request) }
it do
is_expected.not_to be_allowed(:approve_merge_request)
end
it do
is_expected.not_to be_allowed(:reset_merge_request_approvals)
end
context 'and the user is a bot' do
subject { permissions(bot, merge_request) }
it do
is_expected.not_to be_allowed(:approve_merge_request)
end
it do
is_expected.not_to be_allowed(:reset_merge_request_approvals)
end
end
end
context 'when merge requests are disabled' do
let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
before do
project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED)
end
subject { non_team_member }
it_behaves_like 'a denied user'
end
context 'when merge requests are private' do
let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
before do
project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
project.project_feature.update!(merge_requests_access_level: ProjectFeature::PRIVATE)
end
subject { non_team_member }
it_behaves_like 'a denied user'
end
context 'when merge request is locked' do
let(:merge_request) { create(:merge_request, :closed, discussion_locked: true, source_project: project, target_project: project) }
it 'cannot create a note' do
expect(permissions(non_team_member, merge_request)).to be_disallowed(:create_note)
end
end
end
context 'when user is anonymous' do
let(:project) { create(:project, :public) }
context 'when merge request is public' do
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
subject { permissions(nil, merge_request) }
specify do
is_expected.to be_disallowed(:create_todo, :update_subscription)
end
end
end
context 'when the author of the merge request is banned', feature_category: :insider_threat do
let_it_be(:user) { create(:user) }
let_it_be(:admin) { create(:user, :admin) }
let_it_be(:author) { create(:user, :banned) }
let_it_be(:project) { create(:project, :public) }
let_it_be(:hidden_merge_request) { create(:merge_request, source_project: project, author: author) }
it 'does not allow non-admin user to read the merge_request' do
expect(permissions(user, hidden_merge_request)).not_to be_allowed(:read_merge_request)
end
it 'allows admin to read the merge_request', :enable_admin_mode do
expect(permissions(admin, hidden_merge_request)).to be_allowed(:read_merge_request)
end
context 'when the `hide_merge_requests_from_banned_users` feature flag is disabled' do
before do
stub_feature_flags(hide_merge_requests_from_banned_users: false)
end
it 'allows non-admin users to read the merge_request' do
expect(permissions(user, hidden_merge_request)).to be_allowed(:read_merge_request)
end
it 'allows admin users to read the merge_request', :enable_admin_mode do
expect(permissions(admin, hidden_merge_request)).to be_allowed(:read_merge_request)
end
end
end
end
|