1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'container repository details' do
include_context 'container registry tags'
include_context 'container registry client stubs'
using RSpec::Parameterized::TableSyntax
include GraphqlHelpers
let_it_be_with_reload(:project) { create(:project) }
let_it_be_with_reload(:container_repository) { create(:container_repository, project: project) }
let(:query) do
graphql_query_for(
'containerRepository',
{ id: container_repository_global_id },
all_graphql_fields_for('ContainerRepositoryDetails', excluded: %w[pipeline size])
)
end
let(:user) { project.first_owner }
let(:variables) { {} }
let(:tags) { %w[latest tag1 tag2 tag3 tag4 tag5] }
let(:container_repository_global_id) { container_repository.to_global_id.to_s }
let(:container_repository_details_response) { graphql_data.dig('containerRepository') }
before do
stub_container_registry_config(enabled: true)
stub_container_registry_tags(repository: container_repository.path, tags: tags, with_manifest: true)
end
subject { post_graphql(query, current_user: user, variables: variables) }
shared_examples 'returning an invalid value error' do
it 'returns an error' do
subject
expect(graphql_errors.first.dig('message')).to match(/invalid value/)
end
end
it_behaves_like 'a working graphql query' do
before do
subject
end
it 'matches the JSON schema' do
expect(container_repository_details_response).to match_schema('graphql/container_repository_details')
end
end
context 'with different permissions' do
let_it_be(:user) { create(:user) }
let(:tags_response) { container_repository_details_response.dig('tags', 'nodes') }
where(:project_visibility, :role, :access_granted, :can_delete) do
:private | :maintainer | true | true
:private | :developer | true | true
:private | :reporter | true | false
:private | :guest | false | false
:private | :anonymous | false | false
:public | :maintainer | true | true
:public | :developer | true | true
:public | :reporter | true | false
:public | :guest | true | false
:public | :anonymous | true | false
end
with_them do
before do
project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility.to_s.upcase, false))
project.add_user(user, role) unless role == :anonymous
end
it 'return the proper response' do
subject
if access_granted
expect(tags_response.size).to eq(tags.size)
expect(container_repository_details_response.dig('canDelete')).to eq(can_delete)
else
expect(container_repository_details_response).to eq(nil)
end
end
end
end
context 'with a giant size tag' do
let(:tags) { %w[latest] }
let(:giant_size) { 1.terabyte }
let(:tag_sizes_response) { graphql_data_at('containerRepository', 'tags', 'nodes', 'totalSize') }
let(:fields) do
<<~GQL
tags {
nodes {
totalSize
}
}
GQL
end
let(:query) do
graphql_query_for(
'containerRepository',
{ id: container_repository_global_id },
fields
)
end
it 'returns the expected value as a string' do
stub_next_container_registry_tags_call(:total_size, giant_size)
subject
expect(tag_sizes_response.first).to eq(giant_size.to_s)
end
end
context 'limiting the number of tags' do
let(:limit) { 2 }
let(:tags_response) { container_repository_details_response.dig('tags', 'edges') }
let(:variables) do
{ id: container_repository_global_id, n: limit }
end
let(:query) do
<<~GQL
query($id: ContainerRepositoryID!, $n: Int) {
containerRepository(id: $id) {
tags(first: $n) {
edges {
node {
#{all_graphql_fields_for('ContainerRepositoryTag')}
}
}
}
}
}
GQL
end
it 'only returns n tags' do
subject
expect(tags_response.size).to eq(limit)
end
end
context 'sorting the tags' do
let(:sort) { 'NAME_DESC' }
let(:tags_response) { container_repository_details_response.dig('tags', 'edges') }
let(:variables) do
{ id: container_repository_global_id, n: sort }
end
let(:query) do
<<~GQL
query($id: ContainerRepositoryID!, $n: ContainerRepositoryTagSort) {
containerRepository(id: $id) {
tags(sort: $n) {
edges {
node {
#{all_graphql_fields_for('ContainerRepositoryTag')}
}
}
}
}
}
GQL
end
it 'sorts the tags', :aggregate_failures do
subject
expect(tags_response.first.dig('node', 'name')).to eq('tag5')
expect(tags_response.last.dig('node', 'name')).to eq('latest')
end
context 'invalid sort' do
let(:sort) { 'FOO_ASC' }
it_behaves_like 'returning an invalid value error'
end
end
context 'filtering by name' do
let(:name) { 'l' }
let(:tags_response) { container_repository_details_response.dig('tags', 'edges') }
let(:variables) do
{ id: container_repository_global_id, n: name }
end
let(:query) do
<<~GQL
query($id: ContainerRepositoryID!, $n: String) {
containerRepository(id: $id) {
tags(name: $n) {
edges {
node {
#{all_graphql_fields_for('ContainerRepositoryTag')}
}
}
}
}
}
GQL
end
it 'sorts the tags', :aggregate_failures do
subject
expect(tags_response.size).to eq(1)
expect(tags_response.first.dig('node', 'name')).to eq('latest')
end
context 'invalid filter' do
let(:name) { 1 }
it_behaves_like 'returning an invalid value error'
end
end
context 'size field' do
let(:size_response) { container_repository_details_response.dig('size') }
let(:on_com) { true }
let(:created_at) { ::ContainerRepository::MIGRATION_PHASE_1_STARTED_AT + 3.months }
let(:variables) do
{ id: container_repository_global_id }
end
let(:query) do
<<~GQL
query($id: ContainerRepositoryID!) {
containerRepository(id: $id) {
size
}
}
GQL
end
before do
allow(::Gitlab).to receive(:com?).and_return(on_com)
container_repository.update_column(:created_at, created_at)
end
it 'returns the size' do
stub_container_registry_gitlab_api_support(supported: true) do |client|
stub_container_registry_gitlab_api_repository_details(client, path: container_repository.path, size_bytes: 12345)
end
subject
expect(size_response).to eq(12345)
end
context 'with a network error' do
it 'returns an error' do
stub_container_registry_gitlab_api_network_error
subject
expect_graphql_errors_to_include("Can't connect to the Container Registry. If this error persists, please review the troubleshooting documentation.")
end
end
context 'with not supporting the gitlab api' do
it 'returns nil' do
stub_container_registry_gitlab_api_support(supported: false)
subject
expect(size_response).to eq(nil)
end
end
context 'not on .com' do
let(:on_com) { false }
it 'returns nil' do
subject
expect(size_response).to eq(nil)
end
end
context 'with an older container repository' do
let(:created_at) { ::ContainerRepository::MIGRATION_PHASE_1_STARTED_AT - 3.months }
it 'returns nil' do
subject
expect(size_response).to eq(nil)
end
end
end
context 'with tags with a manifest containing nil fields' do
let(:tags_response) { container_repository_details_response.dig('tags', 'nodes') }
let(:errors) { container_repository_details_response.dig('errors') }
%i[digest revision short_revision total_size created_at].each do |nilable_field|
it "returns a list of tags with a nil #{nilable_field}" do
stub_next_container_registry_tags_call(nilable_field, nil)
subject
expect(tags_response.size).to eq(tags.size)
expect(graphql_errors).to eq(nil)
end
end
end
it_behaves_like 'handling graphql network errors with the container registry'
end
|