1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::RpmProjectPackages do
include HttpBasicAuthHelpers
include WorkhorseHelpers
include_context 'workhorse headers'
using RSpec::Parameterized::TableSyntax
let_it_be(:group) { create(:group, :public) }
let_it_be_with_reload(:project) { create(:project, :public, group: group) }
let_it_be(:user) { create(:user) }
let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
let_it_be(:deploy_token) { create(:deploy_token, read_package_registry: true, write_package_registry: true) }
let_it_be(:project_deploy_token) { create(:project_deploy_token, deploy_token: deploy_token, project: project) }
let_it_be(:job) { create(:ci_build, :running, user: user, project: project) }
let(:headers) { {} }
let(:package_name) { 'rpm-package.0-1.x86_64.rpm' }
let(:package_file_id) { 1 }
shared_examples 'rejects rpm packages access' do |status|
it_behaves_like 'returning response status', status
if status == :unauthorized
it 'has the correct response header' do
subject
expect(response.headers['WWW-Authenticate']).to eq 'Basic realm="GitLab Packages Registry"'
end
end
end
shared_examples 'process rpm packages upload/download' do |status|
it_behaves_like 'returning response status', status
end
shared_examples 'a deploy token for RPM requests' do |success_status = :not_found|
context 'with deploy token headers' do
before do
project.update_column(:visibility_level, Gitlab::VisibilityLevel::PRIVATE)
end
let(:headers) { basic_auth_header(deploy_token.username, deploy_token.token) }
context 'when token is valid' do
it_behaves_like 'returning response status', success_status
end
context 'when token is invalid' do
let(:headers) { basic_auth_header(deploy_token.username, 'bar') }
it_behaves_like 'returning response status', :unauthorized
end
end
end
shared_examples 'a job token for RPM requests' do |success_status = :not_found|
context 'with job token headers' do
let(:headers) { basic_auth_header(::Gitlab::Auth::CI_JOB_USER, job.token) }
before do
project.update_column(:visibility_level, Gitlab::VisibilityLevel::PRIVATE)
project.add_developer(user)
end
context 'with valid token' do
it_behaves_like 'returning response status', success_status
end
context 'with invalid token' do
let(:headers) { basic_auth_header(::Gitlab::Auth::CI_JOB_USER, 'bar') }
it_behaves_like 'returning response status', :unauthorized
end
context 'with invalid user' do
let(:headers) { basic_auth_header('foo', job.token) }
it_behaves_like 'returning response status', :unauthorized
end
end
end
shared_examples 'a user token for RPM requests' do |success_status = :not_found|
context 'with valid project' do
where(:visibility_level, :user_role, :member, :user_token, :shared_examples_name, :expected_status) do
'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | success_status
'PUBLIC' | :guest | true | true | 'process rpm packages upload/download' | :forbidden
'PUBLIC' | :developer | true | false | 'rejects rpm packages access' | :unauthorized
'PUBLIC' | :guest | true | false | 'rejects rpm packages access' | :unauthorized
'PUBLIC' | :developer | false | true | 'process rpm packages upload/download' | :not_found
'PUBLIC' | :guest | false | true | 'process rpm packages upload/download' | :not_found
'PUBLIC' | :developer | false | false | 'rejects rpm packages access' | :unauthorized
'PUBLIC' | :guest | false | false | 'rejects rpm packages access' | :unauthorized
'PUBLIC' | :anonymous | false | true | 'process rpm packages upload/download' | :unauthorized
'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | success_status
'PRIVATE' | :guest | true | true | 'rejects rpm packages access' | :forbidden
'PRIVATE' | :developer | true | false | 'rejects rpm packages access' | :unauthorized
'PRIVATE' | :guest | true | false | 'rejects rpm packages access' | :unauthorized
'PRIVATE' | :developer | false | true | 'rejects rpm packages access' | :not_found
'PRIVATE' | :guest | false | true | 'rejects rpm packages access' | :not_found
'PRIVATE' | :developer | false | false | 'rejects rpm packages access' | :unauthorized
'PRIVATE' | :guest | false | false | 'rejects rpm packages access' | :unauthorized
'PRIVATE' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized
end
with_them do
let(:token) { user_token ? personal_access_token.token : 'wrong' }
let(:headers) { user_role == :anonymous ? {} : basic_auth_header(user.username, token) }
subject { get api(url), headers: headers }
before do
project.update_column(:visibility_level, Gitlab::VisibilityLevel.level_value(visibility_level))
project.send("add_#{user_role}", user) if member && user_role != :anonymous
end
it_behaves_like params[:shared_examples_name], params[:expected_status]
end
end
end
describe 'GET /api/v4/projects/:project_id/packages/rpm/repodata/:filename' do
let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } }
let(:repository_file) { create(:rpm_repository_file, project: project) }
let(:url) { "/projects/#{project.id}/packages/rpm/repodata/#{repository_file.file_name}" }
subject { get api(url), headers: headers }
it_behaves_like 'a job token for RPM requests', :success
it_behaves_like 'a deploy token for RPM requests', :success
it_behaves_like 'a user token for RPM requests', :success
end
describe 'GET /api/v4/projects/:id/packages/rpm/:package_file_id/:filename' do
let(:snowplow_gitlab_standard_context) { { project: project, namespace: group } }
let(:url) { "/projects/#{project.id}/packages/rpm/#{package_file_id}/#{package_name}" }
subject { get api(url), headers: headers }
it_behaves_like 'a package tracking event', described_class.name, 'pull_package'
it_behaves_like 'a job token for RPM requests'
it_behaves_like 'a deploy token for RPM requests'
it_behaves_like 'a user token for RPM requests'
end
describe 'POST /api/v4/projects/:project_id/packages/rpm' do
let(:snowplow_gitlab_standard_context) { { project: project, namespace: group, user: user } }
let(:url) { "/projects/#{project.id}/packages/rpm" }
let(:file_upload) { fixture_file_upload('spec/fixtures/packages/rpm/hello-0.0.1-1.fc29.x86_64.rpm') }
subject { post api(url), params: { file: file_upload }, headers: headers }
context 'with user token' do
context 'with valid project' do
where(:visibility_level, :user_role, :member, :user_token, :shared_examples_name, :expected_status, :tracked) do
'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | :not_found | true
'PUBLIC' | :guest | true | true | 'rejects rpm packages access' | :forbidden | false
'PUBLIC' | :developer | true | false | 'rejects rpm packages access' | :unauthorized | false
'PUBLIC' | :guest | true | false | 'rejects rpm packages access' | :unauthorized | false
'PUBLIC' | :developer | false | true | 'rejects rpm packages access' | :not_found | false
'PUBLIC' | :guest | false | true | 'rejects rpm packages access' | :not_found | false
'PUBLIC' | :developer | false | false | 'rejects rpm packages access' | :unauthorized | false
'PUBLIC' | :guest | false | false | 'rejects rpm packages access' | :unauthorized | false
'PUBLIC' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized | false
'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | :not_found | true
'PRIVATE' | :guest | true | true | 'rejects rpm packages access' | :forbidden | false
'PRIVATE' | :developer | true | false | 'rejects rpm packages access' | :unauthorized | false
'PRIVATE' | :guest | true | false | 'rejects rpm packages access' | :unauthorized | false
'PRIVATE' | :developer | false | true | 'rejects rpm packages access' | :not_found | false
'PRIVATE' | :guest | false | true | 'rejects rpm packages access' | :not_found | false
'PRIVATE' | :developer | false | false | 'rejects rpm packages access' | :unauthorized | false
'PRIVATE' | :guest | false | false | 'rejects rpm packages access' | :unauthorized | false
'PRIVATE' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized | false
end
with_them do
let(:token) { user_token ? personal_access_token.token : 'wrong' }
let(:headers) { user_role == :anonymous ? {} : basic_auth_header(user.username, token) }
before do
project.update_column(:visibility_level, Gitlab::VisibilityLevel.level_value(visibility_level))
project.send("add_#{user_role}", user) if member && user_role != :anonymous
end
tracking_example = params[:tracked] ? 'a package tracking event' : 'not a package tracking event'
it_behaves_like tracking_example, described_class.name, 'push_package'
it_behaves_like params[:shared_examples_name], params[:expected_status]
end
end
context 'when user can upload file' do
before do
project.add_developer(user)
end
let(:headers) { basic_auth_header(user.username, personal_access_token.token).merge(workhorse_headers) }
context 'when file size too large' do
before do
allow_next_instance_of(UploadedFile) do |uploaded_file|
allow(uploaded_file).to receive(:size).and_return(project.actual_limits.rpm_max_file_size + 1)
end
end
it 'returns an error' do
upload_file(params: { file: file_upload }, request_headers: headers)
expect(response).to have_gitlab_http_status(:bad_request)
expect(response.body).to match(/File is too large/)
end
end
end
def upload_file(params: {}, request_headers: headers)
url = "/projects/#{project.id}/packages/rpm"
workhorse_finalize(
api(url),
method: :post,
file_key: :file,
params: params,
headers: request_headers,
send_rewritten_field: true
)
end
end
it_behaves_like 'a deploy token for RPM requests'
it_behaves_like 'a job token for RPM requests'
end
describe 'POST /api/v4/projects/:project_id/packages/rpm/authorize' do
let(:url) { api("/projects/#{project.id}/packages/rpm/authorize") }
subject { post(url, headers: headers) }
it_behaves_like 'returning response status', :not_found
context 'when feature flag is disabled' do
before do
stub_feature_flags(rpm_packages: false)
end
it_behaves_like 'returning response status', :not_found
end
context 'when package feature is disabled' do
before do
stub_config(packages: { enabled: false })
end
it_behaves_like 'returning response status', :not_found
end
end
end
|