blob: 9be013d4385c0b28e8c98a182d7b31d5f02b8efa (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Groups::ObservabilityController do
include ContentSecurityPolicyHelpers
let_it_be(:group) { create(:group) }
let_it_be(:user) { create(:user) }
subject do
get group_observability_index_path(group)
response
end
describe 'GET #index' do
context 'when user is not authenticated' do
it 'returns 404' do
expect(subject).to have_gitlab_http_status(:not_found)
end
end
context 'when observability url is missing' do
before do
allow(described_class).to receive(:observability_url).and_return("")
end
it 'returns 404' do
expect(subject).to have_gitlab_http_status(:not_found)
end
end
context 'when user is not a developer' do
before do
sign_in(user)
end
it 'returns 404' do
expect(subject).to have_gitlab_http_status(:not_found)
end
end
context 'when user is authenticated and a developer' do
before do
sign_in(user)
group.add_developer(user)
end
it 'returns 200' do
expect(subject).to have_gitlab_http_status(:ok)
end
it 'renders the proper layout' do
expect(subject).to render_template("layouts/group")
expect(subject).to render_template("layouts/fullscreen")
expect(subject).not_to render_template('layouts/nav/breadcrumbs')
expect(subject).to render_template("nav/sidebar/_group")
end
describe 'iframe' do
subject do
get group_observability_index_path(group)
Nokogiri::HTML.parse(response.body).at_css('iframe#observability-ui-iframe')
end
it 'sets the iframe src to the proper URL' do
expect(subject.attributes['src'].value).to eq("https://observe.gitlab.com/-/#{group.id}")
end
it 'when the env is staging, sets the iframe src to the proper URL' do
stub_config_setting(url: Gitlab::Saas.staging_com_url)
expect(subject.attributes['src'].value).to eq("https://staging.observe.gitlab.com/-/#{group.id}")
end
it 'overrides the iframe src url if specified by OVERRIDE_OBSERVABILITY_URL env' do
stub_env('OVERRIDE_OBSERVABILITY_URL', 'http://foo.test')
expect(subject.attributes['src'].value).to eq("http://foo.test/-/#{group.id}")
end
end
describe 'CSP' do
before do
setup_existing_csp_for_controller(described_class, csp)
end
subject do
get group_observability_index_path(group)
response.headers['Content-Security-Policy']
end
context 'when there is no CSP config' do
let(:csp) { ActionDispatch::ContentSecurityPolicy.new }
it 'does not add any csp header' do
expect(subject).to be_blank
end
end
context 'when frame-src exists in the CSP config' do
let(:csp) do
ActionDispatch::ContentSecurityPolicy.new do |p|
p.frame_src 'https://something.test'
end
end
it 'appends the proper url to frame-src CSP directives' do
expect(subject).to include(
"frame-src https://something.test https://observe.gitlab.com 'self'")
end
it 'appends the proper url to frame-src CSP directives when Gilab.staging?' do
stub_config_setting(url: Gitlab::Saas.staging_com_url)
expect(subject).to include(
"frame-src https://something.test https://staging.observe.gitlab.com 'self'")
end
it 'appends the proper url to frame-src CSP directives when OVERRIDE_OBSERVABILITY_URL is specified' do
stub_env('OVERRIDE_OBSERVABILITY_URL', 'http://foo.test')
expect(subject).to include(
"frame-src https://something.test http://foo.test 'self'")
end
end
context 'when self is already present in the policy' do
let(:csp) do
ActionDispatch::ContentSecurityPolicy.new do |p|
p.frame_src "'self'"
end
end
it 'does not append self again' do
expect(subject).to include(
"frame-src 'self' https://observe.gitlab.com;")
end
end
context 'when default-src exists in the CSP config' do
let(:csp) do
ActionDispatch::ContentSecurityPolicy.new do |p|
p.default_src 'https://something.test'
end
end
it 'does not change default-src' do
expect(subject).to include(
"default-src https://something.test;")
end
it 'appends the proper url to frame-src CSP directives' do
expect(subject).to include(
"frame-src https://something.test https://observe.gitlab.com 'self'")
end
it 'appends the proper url to frame-src CSP directives when Gilab.staging?' do
stub_config_setting(url: Gitlab::Saas.staging_com_url)
expect(subject).to include(
"frame-src https://something.test https://staging.observe.gitlab.com 'self'")
end
it 'appends the proper url to frame-src CSP directives when OVERRIDE_OBSERVABILITY_URL is specified' do
stub_env('OVERRIDE_OBSERVABILITY_URL', 'http://foo.test')
expect(subject).to include(
"frame-src https://something.test http://foo.test 'self'")
end
end
context 'when frame-src and default-src exist in the CSP config' do
let(:csp) do
ActionDispatch::ContentSecurityPolicy.new do |p|
p.default_src 'https://something_default.test'
p.frame_src 'https://something.test'
end
end
it 'appends to frame-src CSP directives' do
expect(subject).to include(
"frame-src https://something.test https://observe.gitlab.com 'self'")
expect(subject).to include(
"default-src https://something_default.test")
end
end
end
end
end
end
|
