blob: feb85c354efd7c31fc424b546196cf90c87cd9e1 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
|
# frozen_string_literal: true
require 'spec_helper'
require 'rubocop'
require 'rubocop/rspec/support'
require_relative '../../../rubocop/cop/avoid_break_from_strong_memoize'
describe RuboCop::Cop::AvoidBreakFromStrongMemoize do
include CopHelper
subject(:cop) { described_class.new }
it 'flags violation for break inside strong_memoize' do
expect_offense(<<~RUBY)
strong_memoize(:result) do
break if something
^^^^^ Do not use break inside strong_memoize, use next instead.
do_an_heavy_calculation
end
RUBY
end
it 'flags violation for break inside strong_memoize nested blocks' do
expect_offense(<<~RUBY)
strong_memoize do
items.each do |item|
break item
^^^^^^^^^^ Do not use break inside strong_memoize, use next instead.
end
end
RUBY
end
it "doesn't flag violation for next inside strong_memoize" do
expect_no_offenses(<<~RUBY)
strong_memoize(:result) do
next if something
do_an_heavy_calculation
end
RUBY
end
it "doesn't flag violation for break inside blocks" do
expect_no_offenses(<<~RUBY)
call do
break if something
do_an_heavy_calculation
end
RUBY
end
it "doesn't call add_offense twice for nested blocks" do
source = <<~RUBY
call do
strong_memoize(:result) do
break if something
do_an_heavy_calculation
end
end
RUBY
expect_next_instance_of(described_class) do |instance|
expect(instance).to receive(:add_offense).once
end
inspect_source(source)
end
it "doesn't check when block is empty" do
expect_no_offenses(<<~RUBY)
strong_memoize(:result) do
end
RUBY
end
end
|
