blob: 071ddcf8b7d66835b7533cc2f785fa106589dd18 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
|
# frozen_string_literal: true
require 'fast_spec_helper'
require 'rubocop'
require_relative '../../../../rubocop/cop/gitlab/predicate_memoization'
RSpec.describe RuboCop::Cop::Gitlab::PredicateMemoization do
subject(:cop) { described_class.new }
shared_examples('not registering offense') do
it 'does not register offenses' do
expect_no_offenses(source)
end
end
context 'when source is a predicate method using ivar with assignment' do
it_behaves_like 'not registering offense' do
let(:source) do
<<~RUBY
class C
def really?
@really = true
end
end
RUBY
end
end
end
context 'when source is a predicate method using local with ||=' do
it_behaves_like 'not registering offense' do
let(:source) do
<<~RUBY
class C
def really?
really ||= true
end
end
RUBY
end
end
end
context 'when source is a regular method memoizing via ivar' do
it_behaves_like 'not registering offense' do
let(:source) do
<<~RUBY
class C
def really
@really ||= true
end
end
RUBY
end
end
end
context 'when source is a predicate method memoizing via ivar' do
let(:msg) { "Avoid using `@value ||= query` [...]" }
context 'when assigning to boolean' do
it 'registers an offense' do
node = "@really ||= true"
expect_offense(<<~CODE, node: node, msg: msg)
class C
def really?
%{node}
^{node} %{msg}
end
end
CODE
end
end
context 'when assigning to another variable that is a boolean' do
it 'registers an offense' do
node = "@really ||= value"
expect_offense(<<~CODE, node: node, msg: msg)
class C
def really?
value = true
%{node}
^{node} %{msg}
end
end
CODE
end
end
end
end
|