spec/rubocop/cop/graphql/authorize_types_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95

# frozen_string_literal: true

require 'fast_spec_helper'

require_relative '../../../../rubocop/cop/graphql/authorize_types'

RSpec.describe RuboCop::Cop::Graphql::AuthorizeTypes do
  subject(:cop) { described_class.new }

  it 'adds an offense when there is no authorize call' do
    expect_offense(<<~TYPE)
      module Types
        class AType < BaseObject
        ^^^^^^^^^^^^^^^^^^^^^^^^ Add an `authorize :ability` call to the type: https://docs.gitlab.com/ee/development/graphql_guide/authorization.html#type-authorization
          field :a_thing
          field :another_thing
        end
      end
    TYPE
  end

  it 'does not add an offense for classes that have an authorize call' do
    expect_no_offenses(<<~TYPE.strip)
      module Types
        class AType < BaseObject
          graphql_name 'ATypeName'

          authorize :an_ability, :second_ability

          field :a_thing
        end
      end
    TYPE
  end

  it 'does not add an offense for classes that only have an authorize call' do
    expect_no_offenses(<<~TYPE.strip)
      module Types
        class AType < SuperClassWithFields
          authorize :an_ability
        end
      end
    TYPE
  end

  it 'does not add an offense for base types' do
    expect_no_offenses(<<~TYPE)
      module Types
        class AType < BaseEnum
          field :a_thing
        end
      end
    TYPE
  end

  it 'does not add an offense for Enums' do
    expect_no_offenses(<<~TYPE)
      module Types
        class ATypeEnum < AnotherEnum
          field :a_thing
        end
      end
    TYPE
  end

  it 'does not add an offense for subtypes of BaseUnion' do
    expect_no_offenses(<<~TYPE)
      module Types
        class AType < BaseUnion
          possible_types Types::Foo, Types::Bar
        end
      end
    TYPE
  end

  it 'does not add an offense for subtypes of BaseInputObject' do
    expect_no_offenses(<<~TYPE)
      module Types
        class AType < BaseInputObject
          argument :a_thing
        end
      end
    TYPE
  end

  it 'does not add an offense for InputTypes' do
    expect_no_offenses(<<~TYPE)
      module Types
        class AInputType < SomeObjectType
          argument :a_thing
        end
      end
    TYPE
  end
end