spec/rubocop/cop/put_group_routes_under_scope_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48

# frozen_string_literal: true

require 'spec_helper'
require 'rubocop'
require_relative '../../../rubocop/cop/put_group_routes_under_scope'

describe RuboCop::Cop::PutGroupRoutesUnderScope do
  include CopHelper

  subject(:cop) { described_class.new }

  before do
    allow(cop).to receive(:in_group_routes?).and_return(true)
  end

  it 'registers an offense when route is outside scope' do
    expect_offense(<<~PATTERN)
      scope(path: 'groups/*group_id/-', module: :groups) do
        resource :issues
      end

      resource :notes
      ^^^^^^^^^^^^^^^ Put new group routes under /-/ scope
    PATTERN
  end

  it 'does not register an offense when resource inside the scope' do
    expect_no_offenses(<<~PATTERN)
      scope(path: 'groups/*group_id/-', module: :groups) do
        resource :issues
        resource :notes
      end
    PATTERN
  end

  it 'does not register an offense when resource is deep inside the scope' do
    expect_no_offenses(<<~PATTERN)
      scope(path: 'groups/*group_id/-', module: :groups) do
        resource :issues
        resource :projects do
          resource :issues do
            resource :notes
          end
        end
      end
    PATTERN
  end
end