blob: a19ddf9dbe6694f505a0816e2229b1e71bc5a6f5 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
|
# frozen_string_literal: true
require 'fast_spec_helper'
require 'rubocop'
require_relative '../../../../rubocop/cop/scalability/bulk_perform_with_context'
RSpec.describe RuboCop::Cop::Scalability::BulkPerformWithContext do
subject(:cop) { described_class.new }
it "adds an offense when calling bulk_perform_async" do
expect_offense(<<~CODE)
Worker.bulk_perform_async(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `Worker.bulk_perform_async_with_contexts` [...]
CODE
end
it "adds an offense when calling bulk_perform_in" do
expect_offense(<<~CODE)
diffs.each_batch(of: BATCH_SIZE) do |relation, index|
ids = relation.pluck_primary_key.map { |id| [id] }
DeleteDiffFilesWorker.bulk_perform_in(index * 5.minutes, ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `Worker.bulk_perform_async_with_contexts` [...]
end
CODE
end
it "does not add an offense for migrations" do
allow(cop).to receive(:in_migration?).and_return(true)
expect_no_offenses(<<~CODE)
Worker.bulk_perform_in(args)
CODE
end
it "does not add an offence for specs" do
allow(cop).to receive(:in_spec?).and_return(true)
expect_no_offenses(<<~CODE)
Worker.bulk_perform_in(args)
CODE
end
it "does not add an offense for scheduling BackgroundMigrations" do
expect_no_offenses(<<~CODE)
BackgroundMigrationWorker.bulk_perform_in(args)
CODE
end
end
|