1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe IssueEntity do
include Gitlab::Routing.url_helpers
let(:project) { create(:project) }
let(:resource) { create(:issue, project: project) }
let(:user) { create(:user) }
let(:request) { double('request', current_user: user) }
subject { described_class.new(resource, request: request).as_json }
describe 'web_url' do
context 'when issue is of type task' do
let(:resource) { create(:issue, :task, project: project) }
context 'when use_iid_in_work_items_path feature flag is disabled' do
before do
stub_feature_flags(use_iid_in_work_items_path: false)
end
# This was already a path and not a url when the work items change was introduced
it 'has a work item path' do
expect(subject[:web_url]).to eq(project_work_items_path(project, resource.id))
end
end
it 'has a work item path with iid' do
expect(subject[:web_url]).to eq(project_work_items_path(project, resource.iid, iid_path: true))
end
end
end
describe 'type' do
it 'has an issue type' do
expect(subject[:type]).to eq('ISSUE')
end
end
it 'has Issuable attributes' do
expect(subject).to include(:id, :iid, :author_id, :description, :lock_version, :milestone_id,
:title, :updated_by_id, :created_at, :updated_at, :milestone, :labels)
end
it 'has time estimation attributes' do
expect(subject).to include(:time_estimate, :total_time_spent, :human_time_estimate, :human_total_time_spent)
end
describe 'current_user' do
it 'has the exprected permissions' do
expect(subject[:current_user]).to include(:can_create_note, :can_update, :can_set_issue_metadata,
:can_award_emoji)
end
end
context 'when issue got moved' do
let(:public_project) { create(:project, :public) }
let(:member) { create(:user) }
let(:non_member) { create(:user) }
let(:issue) { create(:issue, project: public_project) }
before do
project.add_developer(member)
public_project.add_developer(member)
Issues::MoveService.new(project: public_project, current_user: member).execute(issue, project)
end
context 'when user cannot read target project' do
it 'does not return moved_to_id' do
request = double('request', current_user: non_member)
response = described_class.new(issue, request: request).as_json
expect(response[:moved_to_id]).to be_nil
end
end
context 'when user can read target project' do
it 'returns moved moved_to_id' do
request = double('request', current_user: member)
response = described_class.new(issue, request: request).as_json
expect(response[:moved_to_id]).to eq(issue.moved_to_id)
end
end
end
context 'when issue got duplicated' do
let(:private_project) { create(:project, :private) }
let(:member) { create(:user) }
let(:issue) { create(:issue, project: project) }
let(:new_issue) { create(:issue, project: private_project) }
before do
Issues::DuplicateService
.new(project: project, current_user: member)
.execute(issue, new_issue)
end
context 'when user cannot read new issue' do
let(:non_member) { create(:user) }
it 'does not return duplicated_to_id' do
request = double('request', current_user: non_member)
response = described_class.new(issue, request: request).as_json
expect(response[:duplicated_to_id]).to be_nil
end
end
context 'when user can read target project' do
before do
project.add_developer(member)
private_project.add_developer(member)
end
it 'returns duplicated duplicated_to_id' do
request = double('request', current_user: member)
response = described_class.new(issue, request: request).as_json
expect(response[:duplicated_to_id]).to eq(issue.duplicated_to_id)
end
end
end
context 'when issuable in active or archived project' do
before do
project.add_developer(user)
end
context 'when project is active' do
it 'returns archived false' do
expect(subject[:is_project_archived]).to eq(false)
end
it 'returns nil for archived project doc' do
response = described_class.new(resource, request: request).as_json
expect(response[:archived_project_docs_path]).to be nil
end
end
context 'when project is archived' do
before do
project.update!(archived: true)
end
it 'returns archived true' do
expect(subject[:is_project_archived]).to eq(true)
end
it 'returns archived project doc' do
expect(subject[:archived_project_docs_path]).to eq('/help/user/project/settings/index.md#archive-a-project')
end
end
end
it_behaves_like 'issuable entity current_user properties'
end
|
