1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::JobArtifacts::DestroyBatchService do
let(:artifacts) { Ci::JobArtifact.where(id: [artifact_with_file.id, artifact_without_file.id]) }
let(:service) { described_class.new(artifacts, pick_up_at: Time.current) }
let_it_be(:artifact_with_file, refind: true) do
create(:ci_job_artifact, :zip)
end
let_it_be(:artifact_without_file, refind: true) do
create(:ci_job_artifact)
end
let_it_be(:undeleted_artifact, refind: true) do
create(:ci_job_artifact)
end
describe '.execute' do
subject(:execute) { service.execute }
it 'creates a deleted object for artifact with attached file' do
expect { subject }.to change { Ci::DeletedObject.count }.by(1)
end
it 'does not remove the attached file' do
expect { execute }.not_to change { artifact_with_file.file.exists? }
end
it 'deletes the artifact records' do
expect { subject }.to change { Ci::JobArtifact.count }.by(-2)
end
it 'reports metrics for destroyed artifacts' do
expect_next_instance_of(Gitlab::Ci::Artifacts::Metrics) do |metrics|
expect(metrics).to receive(:increment_destroyed_artifacts_count).with(2).and_call_original
expect(metrics).to receive(:increment_destroyed_artifacts_bytes).with(107464).and_call_original
end
execute
end
context 'ProjectStatistics' do
it 'resets project statistics' do
expect(ProjectStatistics).to receive(:increment_statistic).once
.with(artifact_with_file.project, :build_artifacts_size, -artifact_with_file.file.size)
.and_call_original
expect(ProjectStatistics).to receive(:increment_statistic).once
.with(artifact_without_file.project, :build_artifacts_size, 0)
.and_call_original
execute
end
context 'with update_stats: false' do
it 'does not update project statistics' do
expect(ProjectStatistics).not_to receive(:increment_statistic)
service.execute(update_stats: false)
end
it 'returns size statistics' do
expected_updates = {
statistics_updates: {
artifact_with_file.project => -artifact_with_file.file.size,
artifact_without_file.project => 0
}
}
expect(service.execute(update_stats: false)).to match(
a_hash_including(expected_updates))
end
end
end
context 'when failed to destroy artifact' do
context 'when the import fails' do
before do
expect(Ci::DeletedObject)
.to receive(:bulk_import)
.once
.and_raise(ActiveRecord::RecordNotDestroyed)
end
it 'raises an exception and stop destroying' do
expect { execute }.to raise_error(ActiveRecord::RecordNotDestroyed)
.and not_change { Ci::JobArtifact.count }
end
end
end
context 'when there are no artifacts' do
let(:artifacts) { Ci::JobArtifact.none }
it 'does not raise error' do
expect { execute }.not_to raise_error
end
it 'reports the number of destroyed artifacts' do
is_expected.to eq(destroyed_artifacts_count: 0, statistics_updates: {}, status: :success)
end
end
context 'with artifacts that has backfilled expire_at' do
let!(:created_on_00_30_45_minutes_on_21_22_23) do
[
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-21 00:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-21 01:30:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-22 12:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-22 12:30:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-23 23:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-23 23:30:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-23 06:45:00.000'))
]
end
let!(:created_close_to_00_or_30_minutes) do
[
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-21 00:00:00.001')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-21 00:30:00.999'))
]
end
let!(:created_on_00_or_30_minutes_on_other_dates) do
[
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-01 00:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-19 12:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-24 23:30:00.000'))
]
end
let!(:created_at_other_times) do
[
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-19 00:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-19 00:30:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-24 00:00:00.000')),
create(:ci_job_artifact, expire_at: Time.zone.parse('2022-01-24 00:30:00.000'))
]
end
let(:artifacts_to_keep) { created_on_00_30_45_minutes_on_21_22_23 }
let(:artifacts_to_delete) { created_close_to_00_or_30_minutes + created_on_00_or_30_minutes_on_other_dates + created_at_other_times }
let(:all_artifacts) { artifacts_to_keep + artifacts_to_delete }
let(:artifacts) { Ci::JobArtifact.where(id: all_artifacts.map(&:id)) }
it 'deletes job artifacts that do not have expire_at on 00, 30 or 45 minute of 21, 22, 23 of the month' do
expect { subject }.to change { Ci::JobArtifact.count }.by(artifacts_to_delete.size * -1)
end
it 'keeps job artifacts that have expire_at on 00, 30 or 45 minute of 21, 22, 23 of the month' do
expect { subject }.not_to change { Ci::JobArtifact.where(id: artifacts_to_keep.map(&:id)).count }
end
it 'removes expire_at on job artifacts that have expire_at on 00, 30 or 45 minute of 21, 22, 23 of the month' do
subject
expect(artifacts_to_keep.all? { |artifact| artifact.reload.expire_at.nil? }).to be(true)
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(ci_detect_wrongly_expired_artifacts: false)
end
it 'deletes all job artifacts' do
expect { subject }.to change { Ci::JobArtifact.count }.by(all_artifacts.size * -1)
end
end
context 'when fix_expire_at is false' do
let(:service) { described_class.new(artifacts, pick_up_at: Time.current, fix_expire_at: false) }
it 'deletes all job artifacts' do
expect { subject }.to change { Ci::JobArtifact.count }.by(all_artifacts.size * -1)
end
end
end
end
end
|