summaryrefslogtreecommitdiff
path: root/spec/services/members/destroy_service_spec.rb
blob: 9ab7839430c6e86197621ade062e019bab1a6adb (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
require 'spec_helper'

describe Members::DestroyService, services: true do
  let(:user) { create(:user) }
  let(:member_user) { create(:user) }
  let(:project) { create(:empty_project, :public) }
  let(:group) { create(:group, :public) }

  shared_examples 'a service raising ActiveRecord::RecordNotFound' do
    it 'raises ActiveRecord::RecordNotFound' do
      expect { described_class.new(source, user, params).execute }.to raise_error(ActiveRecord::RecordNotFound)
    end
  end

  shared_examples 'a service raising Gitlab::Access::AccessDeniedError' do
    it 'raises Gitlab::Access::AccessDeniedError' do
      expect { described_class.new(source, user, params).execute }.to raise_error(Gitlab::Access::AccessDeniedError)
    end
  end

  shared_examples 'a service destroying a member' do
    it 'destroys the member' do
      expect { described_class.new(source, user, params).execute }.to change { source.members.count }.by(-1)
    end

    context 'when the given member is an access requester' do
      before do
        source.members.find_by(user_id: member_user).destroy
        source.update_attributes(request_access_enabled: true)
        source.request_access(member_user)
      end
      let(:access_requester) { source.requesters.find_by(user_id: member_user) }

      it_behaves_like 'a service raising ActiveRecord::RecordNotFound'

      %i[requesters all].each do |scope|
        context "and #{scope} scope is passed" do
          it 'destroys the access requester' do
            expect { described_class.new(source, user, params).execute(scope) }.to change { source.requesters.count }.by(-1)
          end

          it 'calls Member#after_decline_request' do
            expect_any_instance_of(NotificationService).to receive(:decline_access_request).with(access_requester)

            described_class.new(source, user, params).execute(scope)
          end

          context 'when current user is the member' do
            it 'does not call Member#after_decline_request' do
              expect_any_instance_of(NotificationService).not_to receive(:decline_access_request).with(access_requester)

              described_class.new(source, member_user, params).execute(scope)
            end
          end
        end
      end
    end
  end

  context 'when no member are found' do
    let(:params) { { user_id: 42 } }

    it_behaves_like 'a service raising ActiveRecord::RecordNotFound' do
      let(:source) { project }
    end

    it_behaves_like 'a service raising ActiveRecord::RecordNotFound' do
      let(:source) { group }
    end
  end

  context 'when a member is found' do
    before do
      project.team << [member_user, :developer]
      group.add_developer(member_user)
    end
    let(:params) { { user_id: member_user.id } }

    context 'when current user cannot destroy the given member' do
      it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
        let(:source) { project }
      end

      it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
        let(:source) { group }
      end
    end

    context 'when current user can destroy the given member' do
      before do
        project.team << [user, :master]
        group.add_owner(user)
      end

      it_behaves_like 'a service destroying a member' do
        let(:source) { project }
      end

      it_behaves_like 'a service destroying a member' do
        let(:source) { group }
      end

      context 'when given a :id' do
        let(:params) { { id: project.members.find_by!(user_id: user.id).id } }

        it 'destroys the member' do
          expect { described_class.new(project, user, params).execute }
            .to change { project.members.count }.by(-1)
        end
      end
    end
  end
end