summaryrefslogtreecommitdiff
path: root/spec/services/merge_requests/rebase_service_spec.rb
blob: d1b37cdd073687348d4eac67072ced776023ef0f (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
require 'spec_helper'

describe MergeRequests::RebaseService do
  include ProjectForksHelper

  let(:user) { create(:user) }
  let(:merge_request) do
    create(:merge_request,
           source_branch: 'feature_conflict',
           target_branch: 'master')
  end
  let(:project) { merge_request.project }
  let(:repository) { project.repository.raw }

  subject(:service) { described_class.new(project, user, {}) }

  before do
    project.add_master(user)
  end

  describe '#execute' do
    context 'when another rebase is already in progress' do
      before do
        allow(merge_request).to receive(:rebase_in_progress?).and_return(true)
      end

      it 'saves the error message' do
        subject.execute(merge_request)

        expect(merge_request.reload.merge_error).to eq 'Rebase task canceled: Another rebase is already in progress'
      end

      it 'returns an error' do
        expect(service.execute(merge_request)).to match(status: :error,
                                                        message: 'Failed to rebase. Should be done manually')
      end
    end

    context 'when unexpected error occurs' do
      before do
        allow(repository).to receive(:run_git!).and_raise('Something went wrong')
      end

      it 'saves the error message' do
        subject.execute(merge_request)

        expect(merge_request.reload.merge_error).to eq 'Something went wrong'
      end

      it 'returns an error' do
        expect(service.execute(merge_request)).to match(status: :error,
                                                        message: 'Failed to rebase. Should be done manually')
      end
    end

    context 'with git command failure' do
      before do
        allow(repository).to receive(:run_git!).and_raise(Gitlab::Git::Repository::GitError, 'Something went wrong')
      end

      it 'saves the error message' do
        subject.execute(merge_request)

        expect(merge_request.reload.merge_error).to eq 'Something went wrong'
      end

      it 'returns an error' do
        expect(service.execute(merge_request)).to match(status: :error,
                                                        message: 'Failed to rebase. Should be done manually')
      end
    end

    context 'valid params' do
      before do
        service.execute(merge_request)
      end

      it 'rebases source branch' do
        parent_sha = merge_request.source_project.repository.commit(merge_request.source_branch).parents.first.sha
        target_branch_sha = merge_request.target_project.repository.commit(merge_request.target_branch).sha
        expect(parent_sha).to eq(target_branch_sha)
      end

      it 'records the new SHA on the merge request' do
        head_sha = merge_request.source_project.repository.commit(merge_request.source_branch).sha
        expect(merge_request.reload.rebase_commit_sha).to eq(head_sha)
      end

      it 'logs correct author and commiter' do
        head_commit = merge_request.source_project.repository.commit(merge_request.source_branch)

        expect(head_commit.author_email).to eq('dmitriy.zaporozhets@gmail.com')
        expect(head_commit.author_name).to eq('Dmitriy Zaporozhets')
        expect(head_commit.committer_email).to eq(user.email)
        expect(head_commit.committer_name).to eq(user.name)
      end

      context 'git commands' do
        it 'sets GL_REPOSITORY env variable when calling git commands' do
          expect(repository).to receive(:popen).exactly(3)
            .with(anything, anything, hash_including('GL_REPOSITORY'))
            .and_return(['', 0])

          service.execute(merge_request)
        end
      end

      context 'fork' do
        let(:forked_project) do
          fork_project(project, user, repository: true)
        end

        let(:merge_request_from_fork) do
          forked_project.repository.create_file(
            user,
            'new-file-to-target',
            '',
            message: 'Add new file to target',
            branch_name: 'master')

          create(:merge_request,
                 source_branch: 'master', source_project: forked_project,
                 target_branch: 'master', target_project: project)
        end

        it 'rebases source branch' do
          parent_sha = forked_project.repository.commit(merge_request_from_fork.source_branch).parents.first.sha
          target_branch_sha = project.repository.commit(merge_request_from_fork.target_branch).sha
          expect(parent_sha).to eq(target_branch_sha)
        end
      end
    end
  end
end