1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ::Ml::ExperimentTracking::CandidateRepository do
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user) }
let_it_be(:experiment) { create(:ml_experiments, user: user, project: project) }
let_it_be(:candidate) { create(:ml_candidates, user: user, experiment: experiment) }
let(:repository) { described_class.new(project, user) }
describe '#by_iid' do
let(:iid) { candidate.iid }
subject { repository.by_iid(iid) }
it { is_expected.to eq(candidate) }
context 'when iid does not exist' do
let(:iid) { non_existing_record_iid.to_s }
it { is_expected.to be_nil }
end
context 'when iid belongs to a different project' do
let(:repository) { described_class.new(create(:project), user) }
it { is_expected.to be_nil }
end
end
describe '#create!' do
subject { repository.create!(experiment, 1234, [{ key: 'hello', value: 'world' }]) }
it 'creates the candidate' do
expect(subject.start_time).to eq(1234)
expect(subject.iid).not_to be_nil
expect(subject.end_time).to be_nil
end
it 'creates with tag' do
expect(subject.metadata.length).to eq(1)
end
end
describe '#update' do
let(:end_time) { 123456 }
let(:status) { 'running' }
subject { repository.update(candidate, status, end_time) }
it { is_expected.to be_truthy }
context 'when end_time is missing ' do
let(:end_time) { nil }
it { is_expected.to be_truthy }
end
context 'when status is wrong' do
let(:status) { 's' }
it 'fails assigning the value' do
expect { subject }.to raise_error(ArgumentError)
end
end
context 'when status is missing' do
let(:status) { nil }
it { is_expected.to be_truthy }
end
end
describe '#add_metric!' do
let(:props) { { name: 'abc', value: 1234, tracked: 12345678, step: 0 } }
let(:metrics_before) { candidate.metrics.size }
before do
metrics_before
end
subject { repository.add_metric!(candidate, props[:name], props[:value], props[:tracked], props[:step]) }
it 'adds a new metric' do
expect { subject }.to change { candidate.metrics.size }.by(1)
end
context 'when name missing' do
let(:props) { { value: 1234, tracked: 12345678, step: 0 } }
it 'does not add metric' do
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
end
end
end
describe '#add_param!' do
let(:props) { { name: 'abc', value: 'def' } }
subject { repository.add_param!(candidate, props[:name], props[:value]) }
it 'adds a new param' do
expect { subject }.to change { candidate.params.size }.by(1)
end
context 'when name missing' do
let(:props) { { value: 1234 } }
it 'throws RecordInvalid' do
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
end
end
context 'when param was already added' do
it 'throws RecordInvalid' do
repository.add_param!(candidate, 'new', props[:value])
expect { repository.add_param!(candidate, 'new', props[:value]) }.to raise_error(ActiveRecord::RecordInvalid)
end
end
end
describe '#add_tag!' do
let(:props) { { name: 'abc', value: 'def' } }
subject { repository.add_tag!(candidate, props[:name], props[:value]) }
it 'adds a new tag' do
expect { subject }.to change { candidate.reload.metadata.size }.by(1)
end
context 'when name missing' do
let(:props) { { value: 1234 } }
it 'throws RecordInvalid' do
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
end
end
context 'when tag was already added' do
it 'throws RecordInvalid' do
repository.add_tag!(candidate, 'new', props[:value])
expect { repository.add_tag!(candidate, 'new', props[:value]) }.to raise_error(ActiveRecord::RecordInvalid)
end
end
end
describe "#add_params" do
let(:params) do
[{ key: 'model_class', value: 'LogisticRegression' }, { 'key': 'pythonEnv', value: '3.10' }]
end
subject { repository.add_params(candidate, params) }
it 'adds the parameters' do
expect { subject }.to change { candidate.reload.params.size }.by(2)
end
context 'if parameter misses key' do
let(:params) do
[{ value: 'LogisticRegression' }]
end
it 'does not throw and does not add' do
expect { subject }.to raise_error(ActiveRecord::ActiveRecordError)
end
end
context 'if parameter misses value' do
let(:params) do
[{ key: 'pythonEnv2' }]
end
it 'does not throw and does not add' do
expect { subject }.to raise_error(ActiveRecord::ActiveRecordError)
end
end
context 'if parameter repeated do' do
let(:params) do
[
{ 'key': 'pythonEnv0', value: '2.7' },
{ 'key': 'pythonEnv1', value: '3.9' },
{ 'key': 'pythonEnv1', value: '3.10' }
]
end
before do
repository.add_param!(candidate, 'pythonEnv0', '0')
end
it 'does not throw and adds only the first of each kind' do
expect { subject }.to change { candidate.reload.params.size }.by(1)
end
end
end
describe "#add_metrics" do
let(:metrics) do
[
{ key: 'mae', value: 2.5, timestamp: 1552550804 },
{ key: 'rmse', value: 2.7, timestamp: 1552550804 }
]
end
subject { repository.add_metrics(candidate, metrics) }
it 'adds the metrics' do
expect { subject }.to change { candidate.reload.metrics.size }.by(2)
end
context 'when metrics have repeated keys' do
let(:metrics) do
[
{ key: 'mae', value: 2.5, timestamp: 1552550804 },
{ key: 'rmse', value: 2.7, timestamp: 1552550804 },
{ key: 'mae', value: 2.7, timestamp: 1552550805 }
]
end
it 'adds all of them' do
expect { subject }.to change { candidate.reload.metrics.size }.by(3)
end
end
end
describe "#add_tags" do
let(:tags) do
[{ key: 'gitlab.tag1', value: 'hello' }, { 'key': 'gitlab.tag2', value: 'world' }]
end
subject { repository.add_tags(candidate, tags) }
it 'adds the tags' do
expect { subject }.to change { candidate.reload.metadata.size }.by(2)
end
context 'if tags misses key' do
let(:tags) { [{ value: 'hello' }] }
it 'does throw and does not add' do
expect { subject }.to raise_error(ActiveRecord::ActiveRecordError)
end
end
context 'if tag misses value' do
let(:tags) { [{ key: 'gitlab.tag1' }] }
it 'does throw and does not add' do
expect { subject }.to raise_error(ActiveRecord::ActiveRecordError)
end
end
context 'if tag repeated' do
let(:params) do
[
{ 'key': 'gitlab.tag1', value: 'hello' },
{ 'key': 'gitlab.tag2', value: 'world' },
{ 'key': 'gitlab.tag1', value: 'gitlab' }
]
end
before do
repository.add_tag!(candidate, 'gitlab.tag2', '0')
end
it 'does not throw and adds only the first of each kind' do
expect { subject }.to change { candidate.reload.metadata.size }.by(1)
end
end
end
end
|