1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::GroupLinks::UpdateService, '#execute' do
let_it_be(:user) { create :user }
let_it_be(:group) { create :group }
let_it_be(:project) { create :project }
let!(:link) { create(:project_group_link, project: project, group: group) }
let(:expiry_date) { 1.month.from_now.to_date }
let(:group_link_params) do
{ group_access: Gitlab::Access::GUEST,
expires_at: expiry_date }
end
subject { described_class.new(link).execute(group_link_params) }
before do
group.add_developer(user)
end
it 'updates existing link' do
expect(link.group_access).to eq(Gitlab::Access::DEVELOPER)
expect(link.expires_at).to be_nil
subject
link.reload
expect(link.group_access).to eq(Gitlab::Access::GUEST)
expect(link.expires_at).to eq(expiry_date)
end
context 'project authorizations update' do
context 'when the feature flag `specialized_worker_for_project_share_update_auth_recalculation` is enabled' do
before do
stub_feature_flags(specialized_worker_for_project_share_update_auth_recalculation: true)
end
it 'calls AuthorizedProjectUpdate::ProjectRecalculateWorker to update project authorizations' do
expect(AuthorizedProjectUpdate::ProjectRecalculateWorker)
.to receive(:perform_async).with(link.project.id)
subject
end
it 'calls AuthorizedProjectUpdate::UserRefreshFromReplicaWorker with a delay to update project authorizations' do
expect(AuthorizedProjectUpdate::UserRefreshFromReplicaWorker).to(
receive(:bulk_perform_in)
.with(1.hour,
[[user.id]],
batch_delay: 30.seconds, batch_size: 100)
)
subject
end
it 'updates project authorizations of users who had access to the project via the group share', :sidekiq_inline do
group.add_maintainer(user)
expect { subject }.to(
change { Ability.allowed?(user, :create_release, project) }
.from(true).to(false))
end
end
context 'when the feature flag `specialized_worker_for_project_share_update_auth_recalculation` is disabled' do
before do
stub_feature_flags(specialized_worker_for_project_share_update_auth_recalculation: false)
end
it 'calls UserProjectAccessChangedService to update project authorizations' do
expect_next_instance_of(UserProjectAccessChangedService, [user.id]) do |service|
expect(service).to receive(:execute)
end
subject
end
it 'updates project authorizations of users who had access to the project via the group share' do
group.add_maintainer(user)
expect { subject }.to(
change { Ability.allowed?(user, :create_release, project) }
.from(true).to(false))
end
end
end
context 'with only param not requiring authorization refresh' do
let(:group_link_params) { { expires_at: Date.tomorrow } }
context 'when the feature flag `specialized_worker_for_project_share_update_auth_recalculation` is enabled' do
before do
stub_feature_flags(specialized_worker_for_project_share_update_auth_recalculation: true)
end
it 'does not perform any project authorizations update using `AuthorizedProjectUpdate::ProjectRecalculateWorker`' do
expect(AuthorizedProjectUpdate::ProjectRecalculateWorker).not_to receive(:perform_async)
subject
end
end
context 'when the feature flag `specialized_worker_for_project_share_update_auth_recalculation` is disabled' do
before do
stub_feature_flags(specialized_worker_for_project_share_update_auth_recalculation: false)
end
it 'does not perform any project authorizations update using `UserProjectAccessChangedService`' do
expect(UserProjectAccessChangedService).not_to receive(:new)
subject
end
end
end
end
|
