summaryrefslogtreecommitdiff
path: root/spec/services/projects/update_pages_service_spec.rb
blob: 505aff1acf49062bbf5c3947c6b6984f89296cca (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
require "spec_helper"

describe Projects::UpdatePagesService do
  set(:project) { create(:project, :repository) }
  set(:pipeline) { create(:ci_pipeline, project: project, sha: project.commit('HEAD').sha) }
  set(:build) { create(:ci_build, pipeline: pipeline, ref: 'HEAD') }
  let(:invalid_file) { fixture_file_upload(Rails.root + 'spec/fixtures/dk.png') }
  let(:extension) { 'zip' }

  let(:file) { fixture_file_upload(Rails.root + "spec/fixtures/pages.#{extension}") }
  let(:empty_file) { fixture_file_upload(Rails.root + "spec/fixtures/pages_empty.#{extension}") }
  let(:metadata) do
    filename = Rails.root + "spec/fixtures/pages.#{extension}.meta"
    fixture_file_upload(filename) if File.exist?(filename)
  end

  subject { described_class.new(project, build) }

  before do
    project.remove_pages
  end

  context 'legacy artifacts' do
    %w(tar.gz zip).each do |format|
      let(:extension) { format }

      context "for valid #{format}" do
        before do
          build.update_attributes(legacy_artifacts_file: file)
          build.update_attributes(legacy_artifacts_metadata: metadata)
        end

        describe 'pages artifacts' do
          context 'with expiry date' do
            before do
              build.artifacts_expire_in = "2 days"
              build.save!
            end

            it "doesn't delete artifacts" do
              expect(execute).to eq(:success)

              expect(build.reload.artifacts?).to eq(true)
            end
          end

          context 'without expiry date' do
            it "does delete artifacts" do
              expect(execute).to eq(:success)

              expect(build.reload.artifacts?).to eq(false)
            end
          end
        end

        it 'succeeds' do
          expect(project.pages_deployed?).to be_falsey
          expect(execute).to eq(:success)
          expect(project.pages_deployed?).to be_truthy

          # Check that all expected files are extracted
          %w[index.html zero .hidden/file].each do |filename|
            expect(File.exist?(File.join(project.public_pages_path, filename))).to be_truthy
          end
        end

        it 'limits pages size' do
          stub_application_setting(max_pages_size: 1)
          expect(execute).not_to eq(:success)
        end

        it 'removes pages after destroy' do
          expect(PagesWorker).to receive(:perform_in)
          expect(project.pages_deployed?).to be_falsey
          expect(execute).to eq(:success)
          expect(project.pages_deployed?).to be_truthy
          project.destroy
          expect(project.pages_deployed?).to be_falsey
        end

        it 'fails if sha on branch is not latest' do
          build.update_attributes(ref: 'feature')

          expect(execute).not_to eq(:success)
        end

        it 'fails for empty file fails' do
          build.update_attributes(legacy_artifacts_file: empty_file)

          expect(execute).not_to eq(:success)
        end
      end
    end
  end

  context 'for new artifacts' do
    context "for a valid job" do
      before do
        create(:ci_job_artifact, file: file, job: build)
        create(:ci_job_artifact, file_type: :metadata, file: metadata, job: build)

        build.reload
      end

      describe 'pages artifacts' do
        context 'with expiry date' do
          before do
            build.artifacts_expire_in = "2 days"
            build.save!
          end

          it "doesn't delete artifacts" do
            expect(execute).to eq(:success)

            expect(build.artifacts?).to eq(true)
          end
        end

        context 'without expiry date' do
          it "does delete artifacts" do
            expect(execute).to eq(:success)

            expect(build.reload.artifacts?).to eq(false)
          end
        end
      end

      it 'succeeds' do
        expect(project.pages_deployed?).to be_falsey
        expect(execute).to eq(:success)
        expect(project.pages_deployed?).to be_truthy

        # Check that all expected files are extracted
        %w[index.html zero .hidden/file].each do |filename|
          expect(File.exist?(File.join(project.public_pages_path, filename))).to be_truthy
        end
      end

      it 'limits pages size' do
        stub_application_setting(max_pages_size: 1)
        expect(execute).not_to eq(:success)
      end

      it 'removes pages after destroy' do
        expect(PagesWorker).to receive(:perform_in)
        expect(project.pages_deployed?).to be_falsey
        expect(execute).to eq(:success)
        expect(project.pages_deployed?).to be_truthy
        project.destroy
        expect(project.pages_deployed?).to be_falsey
      end

      it 'fails if sha on branch is not latest' do
        build.update_attributes(ref: 'feature')

        expect(execute).not_to eq(:success)
      end

      it 'fails for empty file fails' do
        build.job_artifacts_archive.update_attributes(file: empty_file)

        expect(execute).not_to eq(:success)
      end

      context 'when timeout happens by DNS error' do
        before do
          allow_any_instance_of(Projects::UpdatePagesService)
            .to receive(:extract_zip_archive!).and_raise(SocketError)
        end

        it 'raises an error' do
          expect { execute }.to raise_error(SocketError)
        end
      end
    end
  end

  it 'fails to remove project pages when no pages is deployed' do
    expect(PagesWorker).not_to receive(:perform_in)
    expect(project.pages_deployed?).to be_falsey
    project.destroy
  end

  it 'fails if no artifacts' do
    expect(execute).not_to eq(:success)
  end

  it 'fails for invalid archive' do
    build.update_attributes(legacy_artifacts_file: invalid_file)
    expect(execute).not_to eq(:success)
  end

  describe 'maximum pages artifacts size' do
    let(:metadata) { spy('metadata') }

    before do
      file = fixture_file_upload(Rails.root + 'spec/fixtures/pages.zip')
      metafile = fixture_file_upload(Rails.root + 'spec/fixtures/pages.zip.meta')

      build.update_attributes(legacy_artifacts_file: file)
      build.update_attributes(legacy_artifacts_metadata: metafile)

      allow(build).to receive(:artifacts_metadata_entry)
        .and_return(metadata)
    end

    shared_examples 'pages size limit exceeded' do
      it 'limits the maximum size of gitlab pages' do
        subject.execute

        expect(deploy_status.description)
          .to match(/artifacts for pages are too large/)
        expect(deploy_status).to be_script_failure
      end
    end

    context 'when maximum pages size is set to zero' do
      before do
        stub_application_setting(max_pages_size: 0)
      end

      context 'when page size does not exceed internal maximum' do
        before do
          allow(metadata).to receive(:total_size).and_return(200.megabytes)
        end

        it 'updates pages correctly' do
          subject.execute

          expect(deploy_status.description).not_to be_present
        end
      end

      context 'when pages size does exceed internal maximum' do
        before do
          allow(metadata).to receive(:total_size).and_return(2.terabytes)
        end

        it_behaves_like 'pages size limit exceeded'
      end
    end

    context 'when pages size is greater than max size setting' do
      before do
        stub_application_setting(max_pages_size: 200)
        allow(metadata).to receive(:total_size).and_return(201.megabytes)
      end

      it_behaves_like 'pages size limit exceeded'
    end

    context 'when max size setting is greater than internal max size' do
      before do
        stub_application_setting(max_pages_size: 3.terabytes / 1.megabyte)
        allow(metadata).to receive(:total_size).and_return(2.terabytes)
      end

      it_behaves_like 'pages size limit exceeded'
    end
  end

  def deploy_status
    GenericCommitStatus.find_by(name: 'pages:deploy')
  end

  def execute
    subject.execute[:status]
  end
end