1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
|
# frozen_string_literal: true
RSpec.shared_examples 'a hook that gets automatically disabled on failure' do
shared_examples 'is tolerant of invalid records' do
specify do
hook.url = nil
expect(hook).to be_invalid
run_expectation
end
end
describe '.executable/.disabled', :freeze_time do
let!(:not_executable) do
[
[4, nil], # Exceeded the grace period, set by #fail!
[4, 1.second.from_now], # Exceeded the grace period, set by #backoff!
[4, Time.current] # Exceeded the grace period, set by #backoff!, edge-case
].map do |(recent_failures, disabled_until)|
create(
hook_factory,
**default_factory_arguments,
recent_failures: recent_failures,
disabled_until: disabled_until
)
end
end
let!(:executables) do
expired = 1.second.ago
borderline = Time.current
suspended = 1.second.from_now
[
# Most of these are impossible states, but are included for completeness
[0, nil],
[1, nil],
[3, nil],
[4, expired],
# Impossible cases:
[3, suspended],
[3, expired],
[3, borderline],
[1, suspended],
[1, expired],
[1, borderline],
[0, borderline],
[0, suspended],
[0, expired]
].map do |(recent_failures, disabled_until)|
create(
hook_factory,
**default_factory_arguments,
recent_failures: recent_failures,
disabled_until: disabled_until
)
end
end
it 'finds the correct set of project hooks' do
expect(find_hooks.executable).to match_array executables
expect(find_hooks.executable).to all(be_executable)
# As expected, and consistent
expect(find_hooks.disabled).to match_array not_executable
expect(find_hooks.disabled.map(&:executable?)).not_to include(true)
# Nothing is missing
expect(find_hooks.executable.to_a + find_hooks.disabled.to_a).to match_array(find_hooks.to_a)
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'causes all hooks to be considered executable' do
expect(find_hooks.executable.count).to eq(16)
end
it 'causes no hooks to be considered disabled' do
expect(find_hooks.disabled).to be_empty
end
end
end
describe '#executable?', :freeze_time do
let(:web_hook) { create(hook_factory, **default_factory_arguments) }
where(:recent_failures, :not_until, :executable) do
[
[0, :not_set, true],
[0, :past, true],
[0, :future, true],
[0, :now, true],
[1, :not_set, true],
[1, :past, true],
[1, :future, true],
[3, :not_set, true],
[3, :past, true],
[3, :future, true],
[4, :not_set, false],
[4, :past, true], # expired suspension
[4, :now, false], # active suspension
[4, :future, false] # active suspension
]
end
with_them do
# Phasing means we cannot put these values in the where block,
# which is not subject to the frozen time context.
let(:disabled_until) do
case not_until
when :not_set
nil
when :past
1.minute.ago
when :future
1.minute.from_now
when :now
Time.current
end
end
before do
web_hook.update!(recent_failures: recent_failures, disabled_until: disabled_until)
end
it 'has the correct state' do
expect(web_hook.executable?).to eq(executable)
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'is always executable' do
expect(web_hook).to be_executable
end
end
end
end
describe '#enable!' do
it 'makes a hook executable if it was marked as failed' do
hook.recent_failures = 1000
expect { hook.enable! }.to change { hook.executable? }.from(false).to(true)
end
it 'makes a hook executable if it is currently backed off' do
hook.recent_failures = 1000
hook.disabled_until = 1.hour.from_now
expect { hook.enable! }.to change { hook.executable? }.from(false).to(true)
end
it 'does not update hooks unless necessary' do
hook
sql_count = ActiveRecord::QueryRecorder.new { hook.enable! }.count
expect(sql_count).to eq(0)
end
include_examples 'is tolerant of invalid records' do
def run_expectation
hook.recent_failures = 1000
expect { hook.enable! }.to change { hook.executable? }.from(false).to(true)
end
end
end
describe '#backoff!' do
context 'when we have not backed off before' do
it 'does not disable the hook' do
expect { hook.backoff! }.not_to change { hook.executable? }.from(true)
end
end
context 'when we have exhausted the grace period' do
before do
hook.update!(recent_failures: WebHooks::AutoDisabling::FAILURE_THRESHOLD)
end
context 'when the hook is permanently disabled' do
before do
allow(hook).to receive(:permanently_disabled?).and_return(true)
end
it 'does not set disabled_until' do
expect { hook.backoff! }.not_to change { hook.disabled_until }
end
it 'does not increment the backoff count' do
expect { hook.backoff! }.not_to change { hook.backoff_count }
end
end
include_examples 'is tolerant of invalid records' do
def run_expectation
expect { hook.backoff! }.to change { hook.backoff_count }.by(1)
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'does not increment backoff count' do
expect { hook.failed! }.not_to change { hook.backoff_count }
end
end
end
end
end
describe '#failed!' do
include_examples 'is tolerant of invalid records' do
def run_expectation
expect { hook.failed! }.to change { hook.recent_failures }.by(1)
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'does not increment recent failure count' do
expect { hook.failed! }.not_to change { hook.recent_failures }
end
end
end
end
describe '#disable!' do
it 'disables a hook' do
expect { hook.disable! }.to change { hook.executable? }.from(true).to(false)
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'does not disable the hook' do
expect { hook.disable! }.not_to change { hook.executable? }
end
end
it 'does nothing if the hook is already disabled' do
allow(hook).to receive(:permanently_disabled?).and_return(true)
sql_count = ActiveRecord::QueryRecorder.new { hook.disable! }.count
expect(sql_count).to eq(0)
end
include_examples 'is tolerant of invalid records' do
def run_expectation
expect { hook.disable! }.to change { hook.executable? }.from(true).to(false)
end
end
end
describe '#temporarily_disabled?' do
it 'is false when not temporarily disabled' do
expect(hook).not_to be_temporarily_disabled
end
it 'allows FAILURE_THRESHOLD initial failures before we back-off' do
WebHooks::AutoDisabling::FAILURE_THRESHOLD.times do
hook.backoff!
expect(hook).not_to be_temporarily_disabled
end
hook.backoff!
expect(hook).to be_temporarily_disabled
end
context 'when hook has been told to back off' do
before do
hook.update!(recent_failures: WebHooks::AutoDisabling::FAILURE_THRESHOLD)
hook.backoff!
end
it 'is true' do
expect(hook).to be_temporarily_disabled
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'is false' do
expect(hook).not_to be_temporarily_disabled
end
end
end
end
describe '#permanently_disabled?' do
it 'is false when not disabled' do
expect(hook).not_to be_permanently_disabled
end
context 'when hook has been disabled' do
before do
hook.disable!
end
it 'is true' do
expect(hook).to be_permanently_disabled
end
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it 'is false' do
expect(hook).not_to be_permanently_disabled
end
end
end
end
describe '#alert_status' do
subject(:status) { hook.alert_status }
it { is_expected.to eq :executable }
context 'when hook has been disabled' do
before do
hook.disable!
end
it { is_expected.to eq :disabled }
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it { is_expected.to eq(:executable) }
end
end
context 'when hook has been backed off' do
before do
hook.update!(recent_failures: WebHooks::AutoDisabling::FAILURE_THRESHOLD + 1)
hook.disabled_until = 1.hour.from_now
end
it { is_expected.to eq :temporarily_disabled }
context 'when the flag is disabled' do
before do
stub_feature_flags(auto_disabling_web_hooks: false)
end
it { is_expected.to eq(:executable) }
end
end
end
end
|