summaryrefslogtreecommitdiff
path: root/spec/support/shared_examples/requests/api/merge_requests_list.rb
blob: 6713ec47ace012aef305bc48bd80e11db20891c1 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
shared_examples 'merge requests list' do
  context 'when unauthenticated' do
    it 'returns merge requests for public projects' do
      get api(endpoint_path)

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
    end
  end

  context 'when authenticated' do
    it 'avoids N+1 queries' do
      control = ActiveRecord::QueryRecorder.new do
        get api(endpoint_path, user)
      end

      create(:merge_request, state: 'closed', milestone: milestone1, author: user, assignee: user, source_project: project, target_project: project, title: 'Test', created_at: base_time)

      merge_request = create(:merge_request, milestone: milestone1, author: user, assignee: user, source_project: project, target_project: project, title: 'Test', created_at: base_time)

      merge_request.metrics.update!(merged_by: user,
                                    latest_closed_by: user,
                                    latest_closed_at: 1.hour.ago,
                                    merged_at: 2.hours.ago)

      expect do
        get api(endpoint_path, user)
      end.not_to exceed_query_limit(control)
    end

    it 'returns an array of all merge_requests' do
      get api(endpoint_path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(4)
      expect(json_response.last['title']).to eq(merge_request.title)
      expect(json_response.last).to have_key('web_url')
      expect(json_response.last['sha']).to eq(merge_request.diff_head_sha)
      expect(json_response.last['merge_commit_sha']).to be_nil
      expect(json_response.last['merge_commit_sha']).to eq(merge_request.merge_commit_sha)
      expect(json_response.last['downvotes']).to eq(1)
      expect(json_response.last['upvotes']).to eq(1)
      expect(json_response.last['labels']).to eq([label2.title, label.title])
      expect(json_response.first['title']).to eq(merge_request_merged.title)
      expect(json_response.first['sha']).to eq(merge_request_merged.diff_head_sha)
      expect(json_response.first['merge_commit_sha']).not_to be_nil
      expect(json_response.first['merge_commit_sha']).to eq(merge_request_merged.merge_commit_sha)
    end

    it 'returns an array of all merge_requests using simple mode' do
      path = endpoint_path + '?view=simple'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response.last.keys).to match_array(%w(id iid title web_url created_at description project_id state updated_at))
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(4)
      expect(json_response.last['iid']).to eq(merge_request.iid)
      expect(json_response.last['title']).to eq(merge_request.title)
      expect(json_response.last).to have_key('web_url')
      expect(json_response.first['iid']).to eq(merge_request_merged.iid)
      expect(json_response.first['title']).to eq(merge_request_merged.title)
      expect(json_response.first).to have_key('web_url')
    end

    it 'returns an array of all merge_requests' do
      path = endpoint_path + '?state'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(4)
      expect(json_response.last['title']).to eq(merge_request.title)
    end

    it 'returns an array of open merge_requests' do
      path = endpoint_path + '?state=opened'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.last['title']).to eq(merge_request.title)
    end

    it 'returns an array of closed merge_requests' do
      path = endpoint_path + '?state=closed'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.first['title']).to eq(merge_request_closed.title)
    end

    it 'returns an array of merged merge_requests' do
      path = endpoint_path + '?state=merged'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to include_pagination_headers
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.first['title']).to eq(merge_request_merged.title)
    end

    it 'matches V4 response schema' do
      get api(endpoint_path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(response).to match_response_schema('public_api/v4/merge_requests')
    end

    it 'returns an empty array if no issue matches milestone' do
      get api(endpoint_path, user), params: { milestone: '1.0.0' }

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(0)
    end

    it 'returns an empty array if milestone does not exist' do
      get api(endpoint_path, user), params: { milestone: 'foo' }

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(0)
    end

    it 'returns an array of merge requests in given milestone' do
      get api(endpoint_path, user), params: { milestone: '0.9' }

      closed_issues = json_response.select { |mr| mr['id'] == merge_request_closed.id }
      expect(closed_issues.length).to eq(1)
      expect(closed_issues.first['title']).to eq merge_request_closed.title
    end

    it 'returns an array of merge requests matching state in milestone' do
      get api(endpoint_path, user), params: { milestone: '0.9', state: 'closed' }

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.first['id']).to eq(merge_request_closed.id)
    end

    it 'returns an array of labeled merge requests' do
      path = endpoint_path + "?labels=#{label.title}"

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.first['labels']).to eq([label2.title, label.title])
    end

    it 'returns an array of labeled merge requests where all labels match' do
      path = endpoint_path + "?labels=#{label.title},foo,bar"

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(0)
    end

    it 'returns an empty array if no merge request matches labels' do
      path = endpoint_path + '?labels=foo,bar'

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(0)
    end

    it 'returns an array of merge requests with any label when filtering by any label' do
      get api(endpoint_path, user), params: { labels: IssuesFinder::FILTER_ANY }

      expect_paginated_array_response
      expect(json_response.length).to eq(1)
      expect(json_response.first['id']).to eq(merge_request.id)
    end

    it 'returns an array of merge requests without a label when filtering by no label' do
      get api(endpoint_path, user), params: { labels: IssuesFinder::FILTER_NONE }

      response_ids = json_response.map { |merge_request| merge_request['id'] }

      expect_paginated_array_response
      expect(response_ids).to contain_exactly(merge_request_closed.id, merge_request_merged.id, merge_request_locked.id)
    end

    it 'returns an array of labeled merge requests that are merged for a milestone' do
      bug_label = create(:label, title: 'bug', color: '#FFAABB', project: project)

      mr1 = create(:merge_request, state: 'merged', source_project: project, target_project: project, milestone: milestone)
      mr2 = create(:merge_request, state: 'merged', source_project: project, target_project: project, milestone: milestone1)
      mr3 = create(:merge_request, state: 'closed', source_project: project, target_project: project, milestone: milestone1)
      _mr = create(:merge_request, state: 'merged', source_project: project, target_project: project, milestone: milestone1)

      create(:label_link, label: bug_label, target: mr1)
      create(:label_link, label: bug_label, target: mr2)
      create(:label_link, label: bug_label, target: mr3)

      path = endpoint_path + "?labels=#{bug_label.title}&milestone=#{milestone1.title}&state=merged"

      get api(path, user)

      expect(response).to have_gitlab_http_status(200)
      expect(json_response).to be_an Array
      expect(json_response.length).to eq(1)
      expect(json_response.first['id']).to eq(mr2.id)
    end

    context 'with ordering' do
      before do
        @mr_later = mr_with_later_created_and_updated_at_time
        @mr_earlier = mr_with_earlier_created_and_updated_at_time
      end

      it 'returns an array of merge_requests in ascending order' do
        path = endpoint_path + '?sort=asc'

        get api(path, user)

        expect(response).to have_gitlab_http_status(200)
        expect(response).to include_pagination_headers
        expect(json_response).to be_an Array
        expect(json_response.length).to eq(4)
        response_dates = json_response.map { |merge_request| merge_request['created_at'] }
        expect(response_dates).to eq(response_dates.sort)
      end

      it 'returns an array of merge_requests in descending order' do
        path = endpoint_path + '?sort=desc'

        get api(path, user)

        expect(response).to have_gitlab_http_status(200)
        expect(response).to include_pagination_headers
        expect(json_response).to be_an Array
        expect(json_response.length).to eq(4)
        response_dates = json_response.map { |merge_request| merge_request['created_at'] }
        expect(response_dates).to eq(response_dates.sort.reverse)
      end

      context '2 merge requests with equal created_at' do
        let!(:closed_mr2) do
          create :merge_request,
                 state: 'closed',
                 milestone: milestone1,
                 author: user,
                 assignee: user,
                 source_project: project,
                 target_project: project,
                 title: "Test",
                 created_at: @mr_earlier.created_at
        end

        it 'page breaks first page correctly' do
          get api("#{endpoint_path}?sort=desc&per_page=4", user)

          response_ids = json_response.map { |merge_request| merge_request['id'] }

          expect(response_ids).to include(closed_mr2.id)
          expect(response_ids).not_to include(@mr_earlier.id)
        end

        it 'page breaks second page correctly' do
          get api("#{endpoint_path}?sort=desc&per_page=4&page=2", user)

          response_ids = json_response.map { |merge_request| merge_request['id'] }

          expect(response_ids).not_to include(closed_mr2.id)
          expect(response_ids).to include(@mr_earlier.id)
        end
      end

      it 'returns an array of merge_requests ordered by updated_at' do
        path = endpoint_path + '?order_by=updated_at'

        get api(path, user)

        expect(response).to have_gitlab_http_status(200)
        expect(response).to include_pagination_headers
        expect(json_response).to be_an Array
        expect(json_response.length).to eq(4)
        response_dates = json_response.map { |merge_request| merge_request['updated_at'] }
        expect(response_dates).to eq(response_dates.sort.reverse)
      end

      it 'returns an array of merge_requests ordered by created_at' do
        path = endpoint_path + '?order_by=created_at&sort=asc'

        get api(path, user)

        expect(response).to have_gitlab_http_status(200)
        expect(response).to include_pagination_headers
        expect(json_response).to be_an Array
        expect(json_response.length).to eq(4)
        response_dates = json_response.map { |merge_request| merge_request['created_at'] }
        expect(response_dates).to eq(response_dates.sort)
      end
    end

    context 'source_branch param' do
      it 'returns merge requests with the given source branch' do
        get api(endpoint_path, user), params: { source_branch: merge_request_closed.source_branch, state: 'all' }

        expect_response_contain_exactly(merge_request_closed, merge_request_merged, merge_request_locked)
      end
    end

    context 'target_branch param' do
      it 'returns merge requests with the given target branch' do
        get api(endpoint_path, user), params: { target_branch: merge_request_closed.target_branch, state: 'all' }

        expect_response_contain_exactly(merge_request_closed, merge_request_merged, merge_request_locked)
      end
    end
  end
end