1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
# frozen_string_literal: true
require 'tempfile'
require_relative '../../../../../tooling/lib/tooling/mappings/js_to_system_specs_mappings'
RSpec.describe Tooling::Mappings::JsToSystemSpecsMappings, feature_category: :tooling do
# We set temporary folders, and those readers give access to those folder paths
attr_accessor :js_base_folder, :system_specs_base_folder
around do |example|
Dir.mktmpdir do |tmp_js_base_folder|
Dir.mktmpdir do |tmp_system_specs_base_folder|
self.system_specs_base_folder = tmp_system_specs_base_folder
self.js_base_folder = tmp_js_base_folder
example.run
end
end
end
describe '#execute' do
let(:instance) do
described_class.new(
system_specs_base_folder: system_specs_base_folder,
js_base_folder: js_base_folder
)
end
subject { instance.execute(changed_files) }
context 'when no JS files were changed' do
let(:changed_files) { [] }
it 'returns nothing' do
expect(subject).to match_array([])
end
end
context 'when some JS files were changed' do
let(:changed_files) { ["#{js_base_folder}/issues/secret_values.js"] }
context 'when the JS files are not present on disk' do
it 'returns nothing' do
expect(subject).to match_array([])
end
end
context 'when the JS files are present on disk' do
before do
FileUtils.mkdir_p("#{js_base_folder}/issues")
File.write("#{js_base_folder}/issues/secret_values.js", "hello")
end
context 'when no system specs match the JS keyword' do
it 'returns nothing' do
expect(subject).to match_array([])
end
end
context 'when a system spec matches the JS keyword' do
before do
FileUtils.mkdir_p("#{system_specs_base_folder}/confidential_issues")
File.write("#{system_specs_base_folder}/confidential_issues/issues_spec.rb", "a test")
end
it 'returns something' do
expect(subject).to match_array(["#{system_specs_base_folder}/confidential_issues/issues_spec.rb"])
end
end
end
end
end
describe '#filter_files' do
subject { described_class.new(js_base_folder: js_base_folder).filter_files(changed_files) }
before do
File.write("#{js_base_folder}/index.js", "index.js")
File.write("#{js_base_folder}/index-with-ee-in-it.js", "index-with-ee-in-it.js")
File.write("#{js_base_folder}/index-with-jh-in-it.js", "index-with-jh-in-it.js")
end
context 'when no files were changed' do
let(:changed_files) { [] }
it 'returns an empty array' do
expect(subject).to match_array([])
end
end
context 'when JS files were changed' do
let(:changed_files) do
[
"#{js_base_folder}/index.js",
"#{js_base_folder}/index-with-ee-in-it.js",
"#{js_base_folder}/index-with-jh-in-it.js"
]
end
it 'returns the path to the JS files' do
# "nil" group represents FOSS JS files in app/assets/javascripts
expect(subject).to match(nil => [
"#{js_base_folder}/index.js",
"#{js_base_folder}/index-with-ee-in-it.js",
"#{js_base_folder}/index-with-jh-in-it.js"
])
end
end
context 'when JS files are deleted' do
let(:changed_files) { ["#{system_specs_base_folder}/deleted.html"] }
it 'returns an empty array' do
expect(subject).to match_array([])
end
end
end
describe '#construct_js_keywords' do
subject { described_class.new.construct_js_keywords(js_files) }
let(:js_files) do
%w[
app/assets/javascripts/boards/issue_board_filters.js
ee/app/assets/javascripts/queries/epic_due_date.query.graphql
]
end
it 'returns a singularized keyword based on the first folder the file is in' do
expect(subject).to eq(%w[board query])
end
context 'when the files are under the pages folder' do
let(:js_files) do
%w[
app/assets/javascripts/pages/boards/issue_board_filters.js
ee/app/assets/javascripts/pages2/queries/epic_due_date.query.graphql
ee/app/assets/javascripts/queries/epic_due_date.query.graphql
]
end
it 'captures the second folder' do
expect(subject).to eq(%w[board pages2 query])
end
end
end
describe '#system_specs_for_edition' do
subject do
described_class.new(system_specs_base_folder: system_specs_base_folder).system_specs_for_edition(edition)
end
context 'when FOSS' do
let(:edition) { nil }
it 'checks the correct folder' do
expect(Dir).to receive(:[]).with("#{system_specs_base_folder}/**/*").and_call_original
subject
end
end
context 'when EE' do
let(:edition) { 'ee' }
it 'checks the correct folder' do
expect(Dir).to receive(:[]).with("ee#{system_specs_base_folder}/**/*").and_call_original
subject
end
end
context 'when JiHu' do
let(:edition) { 'jh' }
it 'checks the correct folder' do
expect(Dir).to receive(:[]).with("jh#{system_specs_base_folder}/**/*").and_call_original
subject
end
end
end
end
|
