summaryrefslogtreecommitdiff
path: root/spec/uploaders/file_uploader_spec.rb
blob: b42ce982b27c2b1e13c9f4b42954b086b7707e05 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
require 'spec_helper'

describe FileUploader do
  let(:group) { create(:group, name: 'awesome') }
  let(:project) { create(:project, :legacy_storage, namespace: group, name: 'project') }
  let(:uploader) { described_class.new(project) }
  let(:upload)  { double(model: project, path: 'secret/foo.jpg') }

  subject { uploader }

  shared_examples 'builds correct legacy storage paths' do
    include_examples 'builds correct paths',
                     store_dir: %r{awesome/project/\h+},
                     absolute_path: %r{#{described_class.root}/awesome/project/secret/foo.jpg}
  end

  shared_examples 'uses hashed storage' do
    context 'when rolled out attachments' do
      let(:project) { build_stubbed(:project, namespace: group, name: 'project') }

      before do
        allow(project).to receive(:disk_path).and_return('ca/fe/fe/ed')
      end

      it_behaves_like 'builds correct paths',
                      store_dir: %r{ca/fe/fe/ed/\h+},
                      absolute_path: %r{#{described_class.root}/ca/fe/fe/ed/secret/foo.jpg}
    end

    context 'when only repositories are rolled out' do
      let(:project) { build_stubbed(:project, namespace: group, name: 'project', storage_version: Project::HASHED_STORAGE_FEATURES[:repository]) }

      it_behaves_like 'builds correct legacy storage paths'
    end
  end

  context 'legacy storage' do
    it_behaves_like 'builds correct legacy storage paths'
    include_examples 'uses hashed storage'
  end

  describe 'initialize' do
    let(:uploader) { described_class.new(double, secret: 'secret') }

    it 'accepts a secret parameter' do
      expect(described_class).not_to receive(:generate_secret)
      expect(uploader.secret).to eq('secret')
    end
  end

  describe 'callbacks' do
    describe '#prune_store_dir after :remove' do
      before do
        uploader.store!(fixture_file_upload('spec/fixtures/doc_sample.txt'))
      end

      def store_dir
        File.expand_path(uploader.store_dir, uploader.root)
      end

      it 'is called' do
        expect(uploader).to receive(:prune_store_dir).once

        uploader.remove!
      end

      it 'prune the store directory' do
        expect { uploader.remove! }
          .to change { File.exist?(store_dir) }.from(true).to(false)
      end
    end
  end

  describe '#secret' do
    it 'generates a secret if none is provided' do
      expect(described_class).to receive(:generate_secret).and_return('secret')
      expect(uploader.secret).to eq('secret')
    end
  end

  describe '#upload=' do
    let(:secret) { SecureRandom.hex }
    let(:upload) { create(:upload, :issuable_upload, secret: secret, filename: 'file.txt') }

    it 'handles nil' do
      expect(uploader).not_to receive(:apply_context!)

      uploader.upload = nil
    end

    it 'extract the uploader context from it' do
      expect(uploader).to receive(:apply_context!).with(a_hash_including(secret: secret, identifier: 'file.txt'))

      uploader.upload = upload
    end

    context 'uploader_context is empty' do
      it 'fallbacks to regex based extraction' do
        expect(upload).to receive(:uploader_context).and_return({})

        uploader.upload = upload
        expect(uploader.secret).to eq(secret)
        expect(uploader.instance_variable_get(:@identifier)).to eq('file.txt')
      end
    end
  end
end