1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe BulkImports::ExportRequestWorker do
let_it_be(:bulk_import) { create(:bulk_import) }
let_it_be(:config) { create(:bulk_import_configuration, bulk_import: bulk_import) }
let_it_be(:version_url) { 'https://gitlab.example/api/v4/version' }
let(:response_double) { double(code: 200, success?: true, parsed_response: {}) }
let(:job_args) { [entity.id] }
describe '#perform' do
before do
allow(Gitlab::HTTP)
.to receive(:get)
.with(version_url, anything)
.and_return(double(code: 200, success?: true, parsed_response: { 'version' => Gitlab::VERSION }))
allow(Gitlab::HTTP).to receive(:post).and_return(response_double)
end
shared_examples 'requests relations export for api resource' do
include_examples 'an idempotent worker' do
it 'requests relations export & schedules entity worker' do
expect_next_instance_of(BulkImports::Clients::HTTP) do |client|
expect(client).to receive(:post).with(expected).twice
end
expect(BulkImports::EntityWorker).to receive(:perform_async).twice
perform_multiple(job_args)
end
context 'when network error is raised' do
let(:exception) { BulkImports::NetworkError.new('Export error') }
before do
allow_next_instance_of(BulkImports::Clients::HTTP) do |client|
allow(client).to receive(:post).and_raise(exception).twice
end
end
context 'when error is retriable' do
it 'logs retry request and reenqueues' do
allow(exception).to receive(:retriable?).twice.and_return(true)
expect(Gitlab::Import::Logger).to receive(:error).with(
hash_including(
'bulk_import_entity_id' => entity.id,
'pipeline_class' => 'ExportRequestWorker',
'exception_class' => 'BulkImports::NetworkError',
'exception_message' => 'Export error',
'bulk_import_id' => bulk_import.id,
'bulk_import_entity_type' => entity.source_type,
'importer' => 'gitlab_migration',
'message' => 'Retrying export request'
)
).twice
expect(described_class).to receive(:perform_in).twice.with(2.seconds, entity.id)
perform_multiple(job_args)
end
end
context 'when error is not retriable' do
it 'logs export failure and marks entity as failed' do
expect(Gitlab::Import::Logger).to receive(:error).with(
hash_including(
'bulk_import_entity_id' => entity.id,
'pipeline_class' => 'ExportRequestWorker',
'exception_class' => 'BulkImports::NetworkError',
'exception_message' => 'Export error',
'correlation_id_value' => anything,
'bulk_import_id' => bulk_import.id,
'bulk_import_entity_type' => entity.source_type,
'importer' => 'gitlab_migration'
)
).twice
perform_multiple(job_args)
failure = entity.failures.last
expect(failure.pipeline_class).to eq('ExportRequestWorker')
expect(failure.exception_message).to eq('Export error')
end
end
end
context 'when source id is nil' do
let(:entity_source_id) { 'gid://gitlab/Model/1234567' }
before do
graphql_client = instance_double(BulkImports::Clients::Graphql)
response = double(original_hash: { 'data' => { entity.entity_type => { 'id' => entity_source_id } } })
allow(BulkImports::Clients::Graphql).to receive(:new).and_return(graphql_client)
allow(graphql_client).to receive(:parse)
allow(graphql_client).to receive(:execute).and_return(response)
end
it 'updates entity source id & requests export using source id' do
expect_next_instance_of(BulkImports::Clients::HTTP) do |client|
expect(client)
.to receive(:post)
.with("/#{entity.pluralized_name}/1234567/export_relations")
.twice
end
entity.update!(source_xid: nil)
perform_multiple(job_args)
expect(entity.reload.source_xid).to eq(1234567)
end
context 'when something goes wrong during source id fetch' do
let(:entity_source_id) { 'invalid' }
it 'logs the error & requests relations export using full path url' do
expect_next_instance_of(BulkImports::Clients::HTTP) do |client|
expect(client).to receive(:post).with(full_path_url).twice
end
entity.update!(source_xid: nil)
expect(Gitlab::Import::Logger).to receive(:error).with(
a_hash_including(
'message' => 'Failed to fetch source entity id',
'bulk_import_entity_id' => entity.id,
'pipeline_class' => 'ExportRequestWorker',
'exception_class' => 'NoMethodError',
'exception_message' => "undefined method `model_id' for nil:NilClass",
'correlation_id_value' => anything,
'bulk_import_id' => bulk_import.id,
'bulk_import_entity_type' => entity.source_type,
'importer' => 'gitlab_migration'
)
).twice
perform_multiple(job_args)
expect(entity.source_xid).to be_nil
end
end
end
end
end
context 'when entity is group' do
let(:entity) { create(:bulk_import_entity, :group_entity, source_full_path: 'foo/bar', bulk_import: bulk_import) }
let(:expected) { "/groups/#{entity.source_xid}/export_relations" }
let(:full_path_url) { '/groups/foo%2Fbar/export_relations' }
include_examples 'requests relations export for api resource'
end
context 'when entity is project' do
let(:entity) { create(:bulk_import_entity, :project_entity, source_full_path: 'foo/bar', bulk_import: bulk_import) }
let(:expected) { "/projects/#{entity.source_xid}/export_relations" }
let(:full_path_url) { '/projects/foo%2Fbar/export_relations' }
include_examples 'requests relations export for api resource'
end
end
end
|