summaryrefslogtreecommitdiff
path: root/workhorse/internal/upload/destination/objectstore/s3_session_test.go
blob: 4bbe38f90ec08309ae5805fa7d55e3ab1d9ca918 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
package objectstore

import (
	"testing"
	"time"

	"github.com/aws/aws-sdk-go/aws"
	"github.com/aws/aws-sdk-go/aws/endpoints"
	"github.com/stretchr/testify/require"

	"gitlab.com/gitlab-org/gitlab/workhorse/internal/config"
)

func TestS3SessionSetup(t *testing.T) {
	credentials := config.S3Credentials{}
	cfg := config.S3Config{Region: "us-west-1", PathStyle: true}

	sess, err := setupS3Session(credentials, cfg)
	require.NoError(t, err)

	s3Config := sess.ClientConfig(endpoints.S3ServiceID)
	require.Equal(t, "https://s3.us-west-1.amazonaws.com", s3Config.Endpoint)
	require.Equal(t, "us-west-1", s3Config.SigningRegion)
	require.True(t, aws.BoolValue(sess.Config.S3ForcePathStyle))

	require.Equal(t, len(sessionCache.sessions), 1)
	anotherConfig := cfg
	_, err = setupS3Session(credentials, anotherConfig)
	require.NoError(t, err)
	require.Equal(t, len(sessionCache.sessions), 1)

	ResetS3Session(cfg)
}

func TestS3SessionEndpointSetup(t *testing.T) {
	credentials := config.S3Credentials{}
	const customS3Endpoint = "https://example.com"
	const region = "us-west-2"
	cfg := config.S3Config{Region: region, PathStyle: true, Endpoint: customS3Endpoint}

	sess, err := setupS3Session(credentials, cfg)
	require.NoError(t, err)

	// ClientConfig is what is ultimately used by an S3 client
	s3Config := sess.ClientConfig(endpoints.S3ServiceID)
	require.Equal(t, customS3Endpoint, s3Config.Endpoint)
	require.Equal(t, region, s3Config.SigningRegion)

	stsConfig := sess.ClientConfig(endpoints.StsServiceID)
	require.Equal(t, "https://sts.amazonaws.com", stsConfig.Endpoint, "STS should use default endpoint")

	ResetS3Session(cfg)
}

func TestS3SessionExpiry(t *testing.T) {
	credentials := config.S3Credentials{}
	cfg := config.S3Config{Region: "us-west-1", PathStyle: true}

	sess, err := setupS3Session(credentials, cfg)
	require.NoError(t, err)

	require.Equal(t, aws.StringValue(sess.Config.Region), "us-west-1")
	require.True(t, aws.BoolValue(sess.Config.S3ForcePathStyle))

	firstSession, ok := sessionCache.sessions[cfg]
	require.True(t, ok)
	require.False(t, firstSession.isExpired())

	firstSession.expiry = time.Now().Add(-1 * time.Second)
	require.True(t, firstSession.isExpired())

	_, err = setupS3Session(credentials, cfg)
	require.NoError(t, err)

	nextSession, ok := sessionCache.sessions[cfg]
	require.True(t, ok)
	require.False(t, nextSession.isExpired())

	ResetS3Session(cfg)
}