summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValery Sizov <valery@gitlab.com>2015-01-23 23:40:56 +0000
committerValery Sizov <valery@gitlab.com>2015-01-23 23:40:56 +0000
commite8c953f2139ed44aed582eb58f552b945ffc4921 (patch)
treec39f5e726634276d57e9f723e896b95d1220b82e
parent8725f87d28b1453d97fe8fc8db5c7dcfe03c9652 (diff)
parent14650f701b68cc888c1f5b199949e894bc4a27c9 (diff)
downloadgitlab-ci-e8c953f2139ed44aed582eb58f552b945ffc4921.tar.gz
Merge branch 'slack-notification-fix' into 'master'
Fixed broken can_test for Slack notifications Small bug I noticed during e-mail notifications rework See merge request !29
-rw-r--r--app/models/project_services/slack_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/project_services/slack_service.rb b/app/models/project_services/slack_service.rb
index e187a9f..44f0cd4 100644
--- a/app/models/project_services/slack_service.rb
+++ b/app/models/project_services/slack_service.rb
@@ -50,7 +50,7 @@ class SlackService < Service
def can_test?
# slack notification is useful only for builds either successful or failed
- project.commits.order(id: desc).any? do |commit|
+ project.commits.order(id: :desc).any? do |commit|
case commit.status.to_sym
when :failed
true