diff options
author | Martin Kaufmann <kaufmann-m@mdw.ac.at> | 2015-07-23 07:48:57 +0200 |
---|---|---|
committer | Martin Kaufmann <kaufmann-m@mdw.ac.at> | 2015-07-23 07:48:57 +0200 |
commit | d4030094c911c2eba1325cafbbe3eeb4bc7f8e17 (patch) | |
tree | 0aeaab45a0e668c1f3f38dd9d92fe88529557857 | |
parent | a7d59ed9b87f24246f3907a5fe8a1b472e3fa740 (diff) | |
download | gitlab-ci-d4030094c911c2eba1325cafbbe3eeb4bc7f8e17.tar.gz |
Fix inline edit runner-description
Replaced .show and .hide with .removeClass('hide') and .addClass('hide') (Like done for #192 in MR 177)
-rw-r--r-- | CHANGELOG | 5 | ||||
-rw-r--r-- | app/assets/javascripts/application.js.coffee | 8 |
2 files changed, 7 insertions, 6 deletions
@@ -1,4 +1,5 @@ v7.13.0 + - Fix inline edit runner-description - Allow to specify image and services in yml that can be used with docker - Fix: No runner notification can see managers only - Ability to cancel all builds in commit at once @@ -40,7 +41,7 @@ v7.12.0 - Using .gitlab-ci.yml file instead of jobs - Link to the runner from the build page for admin user - Ability to set secret variables for runner - - Dont retry build when push same commit in same ref twice + - Dont retry build when push same commit in same ref twice - Admin area: show amount of runners with last contact less than a minute ago - Fix re-adding project with the same name but different gitlab_id - Implementation of Lint (.gitlab-ci.yml validation tool) @@ -84,7 +85,7 @@ v7.10.0 - Runners sorting in admin area (by id) - Remove protected_attributes gem - Skip commit creation if there is no appropriate job - + v7.9.3 - Contains no changes - Developers can cancel and retry jobs diff --git a/app/assets/javascripts/application.js.coffee b/app/assets/javascripts/application.js.coffee index 8645c78..933ede6 100644 --- a/app/assets/javascripts/application.js.coffee +++ b/app/assets/javascripts/application.js.coffee @@ -28,17 +28,17 @@ $(document).on 'click', '.edit-runner-link', (event) -> event.preventDefault() descr = $(this).closest('.runner-description').first() - descr.hide() + descr.addClass('hide') form = descr.next('.runner-description-form') descrInput = form.find('input.description') originalValue = descrInput.val() - form.show() + form.removeClass('hide') form.find('.cancel').on 'click', (event) -> event.preventDefault() - form.hide() + form.addClass('hide') descrInput.val(originalValue) - descr.show() + descr.removeClass('hide') $(document).on 'click', '.assign-all-runner', -> $(this).replaceWith('<i class="icon-refresh icon-spin"></i> Assign in progress..') |