<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch id-use-reports-for-code-navigation</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Use LSIF reports for code navigation</title>
<updated>2020-05-28T06:05:03+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2020-05-18T09:36:48+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=b7d9dad4824067d457ebc0a247f78504de0c4a25'/>
<id>b7d9dad4824067d457ebc0a247f78504de0c4a25</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-logrus-race' into 'master'</title>
<updated>2020-05-13T11:16:32+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-05-13T11:16:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=a38da6c11864f98950f7145ab5707bd461d16e39'/>
<id>a38da6c11864f98950f7145ab5707bd461d16e39</id>
<content type='text'>
Fix race conditions with logrus testing

Closes #450

See merge request gitlab-org/gitlab-shell!385</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix race conditions with logrus testing

Closes #450

See merge request gitlab-org/gitlab-shell!385</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-add-race-test' into 'master'</title>
<updated>2020-05-12T22:03:20+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2020-05-12T22:03:20+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=beb8bd54b7de608061592d4145c04b613bc94457'/>
<id>beb8bd54b7de608061592d4145c04b613bc94457</id>
<content type='text'>
Add race testing as separate CI step

See merge request gitlab-org/gitlab-shell!383</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add race testing as separate CI step

See merge request gitlab-org/gitlab-shell!383</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-release-13.2.0' into 'master'</title>
<updated>2020-05-12T10:02:26+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-05-12T10:02:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4851cf7430cf442446ff947015dd3ebd5303e2c8'/>
<id>4851cf7430cf442446ff947015dd3ebd5303e2c8</id>
<content type='text'>
Release v13.2.0

See merge request gitlab-org/gitlab-shell!384</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Release v13.2.0

See merge request gitlab-org/gitlab-shell!384</pre>
</div>
</content>
</entry>
<entry>
<title>Fix race conditions with logrus testing</title>
<updated>2020-05-12T05:31:13+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-12T05:02:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=0372634076cdfd7cda740cd040e16e629ea662e4'/>
<id>0372634076cdfd7cda740cd040e16e629ea662e4</id>
<content type='text'>
logrus fires a Goroutine to write logs, so the tests could fail if they
checked the event queue before the logrus have fired.  Since there isn't
an easy way to flush all outstanding hooks, we just retry every 100 ms
for up to a second for log to arrive in the queue.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
logrus fires a Goroutine to write logs, so the tests could fail if they
checked the event queue before the logrus have fired.  Since there isn't
an easy way to flush all outstanding hooks, we just retry every 100 ms
for up to a second for log to arrive in the queue.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</pre>
</div>
</content>
</entry>
<entry>
<title>Release v13.2.0</title>
<updated>2020-05-11T23:03:01+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-11T23:03:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=498abca4c637cb104b507d2c8d8658df4a78d58f'/>
<id>498abca4c637cb104b507d2c8d8658df4a78d58f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add race testing as separate CI step</title>
<updated>2020-05-11T20:29:23+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-11T20:26:31+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=ad452b146f332ce390c394d76a09803725f99e81'/>
<id>ad452b146f332ce390c394d76a09803725f99e81</id>
<content type='text'>
This would help catch race conditions such as
https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450 before merge.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would help catch race conditions such as
https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450 before merge.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-add-http-status-code' into 'master'</title>
<updated>2020-05-11T13:42:28+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2020-05-11T13:42:28+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=940aa912784b2e99d6f2a767f13bd013a62c94f8'/>
<id>940aa912784b2e99d6f2a767f13bd013a62c94f8</id>
<content type='text'>
Add HTTP status code to internal API logs

Closes #450

See merge request gitlab-org/gitlab-shell!376</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add HTTP status code to internal API logs

Closes #450

See merge request gitlab-org/gitlab-shell!376</pre>
</div>
</content>
</entry>
<entry>
<title>Fix race conditions in tests</title>
<updated>2020-05-08T22:40:18+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-08T22:40:18+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=c0cf314c5722a4f7ec0a1f355d23fa2511344989'/>
<id>c0cf314c5722a4f7ec0a1f355d23fa2511344989</id>
<content type='text'>
Calling logrus hook.LastEntry() can lead to race conditions.  Use
AllEntries instead:
https://github.com/sirupsen/logrus/blob/60c74ad9be0d874af0ab0daef6ab07c5c5911f0d/hooks/test/test.go#L77

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Calling logrus hook.LastEntry() can lead to race conditions.  Use
AllEntries instead:
https://github.com/sirupsen/logrus/blob/60c74ad9be0d874af0ab0daef6ab07c5c5911f0d/hooks/test/test.go#L77

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
</pre>
</div>
</content>
</entry>
<entry>
<title>Add HTTP status code to internal API logs</title>
<updated>2020-05-08T21:59:35+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-05-08T21:56:36+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=1adadc2e299529e805aae3dac7c2579b88c8dae7'/>
<id>1adadc2e299529e805aae3dac7c2579b88c8dae7</id>
<content type='text'>
This would make it easier to filter the logs by status code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would make it easier to filter the logs by status code.
</pre>
</div>
</content>
</entry>
</feed>
