delta/gitlab/gitlab-shell.git/lib, branch patch-1 gitlab.com: gitlab-org/gitlab-shell.git Pass relevant git environment variables while calling `/allowed` 2016-12-16T04:09:12+00:00 Timothy Andrew mail@timothyandrew.net 2016-12-07T07:39:47+00:00 fc2016484aacb82980c1c9082e195110f0eacb34 1. Starting version 2.11, git changed the way the pre-receive flow works. - Previously, the new potential objects would be added to the main repo. If the pre-receive passes, the new objects stay in the repo but are linked up. If the pre-receive fails, the new objects stay orphaned in the repo, and are cleaned up during the next `git gc`. - In 2.11, the new potential objects are added to a temporary "alternate object directory", that git creates for this purpose. If the pre-receive passes, the objects from the alternate object directory are migrated to the main repo. If the pre-receive fails the alternate object directory is simply deleted. 2. In our workflow, the pre-recieve script calls the `/allowed` endpoint on the rails server. This `/allowed` endpoint calls out directly to git to perform various checks. These direct calls to git do _not_ have the necessary environment variables set which allow access to the "alternate object directory" (explained above). Therefore these calls to git are not able to access any of the new potential objects to be added during this push. 3. We fix this by passing the relevant environment variables (GIT_ALTERNATE_OBJECT_DIRECTORIES, GIT_OBJECT_DIRECTORY, and GIT_QUARANTINE_PATH) to the `/allowed` endpoint, which will then include these environment variables while calling out to git. 
1. Starting version 2.11, git changed the way the pre-receive flow works.

  - Previously, the new potential objects would be added to the main repo. If the
    pre-receive passes, the new objects stay in the repo but are linked up. If
    the pre-receive fails, the new objects stay orphaned in the repo, and are
    cleaned up during the next `git gc`.

  - In 2.11, the new potential objects are added to a temporary "alternate object
    directory", that git creates for this purpose. If the pre-receive passes, the
    objects from the alternate object directory are migrated to the main repo. If
    the pre-receive fails the alternate object directory is simply deleted.

2. In our workflow, the pre-recieve script calls the `/allowed` endpoint on the
   rails server. This `/allowed` endpoint calls out directly to git to perform
   various checks. These direct calls to git do _not_ have the necessary
   environment variables set which allow access to the "alternate object
   directory" (explained above). Therefore these calls to git are not able to
   access any of the new potential objects to be added during this push.

3. We fix this by passing the relevant environment variables
   (GIT_ALTERNATE_OBJECT_DIRECTORIES, GIT_OBJECT_DIRECTORY, and
   GIT_QUARANTINE_PATH) to the `/allowed` endpoint, which will then include
   these environment variables while calling out to git.
Make custom hooks dir configurable 2016-12-12T13:21:42+00:00 Sean McGivern sean@gitlab.com 2016-12-09T12:52:26+00:00 fbc213eabdbb76ec846357d980705f5d4f20ecc5 Add a new configuration option, custom_hooks_dir. When this is set, we will look for global custom hooks in: <custom_hooks_dir>/{pre-receive,update,post-receive}.d/* When this is not set, default to <REPO_PATH>/hooks. 
Add a new configuration option, custom_hooks_dir. When this is set, we
will look for global custom hooks in:
    <custom_hooks_dir>/{pre-receive,update,post-receive}.d/*

When this is not set, default to <REPO_PATH>/hooks.
Make merge request text after push clearer 2016-12-08T21:29:29+00:00 Lisanne Fellinger lisanne.88@gmail.com 2016-11-28T14:50:01+00:00 ed37021cc296f4b3dda0d933c3b25cf212a29e5c Add changelog entry Editing changelog entry version 
Add changelog entry

Editing changelog entry version
avoid Dir.exists? duplication by moving the check to match_hook_files 2016-12-01T11:40:11+00:00 Elan Ruusamäe glen@delfi.ee 2016-11-16T00:12:07+00:00 872c66e977b3041e0c18543d2e00a255e8e89e41 






use String.end_with? instead of regexp
2016-12-01T11:40:11+00:00

Elan Ruusamäe
glen@delfi.ee

2016-11-16T00:08:50+00:00

d87c4b9c0d3aed4a23d74f340ece2c4bff83101b












custom_hook: chain custom hooks
2016-12-01T11:40:11+00:00

Elan Ruusamäe
glen@delfi.ee

2016-10-26T18:13:01+00:00

dbd4bc264baf611b91c03d799f77376963633551

update hooks lookup to use <hook>.d/* from repository hooks dir

the order would be:

1. <repository>.git/custom_hooks/<hook_name> - per project hook
2. <repository>.git/custom_hooks/<hook_name>.d/* - per project hooks
3. <repository>.git/hooks/<hook_name>.d/* - global hooks

only executable files are matched and backup files excluded (*~)
and the resulting list is sorted per each lookup





update hooks lookup to use <hook>.d/* from repository hooks dir

the order would be:

1. <repository>.git/custom_hooks/<hook_name> - per project hook
2. <repository>.git/custom_hooks/<hook_name>.d/* - per project hooks
3. <repository>.git/hooks/<hook_name>.d/* - global hooks

only executable files are matched and backup files excluded (*~)
and the resulting list is sorted per each lookup







custom_hook: add support for global custom hooks
2016-12-01T11:40:11+00:00

Dirk Hörner
dirker@gmail.com

2016-09-05T10:06:32+00:00

0e409ee49b1d68ea949da2d0504f325439ad53b3

This commit adds the option of having another set of global custom hooks
along with the already supported repository local custom hooks.

The repository local custom hook is executed first (if available). If
successful, execution continues with the global custom hook (if available).
This way, local custom hooks get priority over global custom hooks.

Global custom hooks can be enabled by placing an executable file into the
"custom_hooks" directory within gitlab-shell (create if it does not exist,
yet).





This commit adds the option of having another set of global custom hooks
along with the already supported repository local custom hooks.

The repository local custom hook is executed first (if available). If
successful, execution continues with the global custom hook (if available).
This way, local custom hooks get priority over global custom hooks.

Global custom hooks can be enabled by placing an executable file into the
"custom_hooks" directory within gitlab-shell (create if it does not exist,
yet).







custom_hook: refactor to pull repo_path into class
2016-12-01T11:40:11+00:00

Dirk Hörner
dirker@gmail.com

2016-09-05T09:59:25+00:00

d05522de85dcdfa91349c0d9fc78bf72931d6a39

This commit takes the GitlabCustomHook a bit clother to the other hook
handling classes by receiving the repo_path as argument to initialize()
instead of passing it to each method.





This commit takes the GitlabCustomHook a bit clother to the other hook
handling classes by receiving the repo_path as argument to initialize()
instead of passing it to each method.







custom_hook: only execute hook if file is executable
2016-12-01T11:40:11+00:00

Dirk Hörner
dirker@gmail.com

2016-09-05T08:44:18+00:00

2d774eeae8ccfb211cc6ab6aeab5db600f3fdc7c

This commit fixes an issue where an existing but unexecutable hook would
cause an uncaught execption.





This commit fixes an issue where an existing but unexecutable hook would
cause an uncaught execption.







Fetch repositories with --prune option by default.
2016-11-30T03:12:19+00:00

Ruben Davila
rdavila84@gmail.com

2016-11-30T03:12:19+00:00

2bca5ccbfc6e35b9852ca5af117744d3a9a45422

This will allow us to not recreate branches that has been deleted on the upstream and the mirror.





This will allow us to not recreate branches that has been deleted on the upstream and the mirror.