summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Vosmaer <contact@jacobvosmaer.nl>2015-02-26 18:12:00 +0100
committerJacob Vosmaer <contact@jacobvosmaer.nl>2015-02-26 18:12:00 +0100
commit1d7900b0e1e2545f122683b1ff6f40cc8beb6759 (patch)
tree14d88eccafb6fae701890758868ecf6f6ea014eb
parentc2b324a9411a3b6150e04976d2b36dd99c7a0887 (diff)
downloadgitlab-shell-1d7900b0e1e2545f122683b1ff6f40cc8beb6759.tar.gz
Remove recursive commands from bin/install
It is not clear what we need these for anymore. Because these commands would recurse once through all existing files in all Git repositories, and then another time through all directories these commands could take very long on a server with a lot of repositories. We keep the 'chmod' on config.repos_path, to deny world access to all files and directories beneath it.
-rw-r--r--CHANGELOG3
-rwxr-xr-xbin/install3
2 files changed, 4 insertions, 2 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 51d1d89..8269ed1 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,6 @@
+v2.5.4
+ - Remove recursive commands from bin/install
+
v2.5.3
- Improve git-annex integration
diff --git a/bin/install b/bin/install
index 64ae726..9847ae1 100755
--- a/bin/install
+++ b/bin/install
@@ -15,8 +15,7 @@ commands = [
%W(chmod 700 #{key_dir}),
%W(touch #{config.auth_file}),
%W(chmod 600 #{config.auth_file}),
- %W(chmod -R ug+rwX,o-rwx #{config.repos_path}),
- %W(find #{config.repos_path} -type d -exec chmod g+s {} ;)
+ %W(chmod ug+rwX,o-rwx #{config.repos_path}),
]
commands.each do |cmd|