summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Vosmaer <jacob@gitlab.com>2018-03-22 16:59:51 +0100
committerJacob Vosmaer <jacob@gitlab.com>2018-03-22 16:59:51 +0100
commitb08dd698f972622afd00de1a205c7c77213f2889 (patch)
tree7d575085e54cafafe34bc8a3822ea0421a7a3571
parente19b08ba3f985eacfdf0ecf1c06799959d02cfe7 (diff)
downloadgitlab-shell-b08dd698f972622afd00de1a205c7c77213f2889.tar.gz
Flush log file after every write
-rw-r--r--lib/gitlab_logger.rb2
-rw-r--r--spec/gitlab_logger_spec.rb8
2 files changed, 10 insertions, 0 deletions
diff --git a/lib/gitlab_logger.rb b/lib/gitlab_logger.rb
index cdca25b..1b49e9a 100644
--- a/lib/gitlab_logger.rb
+++ b/lib/gitlab_logger.rb
@@ -61,6 +61,8 @@ class GitlabLogger
else
log_file.puts format_text(data)
end
+
+ log_file.flush
end
def pid
diff --git a/spec/gitlab_logger_spec.rb b/spec/gitlab_logger_spec.rb
index 741ee13..b6159ea 100644
--- a/spec/gitlab_logger_spec.rb
+++ b/spec/gitlab_logger_spec.rb
@@ -112,4 +112,12 @@ describe GitlabLogger do
expect(JSON.parse(first_line)).to include('msg' => '"hello\x80world"')
end
end
+
+ describe 'flushing' do
+ it 'flushes the log file after each message' do
+ expect(output).to receive(:flush)
+
+ subject.info('hello')
+ end
+ end
end